HTMLTreeBuilder is very noisy with NOTIMPLEMENTED |
||
Issue descriptionVersion: 69e8ba23ef353ca5a06d2d9acd9da50ace03da28 refs/heads/master@{#383077} OS: All What steps will reproduce the problem? (1) Build chrome or content_shell (non-official build). (2) Run it and visit google.com. What is the expected output? Not implemented emitted only where this is unexpected. What do you see instead? [1:1:0324/134705:1131934668222:ERROR:HTMLTreeBuilder.cpp(2525)] Not implemented reached in void blink::HTMLTreeBuilder::defaultForInitial() [1:1:0324/134705:1131934668797:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *) [1:1:0324/134706:1131935248324:ERROR:HTMLTreeBuilder.cpp(1466)] Not implemented reached in bool blink::HTMLTreeBuilder::processBodyEndTagForInBody(blink::AtomicHTMLToken *) [1:1:0324/134706:1131935511019:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *) [1:1:0324/134706:1131935511251:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *) [1:1:0324/134706:1131935511471:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *) [1:1:0324/134706:1131935511717:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *) [1:1:0324/134706:1131935511898:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *) [1:1:0324/134706:1131935606457:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *) [1:1:0324/134706:1131935607020:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *) Either HTMLTreeBuilder is reaching unexpected code (unimplemented methods), or this is not actually an appropriate place to use NOTIMPLEMENTED(), which logs at the ERROR level in non-official builds. That's very noisy for Chromium developers.
,
Mar 24 2016
Send a patch to remove them?
,
Mar 24 2016
I'm going to revert the patch for now ...
,
Mar 24 2016
Revert in https://codereview.chromium.org/1828353002/ .
,
Mar 24 2016
should be fixed by https://codereview.chromium.org/1826283004/ |
||
►
Sign in to add a comment |
||
Comment 1 by xlai@chromium.org
, Mar 24 2016