New issue
Advanced search Search tips

Issue 597688 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

HTMLTreeBuilder is very noisy with NOTIMPLEMENTED

Project Member Reported by jbroman@chromium.org, Mar 24 2016

Issue description

Version: 69e8ba23ef353ca5a06d2d9acd9da50ace03da28 refs/heads/master@{#383077}
OS: All

What steps will reproduce the problem?
(1) Build chrome or content_shell (non-official build).
(2) Run it and visit google.com.

What is the expected output?
Not implemented emitted only where this is unexpected.

What do you see instead?
[1:1:0324/134705:1131934668222:ERROR:HTMLTreeBuilder.cpp(2525)] Not implemented reached in void blink::HTMLTreeBuilder::defaultForInitial()
[1:1:0324/134705:1131934668797:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/134706:1131935248324:ERROR:HTMLTreeBuilder.cpp(1466)] Not implemented reached in bool blink::HTMLTreeBuilder::processBodyEndTagForInBody(blink::AtomicHTMLToken *)
[1:1:0324/134706:1131935511019:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/134706:1131935511251:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/134706:1131935511471:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/134706:1131935511717:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/134706:1131935511898:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/134706:1131935606457:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)
[1:1:0324/134706:1131935607020:ERROR:HTMLTreeBuilder.cpp(2466)] Not implemented reached in void blink::HTMLTreeBuilder::processEndOfFile(blink::AtomicHTMLToken *)

Either HTMLTreeBuilder is reaching unexpected code (unimplemented methods), or this is not actually an appropriate place to use NOTIMPLEMENTED(), which logs at the ERROR level in non-official builds. That's very noisy for Chromium developers.
 

Comment 1 by xlai@chromium.org, Mar 24 2016

Labels: -Pri-3 Pri-2
Is anyone working on this problem? The layout test log file becomes so huge that the browser on my laptop hangs when I try to open the log file. I believe that this is slowing down layout tests as well.

Comment 2 by danakj@chromium.org, Mar 24 2016

Send a patch to remove them?
I'm going to revert the patch for now ...

Comment 5 by tkent@chromium.org, Mar 24 2016

Owner: dpranke@chromium.org
Status: Fixed (was: Untriaged)
should be fixed by https://codereview.chromium.org/1826283004/

Sign in to add a comment