Developer build crashes with DCHECK, when attempting to enable sound recognition
Reported by
denis.ya...@gmail.com,
Mar 24 2016
|
||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/47.0.2526.111 YaBrowser/16.3.0.5640 Safari/537.36 Example URL: google.com Steps to reproduce the problem: 1. Open google.com 2. Click on mic icon 3. Allow to use your microphone What is the expected behavior? Chrome doesn't crush What went wrong? 59188:30723:0324/195143:FATAL:audio_manager_mac.cc(76)] Check failed: AudioManager::Get()->GetTaskRunner()->BelongsToCurrentThread(). 0 Chromium Framework 0x000000010bd966cf _ZN4base5debug10StackTraceC2Ev + 47 1 Chromium Framework 0x000000010bd96873 _ZN4base5debug10StackTraceC1Ev + 35 2 Chromium Framework 0x000000010be15fe0 _ZN7logging10LogMessageD2Ev + 80 3 Chromium Framework 0x000000010be13913 _ZN7logging10LogMessageD1Ev + 35 4 Chromium Framework 0x000000010f756e98 _ZN5mediaL16HasAudioHardwareEj + 264 5 Chromium Framework 0x000000010f756fa6 _ZN5media15AudioManagerMac20HasAudioInputDevicesEv + 38 6 Chromium Framework 0x00000001176ca8d8 _ZN7content20SpeechRecognizerImpl14StartRecordingERKNS0_12FSMEventArgsE + 1240 7 Chromium Framework 0x00000001176c9d0f _ZN7content20SpeechRecognizerImpl32ExecuteTransitionAndGetNextStateERKNS0_12FSMEventArgsE + 175 8 Chromium Framework 0x00000001176c78a0 _ZN7content20SpeechRecognizerImpl13DispatchEventERKNS0_12FSMEventArgsE + 1136 9 Chromium Framework 0x00000001176cea85 _ZN4base8internal15RunnableAdapterIMN7content20SpeechRecognizerImplEFvRKNS3_12FSMEventArgsEEE3RunIS3_JS6_EEEvRK13scoped_refptrIT_EDpOT0_ + 149 10 Chromium Framework 0x00000001176ce94a _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMN7content20SpeechRecognizerImplEFvRKNS4_12FSMEventArgsEEEEE8MakeItSoIJRK13scoped_refptrIS4_ES7_EEEvSA_DpOT_ + 74 11 Chromium Framework 0x00000001176ce8dc _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1EEEENS0_9BindStateINS0_15RunnableAdapterIMN7content20SpeechRecognizerImplEFvRKNS7_12FSMEventArgsEEEEFvPS7_SA_EJSE_S8_EEENS0_12InvokeHelperILb0EvSD_EEFvvEE3RunEPNS0_13BindStateBaseE + 140 12 Chromium Framework 0x000000010f6aceff _ZNK4base8CallbackIFvvELNS_8internal8CopyModeE1EE3RunEv + 63 13 Chromium Framework 0x000000010bd97f0e _ZN4base5debug13TaskAnnotator7RunTaskEPKcRKNS_11PendingTaskE + 654 14 Chromium Framework 0x000000010be542f0 _ZN4base11MessageLoop7RunTaskERKNS_11PendingTaskE + 848 15 Chromium Framework 0x000000010be54926 _ZN4base11MessageLoop21DeferOrRunPendingTaskERKNS_11PendingTaskE + 86 16 Chromium Framework 0x000000010be54fd8 _ZN4base11MessageLoop6DoWorkEv + 552 17 Chromium Framework 0x000000010bd5411f _ZN4base19MessagePumpLibevent3RunEPNS_11MessagePump8DelegateE + 319 18 Chromium Framework 0x000000010be53b3a _ZN4base11MessageLoop10RunHandlerEv + 298 19 Chromium Framework 0x000000010beeb095 _ZN4base7RunLoop3RunEv + 85 20 Chromium Framework 0x000000010be5162f _ZN4base11MessageLoop3RunEv + 303 21 Chromium Framework 0x000000010bf94a47 _ZN4base6Thread3RunEPNS_11MessageLoopE + 39 22 Chromium Framework 0x00000001167a9637 _ZN7content17BrowserThreadImpl11IOThreadRunEPN4base11MessageLoopE + 71 23 Chromium Framework 0x00000001167a99cf _ZN7content17BrowserThreadImpl3RunEPN4base11MessageLoopE + 751 24 Chromium Framework 0x000000010bf951ed _ZN4base6Thread10ThreadMainEv + 1613 25 Chromium Framework 0x000000010bf797d1 _ZN4base12_GLOBAL__N_110ThreadFuncEPv + 705 26 libsystem_pthread.dylib 0x00007fff8aabb05a _pthread_body + 131 27 libsystem_pthread.dylib 0x00007fff8aabafd7 _pthread_body + 0 28 libsystem_pthread.dylib 0x00007fff8aab83ed thread_start + 13 Did this work before? N/A Is it a problem with Flash or HTML5? N/A Does this work in other browsers? N/A Chrome version: 51.0.2690.0 (Developer Build) (64-bit) Channel: n/a OS Version: OS X 10.10.5 Flash Version: last commit: commit b5da6b9dbae869c46ded3fe00c6d12c67fd9a505 Author: falken <falken@chromium.org> Date: Thu Mar 24 05:28:28 2016 -0700 Reenable ServiceWorkerVersionBrowserTest.TimeoutStartingWorker I suspect fixing Issue 568465 fixed this flake. BUG= 496065 Review URL: https://codereview.chromium.org/1829583006 Cr-Commit-Position: refs/heads/master@{#383055}
,
Mar 24 2016
+grunnell, tommi who were working on this recently I believe.
,
Mar 29 2016
can one of the folks in cc line pick this bug?
,
Mar 29 2016
,
Apr 14 2016
I can't repro with tot build (52.x.x.x). In the report it says "Chrome/47.0.2526.111", although further down "Chrome version: 51.0.2690.0", so it's ambiguous. If it's 47 it's likely an issue that's already fixed. Can you still repro with the latest code?
,
Apr 14 2016
+guidou who might be able to help.
,
Apr 14 2016
The problem is that AudioManager::HasAudioInputDevices() should be invoked on the TaskRunner thread. https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/speech/speech_recognizer_impl.cc&q=content::SpeechRecognizerImpl::StartRecording&sq=package:chromium&type=cs&l=512
,
Apr 14 2016
Actually, both HasAudioInputDevices() and GetInputStreamParameters() should be invoked on the TaskRunner thread.
,
Apr 14 2016
I realized I didn't have dchecks enabled in my build...
,
Apr 14 2016
I can repro. I guess this due to the threading changes done recently on Mac.
,
Apr 14 2016
@grunell I've updated master, the issue is still reproduced. Last commit Thu Apr 14 02:20:52 2016
,
Apr 18 2016
It looks like this was introduced with revision 381282. alokp@, can you take a look.
,
Apr 18 2016
My patch should not have any functional change (at least on mac). The threads are exactly the same. I do not have a mac. Can anybody check if reverting the patch fixes the issue? Bouncing it back to grunell@ to verify if it is indeed caused by r381282.
,
Apr 27 2016
I synced out revision 381281 and that crashes too. So that CL is not it.
,
Apr 27 2016
Guido, when you landed revision 373928 which adds the DCHECK, do you know if you tested the speech recognizer?
,
Apr 27 2016
I did not specifically test it. I did make sure that all the tests and code accessed from tests run by bots were updated to use the right thread.
,
May 4 2016
OK, it seems hard to narrow down to when this started. Anyhow, it might be best to just fix it since we know what the problem is. I won't have time for a while to work on this.
,
Apr 3 2017
I can't repro this anymore, with DCHECKs enabled. |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by meh...@chromium.org
, Mar 24 2016