New issue
Advanced search Search tips

Issue 597654 link

Starred by 1 user
Status: Fixed
Owner:
zmin@chromium.org
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Make the name of the installer log file dependent on branding

Project Member Reported by grt@chromium.org, Mar 24 2016 
Chrome's installer writes to a file name chrome_installer.log. This filename should, in some way, be dependent on the branding so that Google Chrome uses a different file than, for example, Chromium.

Comment 1 by grt@chromium.org, Apr 28 2016

Owner: zmin@chromium.org
Status: Assigned (was: Available)
Hi Owen. Could you look into this? The filename is picked in chrome/installer/util/logging_installer.cc. I think the fix could be as simple as making the name conditional on #if defined(GOOGLE_CHROME_BUILD). Thanks.

Comment 2 by zmin@chromium.org, Apr 28 2016 

Looking into it.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d29a7198ebde81e5fc554d13354a6ca2ae40637

commit 9d29a7198ebde81e5fc554d13354a6ca2ae40637
Author: zmin <zmin@chromium.org>
Date: Fri Apr 29 16:33:16 2016

Change installer log for Chromium to chromium_installer.log

BUG= 597654 

Review-Url: https://codereview.chromium.org/1929333002
Cr-Commit-Position: refs/heads/master@{#390668}

[modify] https://crrev.com/9d29a7198ebde81e5fc554d13354a6ca2ae40637/chrome/installer/util/logging_installer.cc

Comment 4 by zmin@chromium.org, May 2 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment