New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597634 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue skia:5077



Sign in to add a comment

Remove SK_SUPPORT_LEGACY_PICTURE_PTR

Project Member Reported by fmalita@chromium.org, Mar 24 2016

Issue description

Convert to the sk_sp-enabled APIs.

 
Chromium-side landed in https://codereview.chromium.org/1819683002.
Blocking: skia:5077
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e89d089491acaa32fe1d83f60eae0511811e5a7

commit 9e89d089491acaa32fe1d83f60eae0511811e5a7
Author: fmalita <fmalita@chromium.org>
Date: Mon Mar 28 15:44:49 2016

Use sk_sp-based picture recording APIs in Blink

1) use SkPictureRecorder::finishRecordingAsPicture() over endRecordingAsPicture()

2) store as sk_sp<SkPicture> (when localized) or convert to (Pass)RefPtr (when retained in Blink).

(+ a couple of Chromium clients which were missed in prev CLs)

BUG=skia:5077, chromium:597634 

Review URL: https://codereview.chromium.org/1823133002

Cr-Commit-Position: refs/heads/master@{#383496}

[modify] https://crrev.com/9e89d089491acaa32fe1d83f60eae0511811e5a7/android_webview/browser/browser_view_renderer.cc
[modify] https://crrev.com/9e89d089491acaa32fe1d83f60eae0511811e5a7/content/renderer/skia_benchmarking_extension.cc
[modify] https://crrev.com/9e89d089491acaa32fe1d83f60eae0511811e5a7/skia/config/SkUserConfig.h
[modify] https://crrev.com/9e89d089491acaa32fe1d83f60eae0511811e5a7/third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp
[modify] https://crrev.com/9e89d089491acaa32fe1d83f60eae0511811e5a7/third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
[modify] https://crrev.com/9e89d089491acaa32fe1d83f60eae0511811e5a7/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
[modify] https://crrev.com/9e89d089491acaa32fe1d83f60eae0511811e5a7/third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp
[modify] https://crrev.com/9e89d089491acaa32fe1d83f60eae0511811e5a7/third_party/WebKit/Source/platform/graphics/Image.cpp
[modify] https://crrev.com/9e89d089491acaa32fe1d83f60eae0511811e5a7/third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp
[modify] https://crrev.com/9e89d089491acaa32fe1d83f60eae0511811e5a7/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp
[modify] https://crrev.com/9e89d089491acaa32fe1d83f60eae0511811e5a7/third_party/WebKit/Source/platform/graphics/paint/DisplayItemListTest.cpp
[modify] https://crrev.com/9e89d089491acaa32fe1d83f60eae0511811e5a7/third_party/WebKit/Source/platform/testing/TestPaintArtifact.cpp

Status: Fixed (was: Started)

Sign in to add a comment