Add android_cronet_tester to tools/mb/mb_config.pyl |
||||
Issue descriptionFollowing https://codereview.chromium.org/1750743002/, to make android_cronet_tester work, we need to add it to tools/mb/mb_config.pyl Probably can duplicate the config of the current chromium.android bots.
,
Mar 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a56b36b8744bdf0ce95eadce89e14e55c5af971 commit 2a56b36b8744bdf0ce95eadce89e14e55c5af971 Author: xunjieli <xunjieli@chromium.org> Date: Thu Mar 24 18:15:25 2016 Add a mb config to android_cronet_tester trybot BUG= 597596 Review URL: https://codereview.chromium.org/1832843002 Cr-Commit-Position: refs/heads/master@{#383099} [modify] https://crrev.com/2a56b36b8744bdf0ce95eadce89e14e55c5af971/tools/mb/mb_config.pyl
,
Mar 24 2016
Current url: https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet_tester/builds/75/steps/Instrumentation%20test%20CronetTestInstrumentation/logs/stdio It looks like the trybot is still not usable. I will take a look. It is complaining that: C 97.060s Main [FAIL] C 97.060s Main java.lang.UnsatisfiedLinkError: Couldn't load cronet_tests from loader dalvik.system.PathClassLoader[DexPathList[[zip file "/system/framework/android.test.runner.jar", zip file "/data/app/org.chromium.net.tests-1.apk", zip file "/data/app/org.chromium.net-1.apk"],nativeLibraryDirectories=[/data/app-lib/org.chromium.net.tests-1, /data/app-lib/org.chromium.net-1, /vendor/lib, /system/lib]]]: findLibrary returned null
,
Mar 24 2016
jbudorick@, martiniss@: do you know why the trybot is building libcronet_tests.cr.so instead of libcronet_tests.so (which is what other bots are building https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Builder%20%28dbg%29/builds/1540/steps/compile/logs/stdio) ?
,
Mar 24 2016
guessing it should be doing a static library build: https://code.google.com/p/chromium/codesearch#chromium/src/build/common.gypi&l=4785
,
Mar 24 2016
(if you want libcronet_tests.so specifically)
,
Mar 24 2016
That said, having the shared_library build fail also seems bad. I'll look into it later today.
,
Mar 24 2016
cc-ing dirk, since this might have something to do with mb?
,
Mar 24 2016
this has to do with our mb_config entry for that trybot, not mb itself.
,
Mar 24 2016
That bot is configured to be doing a static build: https://code.google.com/p/chromium/codesearch?q=mb_config.pyl#chromium/src/tools/mb/mb_config.pyl&l=31 https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Builder%20%28dbg%29/builds/1540/steps/generate_build_files/logs/stdio The trybot is configured to be a shared build, however. You should probably change the chromium.android bot.
,
Mar 24 2016
Thanks, everyone! So android_cronet_tester is doing a shared build, while other bots like android_cronet_gyp_debug_static_bot is doing a static build. But I don't really know understand why the instrumentation test would complain that the libcronet_test.so is not found on the shared build bot (android_cronet_tester). I will get back to this tomorrow and wait for jbudorick@ to get a chance to take a look.
,
Mar 25 2016
This is cronet-specific because of how cronet loads native libraries in CronetEngine :( CronetTestFramework creates a CronetEngine.Builder that looks explicitly for cronet_tests (https://code.google.com/p/chromium/codesearch#chromium/src/components/cronet/android/test/src/org/chromium/net/CronetTestFramework.java&l=238). CronetEngine.Builder then tries to load that library, which it can't because the library is libcronet_test.cr.so instead of libcronet_test.so. The quick solution here would be to switch android_cronet_tester to a static build, but in the longer term the native library loading logic in cronet either needs to handle shared libraries better or should simply defer to LibraryLoader/NativeLibraries (https://code.google.com/p/chromium/codesearch#chromium/src/base/android/java/src/org/chromium/base/library_loader/LibraryLoader.java and https://code.google.com/p/chromium/codesearch#chromium/src/base/android/java/templates/NativeLibraries.template&q=NativeLibraries.template)
,
Mar 25 2016
I thinks switching android_cronet_tester to a static build makes total sense as that's the way cronet is packaged (single native library libcronet.so) and used by embedders.
,
Mar 25 2016
#13: CL doing is here: https://codereview.chromium.org/1838433002/
,
Mar 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/348a13d830f6f7e3c3f73f97c0f7f206bc3763fa commit 348a13d830f6f7e3c3f73f97c0f7f206bc3763fa Author: jbudorick <jbudorick@chromium.org> Date: Fri Mar 25 20:33:59 2016 [cronet] Switch android_cronet_tester to static_library. BUG= 597596 Review URL: https://codereview.chromium.org/1838433002 Cr-Commit-Position: refs/heads/master@{#383344} [modify] https://crrev.com/348a13d830f6f7e3c3f73f97c0f7f206bc3763fa/tools/mb/mb_config.pyl
,
Mar 28 2016
,
Mar 28 2016
Verified that android_cronet_tester is working as expected. Thanks, everyone.
,
Mar 28 2016
Hooray! Glad everything is working now. |
||||
►
Sign in to add a comment |
||||
Comment 1 by xunji...@chromium.org
, Mar 24 2016Status: Assigned (was: Available)