New issue
Advanced search Search tips

Issue 597583 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Jul 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression on 51.0.2687.0: PNGImageDecoder.cpp:237:45: error: cannot initialize a parameter of type 'const char *' with an lvalue of type 'png_bytep' (aka 'unsigned char *')

Reported by sl1pk...@gmail.com, Mar 24 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.18 Safari/537.36

Steps to reproduce the problem:
1. download dev channel 51.0.2687.0
2. use gyp_chromium for build
3. build

What is the expected behavior?
build ok

What went wrong?
fail build

Did this work before? N/A 

Chrome version: 50.0.2661.18  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 21.0 r0

regression in this commit: https://codereview.chromium.org/1746283002

[9482/19476] /tmp/makepkg/chromium-dev/src/chromium-51.0.2687.0/third_party/llvm-build/Release+Asserts/bin/clang++ -Qunused-arguments -MMD -MF obj/third_party/WebKit/Source/platform/network/blink_platform.ContentSecurityPolicyResponseHeaders.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=263324-1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DBLINK_PLATFORM_IMPLEMENTATION=1 -DINSIDE_BLINK -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DWTF_USE_ICCJPEG=1 -DWTF_USE_QCMSLIB=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DENABLE_OILPAN=1 -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DENABLE_WEBP -DUSE_SYSTEM_LIBJPEG -D__STDC_CONSTANT_MACROS -DUSE_SYSTEM_FFMPEG -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_NSS_VERIFIER=1 -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen/shim_headers/libvpx/target -Igen/shim_headers/libpng/target -Igen/shim_headers/harfbuzz-ng/target -Igen/shim_headers/zlib/target -Igen -I../../third_party/angle/include -Igen/blink -I../../third_party/ffmpeg -I../.. -I../../skia/config -I../../third_party/WebKit/Source -I../../third_party/khronos -I../../gpu -Igen/angle -I../../third_party/WebKit -Igen/third_party/WebKit -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/iccjpeg -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/ots/include -I../../third_party/qcms/src -I../../v8/include -fstack-protector --param=ssp-buffer-size=4  -pthread -fno-strict-aliasing -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Xclang -load -Xclang /tmp/makepkg/chromium-dev/src/chromium-51.0.2687.0/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -fcolor-diagnostics -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wglobal-constructors -Xclang -load -Xclang /tmp/makepkg/chromium-dev/src/chromium-51.0.2687.0/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.so -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang enable-oilpan -Xclang -plugin-arg-blink-gc-plugin -Xclang warn-raw-ptr -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables -march=native -O2 -pipe -fstack-protector-strong -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11  -c ../../third_party/WebKit/Source/platform/network/ContentSecurityPolicyResponseHeaders.cpp -o obj/third_party/WebKit/Source/platform/network/blink_platform.ContentSecurityPolicyResponseHeaders.o
FAILED: /tmp/makepkg/chromium-dev/src/chromium-51.0.2687.0/third_party/llvm-build/Release+Asserts/bin/clang++ -Qunused-arguments -MMD -MF obj/third_party/WebKit/Source/platform/image-decoders/png/blink_platform.PNGImageDecoder.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=263324-1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_TOPCHROME_MD=1 -DUSE_UDEV -DFIELDTRIAL_TESTING_ENABLED -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PDF=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_HANGOUT_SERVICES_EXTENSION=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DBLINK_PLATFORM_IMPLEMENTATION=1 -DINSIDE_BLINK -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DWTF_USE_ICCJPEG=1 -DWTF_USE_QCMSLIB=1 -DWTF_USE_WEBAUDIO_FFMPEG=1 -DWTF_USE_DEFAULT_RENDER_THEME=1 -DENABLE_OILPAN=1 -DSK_SUPPORT_GPU=1 -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DENABLE_WEBP -DUSE_SYSTEM_LIBJPEG -D__STDC_CONSTANT_MACROS -DUSE_SYSTEM_FFMPEG -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_NSS_VERIFIER=1 -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -Igen/shim_headers/libvpx/target -Igen/shim_headers/libpng/target -Igen/shim_headers/harfbuzz-ng/target -Igen/shim_headers/zlib/target -Igen -I../../third_party/angle/include -Igen/blink -I../../third_party/ffmpeg -I../.. -I../../skia/config -I../../third_party/WebKit/Source -I../../third_party/khronos -I../../gpu -Igen/angle -I../../third_party/WebKit -Igen/third_party/WebKit -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/iccjpeg -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/ots/include -I../../third_party/qcms/src -I../../v8/include -fstack-protector --param=ssp-buffer-size=4  -pthread -fno-strict-aliasing -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Xclang -load -Xclang /tmp/makepkg/chromium-dev/src/chromium-51.0.2687.0/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -fcolor-diagnostics -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wglobal-constructors -Xclang -load -Xclang /tmp/makepkg/chromium-dev/src/chromium-51.0.2687.0/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin.so -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang enable-oilpan -Xclang -plugin-arg-blink-gc-plugin -Xclang warn-raw-ptr -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng16 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -m64 -march=x86-64 -O2 -fno-ident -fdata-sections -ffunction-sections -funwind-tables -march=native -O2 -pipe -fstack-protector-strong -D_FORTIFY_SOURCE=2 -fno-exceptions -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11  -c ../../third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp -o obj/third_party/WebKit/Source/platform/image-decoders/png/blink_platform.PNGImageDecoder.o
../../third_party/WebKit/Source/platform/image-decoders/png/PNGImageDecoder.cpp:237:45: error: cannot initialize a parameter of type 'const char *' with an lvalue of type 'png_bytep' (aka 'unsigned char *')
                setColorProfileAndTransform(profile, profileLength, imageHasAlpha, false /* useSRGB */);
                                            ^~~~~~~
../../third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:236:50: note: passing argument to parameter 'iccData' here
    void setColorProfileAndTransform(const char* iccData, unsigned iccLength, bool hasAlpha, bool useSRGB);
                                                 ^
1 error generated.
ninja: build stopped: subcommand failed.

gyp options:

'-Dclang_use_chrome_plugins=1'
'-Dhost_clang=1'
'-Dclang=1'
'-Ddisable_glibc=1'
'-Ddisable_fatal_linker_warnings=1'
'-Denable_sql_database=0'
'-Denable_hidpi=1'
'-Denable_touch_ui=1'
'-Denable_webrtc=1'
'-Denable_widevine=1'
'-Denable_pepper_cdms=1'
'-Denable_hotwording=0'
'-Denable_hangout_services_extension=1'
'-Dffmpeg_branding=ChromeOS'
'-Dlibspeechd_h_prefix=speech-dispatcher/'
'-Dlinux_link_gnome_keyring=0'
'-Dlinux_link_gsettings=0'
'-Dlinux_link_kerberos=1'
'-Dlinux_link_libbrlapi=1'
'-Dlinux_link_libpci=1'
'-Dlinux_link_libspeechd=1'
'-Dlinux_link_pulseaudio=1'
'-Dlinux_strip_binary=1'
'-Dlinux_use_bundled_binutils=0'
'-Dlinux_use_bundled_gold=0'
'-Dlinux_use_gold_flags=0'
'-Dlogging_like_official_build=1'
'-Dno_strict_aliasing=1'
'-Dproprietary_codecs=1'
'-Dpython_ver=2.7'
'-Dremove_webcore_debug_symbols=1'
'-Dtarget_arch=x64'
'-Dusb_ids_path=/usr/share/hwdata/usb.ids'
'-Duse_gconf=0'
'-Duse_gio=0'
'-Duse_gnome_keyring=0'
'-Duse_gtk3=1'
'-Duse_pulseaudio=1
'-Duse_sysroot=0'
'-Dwerror='
'-Duse_system_expat=1'
'-Duse_system_ffmpeg=1'
'-Duse_system_flac=1'
'-Duse_system_fontconfig=1'
'-Duse_system_harfbuzz=1'
'-Duse_system_icu=1'
'-Duse_system_jsoncpp=1'
'-Duse_system_libevent=0'
'-Duse_system_libexif=1'
'-Duse_system_libjpeg=1'
'-Duse_system_libpng=1'
'-Duse_system_libsrtp=0'
'-Duse_system_libusb=0'
'-Duse_system_libvpx=1'
'-Duse_system_libwebp=1'
'-Duse_system_libxml=1'
'-Duse_system_libxnvctrl=0'
'-Duse_system_libxslt=1'
'-Duse_system_minizip=1'
'-Duse_system_nspr=1'
'-Duse_system_openssl=0'
'-Duse_system_opus=0'
'-Duse_system_protobuf=0'
'-Duse_system_re2=0'
'-Duse_system_snappy=1'
'-Duse_system_speex=1'
'-Duse_system_sqlite=0'
'-Duse_system_ssl=0'
'-Duse_system_v8=0'
'-Duse_system_yasm=1'
'-Duse_system_xdg_utils=1'
'-Duse_system_zlib=1'
 
Components: Blink>Image
Seems this build is configured against using some system libpng variant.

The regression CL quote seems to have no bearing on the issue.
Components: -Blink>Image Build
Status: WontFix (was: Unconfirmed)
Fixing individual build environments is not something we can do, and clearly things are working fine in the supported environments on the try servers and other build infrastructure. libpng should be pulled from third_party deps, not the local machine.

Comment 3 by sl1pk...@gmail.com, Jul 12 2016

thats is if set '-Duse_system_libpng=0', but set '-Duse_system_libpng=1'still fail

ergo is your fault. not my system

please cc to Pawel Hajdan, Jr

Sign in to add a comment