New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 597572 link

Starred by 1 user
Status: Fixed
Owner:
█ lushnikov@chromium.org
Last visit 29 days ago
Closed: Dec 2017
Cc:
pfeldman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

http/tests/inspector/resource-tree/resource-tree-reload.html is flaky on WebKit Win non-Oilpan (dbg)

Project Member Reported by battre@chromium.org, Mar 24 2016 
http/tests/inspector/resource-tree/resource-tree-reload.html is flaky, suspecting https://crrev.com/89f7238cebbf5d77e4caa84d0a2750f6faa7e983.

First occurrence here: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20non-Oilpan%20%28dbg%29/builds/484 (range 330216...330252)

I was able to reproduce this on my Linux box some times. Here is the diff:

--- /media/ssd_lv/battre/chrome/src/out/Debug/layout-test-results/http/tests/inspector/resource-tree/resource-tree-reload-expected.txt
+++ /media/ssd_lv/battre/chrome/src/out/Debug/layout-test-results/http/tests/inspector/resource-tree/resource-tree-reload-actual.txt
@@ -49,7 +49,6 @@
   resource-tree-reload-iframe.html
     resource-tree-reload-iframe.html
     script-initial.js
-    styles-initial-2.css
 Sources:
 -------- Setting mode: [frame/domain]
 top
@@ -63,7 +62,6 @@
     127.0.0.1:8000
       resource-tree-reload-iframe.html
       script-initial.js
-      styles-initial-2.css
 Sources:
 -------- Setting mode: [frame/domain/folder]
 top
@@ -81,7 +79,6 @@
       inspector/resource-tree/resources
         resource-tree-reload-iframe.html
         script-initial.js
-        styles-initial-2.css
 Sources:
 -------- Setting mode: [domain]
 127.0.0.1:8000
@@ -91,7 +88,6 @@
   resource-tree-test.js
   resources-test.js
   script-initial.js
-  styles-initial-2.css
   styles-initial.css
 Sources:
 -------- Setting mode: [domain/folder]
@@ -101,7 +97,6 @@
       resources
         resource-tree-reload-iframe.html
         script-initial.js
-        styles-initial-2.css
         styles-initial.css
       resource-tree-reload.html
       resource-tree-test.js
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46c66a666056b2bca1e991442a42e09af4cbee5b

commit 46c66a666056b2bca1e991442a42e09af4cbee5b
Author: battre <battre@chromium.org>
Date: Thu Mar 24 11:52:23 2016

Revert of [DevTools] Use InspectorFrontendHost.readyForTest for layout tests. (patchset #3 id:40001 of https://codereview.chromium.org/1819243002/ )

Reason for revert:
http/tests/inspector/resource-tree/resource-tree-reload.html is flaky

BUG= 597572 

Original issue's description:
> [DevTools] Use InspectorFrontendHost.readyForTest for layout tests.
>
> BUG=none
>
> Committed: https://crrev.com/89f7238cebbf5d77e4caa84d0a2750f6faa7e983
> Cr-Commit-Position: refs/heads/master@{#383015}

TBR=pfeldman@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1828983002

Cr-Commit-Position: refs/heads/master@{#383053}

[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/chrome/browser/devtools/devtools_window.h
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/chrome/browser/devtools/devtools_window_testing.cc
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/components/test_runner/web_test_delegate.h
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/content/shell/browser/layout_test/blink_test_controller.h
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/content/shell/browser/layout_test/layout_test_devtools_frontend.cc
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/content/shell/browser/layout_test/layout_test_devtools_frontend.h
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/content/shell/browser/shell_devtools_frontend.h
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/content/shell/common/shell_messages.h
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/third_party/WebKit/LayoutTests/inspector-protocol/json-parse.html
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.cpp
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.h
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/third_party/WebKit/Source/devtools/front_end/devtools.js
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/third_party/WebKit/Source/devtools/protocol.json
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
[modify] https://crrev.com/46c66a666056b2bca1e991442a42e09af4cbee5b/third_party/WebKit/public/web/WebDevToolsAgent.h

Comment 2 by dgozman@chromium.org, Mar 25 2016 

I was able to repro locally with the patch. Made a fix to the test and now cannot repro. That could mean it's not flaky anymore, so I'll try to land the patch again.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdb67c0b431bf1726f0d91626c952086a4346c5c

commit bdb67c0b431bf1726f0d91626c952086a4346c5c
Author: dgozman <dgozman@chromium.org>
Date: Fri Mar 25 03:32:26 2016

[DevTools] Use InspectorFrontendHost.readyForTest for layout tests.

Attempt #2. First one made http/tests/inspector/resource-tree/resource-tree-reload.html flaky.

BUG= 597572 

Review URL: https://codereview.chromium.org/1819243002

Cr-Commit-Position: refs/heads/master@{#383238}

[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/chrome/browser/devtools/devtools_window.h
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/chrome/browser/devtools/devtools_window_testing.cc
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/components/test_runner/web_test_delegate.h
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/content/shell/browser/layout_test/blink_test_controller.h
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/content/shell/browser/layout_test/layout_test_devtools_frontend.cc
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/content/shell/browser/layout_test/layout_test_devtools_frontend.h
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/content/shell/browser/shell_devtools_frontend.h
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/content/shell/common/shell_messages.h
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/third_party/WebKit/LayoutTests/http/tests/inspector-protocol/resources/protocol-test.html
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/third_party/WebKit/LayoutTests/http/tests/inspector/resource-tree/resource-tree-reload.html
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/third_party/WebKit/LayoutTests/inspector-protocol/json-parse.html
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.cpp
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/third_party/WebKit/Source/core/inspector/InspectorInspectorAgent.h
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/third_party/WebKit/Source/devtools/front_end/devtools.js
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/third_party/WebKit/Source/devtools/protocol.json
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/third_party/WebKit/Source/web/WebDevToolsAgentImpl.h
[modify] https://crrev.com/bdb67c0b431bf1726f0d91626c952086a4346c5c/third_party/WebKit/public/web/WebDevToolsAgent.h

Comment 4 by dgozman@chromium.org, Mar 25 2016

Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d55cd51f1202e555ef2e9d43674bcaaf3f5eaefc

commit d55cd51f1202e555ef2e9d43674bcaaf3f5eaefc
Author: dgozman <dgozman@chromium.org>
Date: Mon Mar 28 16:22:31 2016

Mark http/tests/inspector/resource-tree/resource-tree-reload.html as flaky in debug.

BUG= 597572 
TBR=pfeldman
NOTRY=true

Review URL: https://codereview.chromium.org/1837763002

Cr-Commit-Position: refs/heads/master@{#383501}

[modify] https://crrev.com/d55cd51f1202e555ef2e9d43674bcaaf3f5eaefc/third_party/WebKit/LayoutTests/TestExpectations
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8c31351d42c9ed62418ac6fcab6acea74b094db

commit c8c31351d42c9ed62418ac6fcab6acea74b094db
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Sep 29 22:23:14 2016

Run update-test-expectations after making it less conservative.

The change http://crrev.com/2380173002 would make update-test-expectations delete lines as long as the test appears non-flaky on all configurations with existing builders, ignoring configurations with no existing builders.

This CL is the result of running that script -- so for any lines deleted here, that script has found that in recent runs for all existing matching continuous builders, the test appears non-flaky, i.e. passing all recent runs.

BUG=248938, 339597 , 352405 , 364250 , 381730 , 404597 , 410949 , 419696 , 473718 , 498539 , 518915 , 520169 , 520180 , 520183 ,520187, 520191 , 520612 , 520614 , 521084 ,521086, 521090 , 521093 , 521094 , 521099 , 521107 , 521855 , 522645 , 542541 , 552532 , 587593 , 587779 ,588103, 594595 , 594672 , 597572 , 613510 , 614197 , 622672 , 629711 

Review-Url: https://codereview.chromium.org/2384573002
Cr-Commit-Position: refs/heads/master@{#421954}

[modify] https://crrev.com/c8c31351d42c9ed62418ac6fcab6acea74b094db/third_party/WebKit/LayoutTests/TestExpectations

Comment 9 by dgozman@chromium.org, Dec 1 2016

Components: Platform>DevTools

Comment 10 by dgozman@chromium.org, Aug 15 2017

Owner: lushnikov@chromium.org

Comment 11 by lushnikov@chromium.org, Dec 14 2017

Status: Fixed (was: Assigned)
Seems to be fixed after the new test framework migration.
►

Sign in to add a comment