New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597569 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Buried. Ping if important.
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 400674



Sign in to add a comment

CREDENTIAL: Implement the 'PasswordCredential(HTMLFormElement)' constructor.

Project Member Reported by mkwst@chromium.org, Mar 24 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/506f83825ac36bbf9d95ca4fc5e7edb65dc54a51

commit 506f83825ac36bbf9d95ca4fc5e7edb65dc54a51
Author: mkwst <mkwst@chromium.org>
Date: Fri Apr 01 05:39:22 2016

CREDENTIAL: Implement the 'PasswordCredential(HTMLFormElement)' constructor.

After some discussion in https://github.com/w3c/webappsec-credential-management/issues/13,
we've added a new constructor to 'PasswordCredential' with the goal of
encouraging the usage of backwards-compatible autocomplete attributes.

Spec: https://w3c.github.io/webappsec-credential-management/#passwordcredential-form-constructor

BUG= 597569 

Review URL: https://codereview.chromium.org/1828213002

Cr-Commit-Position: refs/heads/master@{#384494}

[modify] https://crrev.com/506f83825ac36bbf9d95ca4fc5e7edb65dc54a51/third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html
[modify] https://crrev.com/506f83825ac36bbf9d95ca4fc5e7edb65dc54a51/third_party/WebKit/Source/core/html/FormAssociatedElement.h
[modify] https://crrev.com/506f83825ac36bbf9d95ca4fc5e7edb65dc54a51/third_party/WebKit/Source/modules/credentialmanager/Credential.h
[modify] https://crrev.com/506f83825ac36bbf9d95ca4fc5e7edb65dc54a51/third_party/WebKit/Source/modules/credentialmanager/FederatedCredential.h
[modify] https://crrev.com/506f83825ac36bbf9d95ca4fc5e7edb65dc54a51/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp
[modify] https://crrev.com/506f83825ac36bbf9d95ca4fc5e7edb65dc54a51/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.h
[modify] https://crrev.com/506f83825ac36bbf9d95ca4fc5e7edb65dc54a51/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.idl
[add] https://crrev.com/506f83825ac36bbf9d95ca4fc5e7edb65dc54a51/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp
[modify] https://crrev.com/506f83825ac36bbf9d95ca4fc5e7edb65dc54a51/third_party/WebKit/Source/modules/modules.gypi

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ba9227c85e36614c2d925f7e4ded01d0487cfd1

commit 6ba9227c85e36614c2d925f7e4ded01d0487cfd1
Author: mkwst <mkwst@chromium.org>
Date: Fri Apr 01 07:59:15 2016

CREDENTIAL: Teach the 'PasswordCredential(HTMLFormElement)' constructor about URLSearchParams

If the form's 'enctype' attribute is not explicitly 'multipart/form-data',
then generate a 'PasswordCredential' object that will be submitted with a
urlencoded body, just like the form itself would have been.

BUG= 597569 

Review URL: https://codereview.chromium.org/1828923003

Cr-Commit-Position: refs/heads/master@{#384514}

[modify] https://crrev.com/6ba9227c85e36614c2d925f7e4ded01d0487cfd1/third_party/WebKit/LayoutTests/http/tests/credentialmanager/passwordcredential-basics.html
[modify] https://crrev.com/6ba9227c85e36614c2d925f7e4ded01d0487cfd1/third_party/WebKit/Source/modules/credentialmanager/PasswordCredential.cpp
[modify] https://crrev.com/6ba9227c85e36614c2d925f7e4ded01d0487cfd1/third_party/WebKit/Source/modules/credentialmanager/PasswordCredentialTest.cpp

Comment 3 by mkwst@chromium.org, Apr 1 2016

Status: Fixed (was: Started)

Sign in to add a comment