New issue
Advanced search Search tips

Issue 597535 link

Starred by 7 users

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Disable touchscreen/touchpad shortcuts should apply per-user

Project Member Reported by pkasting@chromium.org, Mar 24 2016

Issue description

Chrome Version       : 50.0.2661.32
OS Version: 7978.18.0

On a Chromebook Pixel, go to about:flags, enable debug keyboard shortcuts, and use search-shift-t to disable the touchscreen.  (See  bug 484487  for the origin of this.)

Then sign out and sign in as a different user.  The touchscreen is still disabled.

Especially since the flag that allows the "re-enable touchscreen" shortcut to work is itself enabled per-user, the actual "disable touchscreen"/"disable touchpad" shortcuts should take effect per-user.  This will also allow these to be used by users of multi-user machines where not everyone wants the screen disabled.

->afakhry as you owned the previous bug before it was closed, but feel free to reassign as appropriate.
 
#CBC-RS/TC-watchlist
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2bc0da541c5601fbb3bb1bc7d93a0617827ca76

commit e2bc0da541c5601fbb3bb1bc7d93a0617827ca76
Author: afakhry <afakhry@chromium.org>
Date: Wed Nov 09 19:41:57 2016

Make the toggle touchscreen/touchpad shortcuts apply per-user

These are debug shortcuts behing a flag, if one user, who has the flag
enabled, disables the touchscreen, other signed-in users will be affected
too. It can be very confusing for users who have the debug shortcut flags
disabled.

This CL makes these settings apply per user.

BUG= 597535 
TEST=(1) Login with user_1, enabled ash-debug-shortcuts flag, Hit
Ctrl+Shift+T to disable touchscreen. Signout, signin, touchscreen
is still disabled.
(2) Signin with user_2, touchscreen is still enabled for user_2.
(3) Signin with user_1 and user_2 at the same time with multi-user
signin, switch between them using Ctrl+Alt+>, user_1 should have a
disabled touchscreen, user_2 has an enabled touchscreen.

Review-Url: https://codereview.chromium.org/2467023004
Cr-Commit-Position: refs/heads/master@{#431011}

[modify] https://crrev.com/e2bc0da541c5601fbb3bb1bc7d93a0617827ca76/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/e2bc0da541c5601fbb3bb1bc7d93a0617827ca76/chrome/browser/chromeos/preferences.cc
[modify] https://crrev.com/e2bc0da541c5601fbb3bb1bc7d93a0617827ca76/chrome/browser/chromeos/system/input_device_settings.cc
[modify] https://crrev.com/e2bc0da541c5601fbb3bb1bc7d93a0617827ca76/chrome/browser/chromeos/system/input_device_settings.h
[modify] https://crrev.com/e2bc0da541c5601fbb3bb1bc7d93a0617827ca76/chrome/browser/prefs/browser_prefs.cc

Status: Fixed (was: Started)

Comment 5 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 6 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 7 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Status: Verified (was: Fixed)
The shortcut to disable touchscreen is search+shift+T.

Sign in to add a comment