New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597533 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Allow various font weights in Chromium

Project Member Reported by m...@opera.com, Mar 24 2016

Issue description

Version: M51+
OS: Mac

platform_font_mac supports only two weights, gfx::Font::Weight::NORMAL and gfx::Font::Weight::BOLD. Should make it support other weights as well.



 

Comment 1 by m...@opera.com, Mar 25 2016

Cc: bunge...@chromium.org
Components: Internals>Skia Internals>Graphics
Summary: Allow various font weights in Chromium (was: Allow various font weights in PlatformFontMac)

Comment 2 by m...@opera.com, Mar 29 2016

These changes make Chromium's gfx::Font more closely match native font APIs & capabilities.

Labels: -Type-Bug -Arch-x86 -OS-Mac OS-All Type-Feature
Owner: m...@opera.com
Status: Started (was: Untriaged)
[mac triage]

Started in https://codereview.chromium.org/1819753003/
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/998e890d117912669e3d31ff21b465ee3684966c

commit 998e890d117912669e3d31ff21b465ee3684966c
Author: mboc <mboc@opera.com>
Date: Thu Jun 02 11:40:35 2016

Allow various font weights in gfx. These changes make Chromium's gfx::Font more closely match native font APIs &
capabilities.

BUG= 597533 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1819753003
Cr-Commit-Position: refs/heads/master@{#397368}

[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ash/system/tray/tray_utils.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/extensions/api/file_system/request_file_system_dialog_view.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/cocoa/omnibox/omnibox_popup_cell.mm
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/cocoa/omnibox/omnibox_popup_matrix.mm
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac_unittest.mm
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/extensions/icon_with_badge_image_source.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/libgtk2ui/gtk2_ui.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/libgtk2ui/gtk2_ui.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/views/accessibility/invert_bubble_view.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/views/autofill/password_generation_popup_view_views.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/views/desktop_capture/desktop_media_source_view.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/views/first_run_bubble.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/views/omnibox/omnibox_result_view.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/views/platform_keys_certificate_selector_chromeos.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/browser/ui/webui/chromeos/login/network_dropdown.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/chrome/renderer/pepper/pepper_flash_renderer_host.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/components/favicon/core/fallback_icon_service.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/content/browser/renderer_host/sandbox_ipc_linux.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/app_list/views/search_result_view.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/base/cocoa/menu_controller_unittest.mm
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/base/resource/resource_bundle.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/base/resource/resource_bundle.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/chromeos/ime/candidate_view.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/canvas_skia.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/font.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/font.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/font_list.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/font_list.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/font_list_impl.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/font_list_impl.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/font_list_unittest.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/font_render_params.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/font_render_params.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/font_render_params_linux.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/font_render_params_linux_unittest.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/font_unittest.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/linux_font_delegate.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/platform_font.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/platform_font_ios.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/platform_font_ios.mm
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/platform_font_linux.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/platform_font_linux.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/platform_font_linux_unittest.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/platform_font_mac.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/platform_font_mac.mm
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/platform_font_mac_unittest.mm
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/platform_font_win.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/platform_font_win.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/platform_font_win_unittest.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/render_text.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/render_text.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/render_text_harfbuzz.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/render_text_harfbuzz.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/render_text_mac.mm
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/render_text_unittest.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/gfx/text_constants.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/views/controls/button/label_button.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/views/controls/button/label_button_unittest.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/views/controls/styled_label.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/views/controls/styled_label.h
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/views/controls/styled_label_unittest.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/views/controls/tabbed_pane/tabbed_pane.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/views/examples/multiline_example.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/views/examples/text_example.cc
[modify] https://crrev.com/998e890d117912669e3d31ff21b465ee3684966c/ui/views/examples/textfield_example.cc

Comment 5 by enne@chromium.org, Jan 25 2017

Components: -Internals>Graphics Internals>Compositing
Status: Fixed (was: Started)
Sounds like this is fixed.

Sign in to add a comment