[Android WebVIew] sCachedWindowAndroid is incorrect |
|||||
Issue descriptionsCachedWindowAndroid assumes that the application context is wrapped in the exact same way. Simple fix is always create a new WindowAndroidWrapper for the application context as well instead of caching it
,
Mar 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1c68aa675d8d5586e2cda7df1ad56d5e4129e59 commit d1c68aa675d8d5586e2cda7df1ad56d5e4129e59 Author: boliu <boliu@chromium.org> Date: Fri Mar 25 23:38:57 2016 aw: Remove WindowAndroid caching Caching sCachedWindowAndroid is incorrect since it is possible for the one Application context to be wrapped differently. There is no point in caching ActivityWindowAndroid either due to the way ResourcesContextWrapperFactory works. So remove caching altogether and always create a new WindowAndroid instance. BUG= 597526 Review URL: https://codereview.chromium.org/1831373003 Cr-Commit-Position: refs/heads/master@{#383408} [modify] https://crrev.com/d1c68aa675d8d5586e2cda7df1ad56d5e4129e59/android_webview/java/src/org/chromium/android_webview/AwContents.java
,
Mar 26 2016
,
Mar 26 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Mar 26 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/030335581832763bf521dbe3e5cf7cd87b6d5f94 commit 030335581832763bf521dbe3e5cf7cd87b6d5f94 Author: Bo Liu <boliu@chromium.org> Date: Sat Mar 26 01:17:16 2016 [Merge M50] aw: Remove WindowAndroid caching Caching sCachedWindowAndroid is incorrect since it is possible for the one Application context to be wrapped differently. There is no point in caching ActivityWindowAndroid either due to the way ResourcesContextWrapperFactory works. So remove caching altogether and always create a new WindowAndroid instance. BUG= 597526 Review URL: https://codereview.chromium.org/1831373003 Cr-Commit-Position: refs/heads/master@{#383408} (cherry picked from commit d1c68aa675d8d5586e2cda7df1ad56d5e4129e59) Review URL: https://codereview.chromium.org/1835573005 . Cr-Commit-Position: refs/branch-heads/2661@{#396} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/030335581832763bf521dbe3e5cf7cd87b6d5f94/android_webview/java/src/org/chromium/android_webview/AwContents.java
,
Mar 26 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by boliu@chromium.org
, Mar 24 2016