New issue
Advanced search Search tips

Issue 597517 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 583549



Sign in to add a comment

A number of layout tests need 'meta charset=UTF-8' or UTF-8 BOM to be added.

Project Member Reported by js...@chromium.org, Mar 24 2016

Issue description

There are quite a number of layout tests taken from http://www.hixie.ch/tests/. 

The server (www.hixie.ch) emits 'Content-Type: text/html; charset=UTF-8', but actual html documents do not have 'charset meta' element.  

When layout tests are run without a http server, obviously there's no HTTP header to look at. 

As a result, all of them were interpreted as the default encoding (in case of Layout tests runner, it's windows-1252/iso-8859-1). So, all the expected results were wrong !

For instance, http://www.hixie.ch/tests/adhoc/css/box/inline/bidi/002.html
has a Hebrew character, but the current expected file has two Latin characters in its place. 


It's found while I was reviewing https://codereview.chromium.org/1721373002/.

The CL introduces a UTF-8-only detector when there's no charset declaration. And, it leads to a lot of rebaselined results (correct results).


I'll search for any non-ASCII files without meta charset declaration and add 'charset' to the document unless tests are specifically made to test the encoding determination mechanism. 



 

Comment 1 by js...@chromium.org, Mar 26 2016

Cc: dpranke@chromium.org kojii@chromium.org
Summary: A number of layout tests need 'meta charset=UTF-8' or UTF-8 BOM to be added. (was: A number of layout tests need 'meta charset=UTF-8' to be added. )
I found 67 (x)html files with this issue (no charset declaration in html meta or xml encoding. no UTF-8 BOM at the beginning, either). 

Fixing this issue will make some tests (that are marked as failure) pass. In other cases, bogus expected results that make tests appear to pass need to be changed (rebaseline should work for them). 

Most of them are supposed to be in UTF-8, but a small number of them are NOT supposed to be in UTF-8 (test authors wanted to test the behavior with non-UTF-8 input files), but Rietveld mangled non-UTF-8 input files when "converting" to UTF-8. 

An example of the latter is ./fast/text/international/iso-8859-8-and-isolate.html

Perhaps, a PSA (or developer document) is necessary to warn committers that non-UTF-8 text files cannot be landed via rietveld/CQ (they need to be landed manually). Or, we need to come up with a way to make that work for non-UTF-8 text files. 

A couple of tests are specifically designed to see the behavior in absence of charset declaration so that I'll leave them alone. 





Comment 2 by js...@chromium.org, Mar 26 2016

Forgot to upload the list. 
unlabelled_utf8_list.txt
3.8 KB View Download
Blocking: 583549
Cc: js...@chromium.org
Thanks for putting together the list to handle. Unless you already started, let me update the files by labeling them with the meta tag and have them rebaselined. This needs to be ready before  Issue 583549  is closed.
A noob question: Should we care about *-expected.html? Your list, for instance, has ./imported/csswg-test/css-writing-modes-3/table-progression-vrl-002-expected.html. I suppose it will be regenerated via TestExpectation when marked rebaselined, so what needs updating is ./imported/csswg-test/css-writing-modes-3/table-progression-vrl-002.htm instead.

Comment 5 by js...@chromium.org, Mar 31 2016

kojii@: what characters did you want to use in these files? 

./fast/text/international/iso-8859-8-and-isolate.html
./fast/text/international/iso-8859-8-and-isolate-expected.html

 15 <p>All lines must start with "â" and end with "ë".
 16 <ol>
 17   <li>â÷ë
 18   <li><span dir=ltr>â÷ë
 19   <li><span dir=rtl>â÷ë
 20   <li><span class=isolate>â÷ë
 21   <li><span class=isolate dir=ltr>â÷ë
 22   <li><span class=isolate dir=rtl>â÷ë

Did you mean to use U+05D2, U+05E7, U+05DB encoded in ISO-8859-8 (they are 0xE2 0xF7 0xEB when encoded in ISO-8859-8 [1]). Well, this particular test, I guess it does not really matter what characters are used as long as they're Hebrew letters (with strong RTL). I'll just go ahead and fix these files up. (the CL cannot go through a regular review process because rietveld will mess it up. I'll land manually after running this test locally). 



[1] https://en.wikipedia.org/wiki/ISO/IEC_8859-8

Comment 6 by js...@chromium.org, Mar 31 2016

Oops. jinsukkim@, I'm sorry I missed your comment and started adding meta/BOM. 

As for *expected.html files, they're for reference tests and I don't think they'll be regenerated as a part of rebaseline. In reference tests, the rendering result of a test html file should match that of the corresponding expected html file. 

BTW, we should leave alone this file. 

./fast/encoding/charset-utf16.html

It's coming from https://bugs.webkit.org/show_bug.cgi?id=5548. It's labelled utf-16 but is supposed to be in utf-8. (when  'byte-based' files have 'meta charset=utf-16', treat it as utf-8). 



Project Member

Comment 7 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbc9587ad7879f62f4841697f0c134ce80d0384d

commit cbc9587ad7879f62f4841697f0c134ce80d0384d
Author: Jungshik Shin <jshin@chromium.org>
Date: Thu Mar 31 18:41:33 2016

Fix the encoding of iso-8859-8-and-isolated*html files

These files are supposed to be in ISO-8859-8, but they're actually in
UTF-8.

./fast/text/international/iso-8859-8-and-isolate.html
./fast/text/international/iso-8859-8-and-isolate-expected.html

This CL will be landed manually because rietveld/CQ cannot handle
non-UTF-8 text files.

It's uploaded to rietveld for the record, but note that files are messed up
when viewed in rietveld.  The ground truth is what's actually in the tree
(landed manually).

Three characters in the test files are U+05D2, U+05E7, U+05DB encoded
in ISO-8859-8 (0xE2, 0xF7, 0xEB).

TBR=kojii@chromium.org
BUG= 597517 , 559257 

Review URL: https://codereview.chromium.org/1844413003 .

Cr-Commit-Position: refs/heads/master@{#384344}

[modify] https://crrev.com/cbc9587ad7879f62f4841697f0c134ce80d0384d/third_party/WebKit/LayoutTests/fast/text/international/iso-8859-8-and-isolate-expected.html
[modify] https://crrev.com/cbc9587ad7879f62f4841697f0c134ce80d0384d/third_party/WebKit/LayoutTests/fast/text/international/iso-8859-8-and-isolate.html

re: comment #4 by jinsukkim@chromium.org:
> A noob question: Should we care about *-expected.html? 
> Your list, for instance, has 
> ./imported/csswg-test/css-writing-modes-3/table-progression-vrl-002-expected.html. 
> I suppose it will be regenerated via TestExpectation when marked rebaselined, 
> so what needs updating is
> ./imported/csswg-test/css-writing-modes-3/table-progression-vrl-002.htm instead.

If the existing files cause problems after they are imported and we can fix them by 
inserting BOMs as needed during the import, it's probably reasonable to update the
importer to do that, but I would also be fine w/ skipping any problematic tests.

Either way, you are correct that ultimately the upstream tests need to be corrected.
> Oops. jinsukkim@, I'm sorry I missed your comment and started adding meta/BOM. 

No problem. Please go ahead and update them.

BTW, I noticed that one of the test files that needs updating is missing in your list: third_party/WebKit/LayoutTests/./css2.1/20110323/replaced-intrinsic-003.htm Please let it be included as well. Thanks.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b03c4cbfe2ae0a323ea5c4c5ce56d1e336f095cf

commit b03c4cbfe2ae0a323ea5c4c5ce56d1e336f095cf
Author: Jungshik Shin <jshin@chromium.org>
Date: Fri Apr 01 09:31:13 2016

Fix a munged Shift-JIS layout test file

fast/encoding/invalid-multi-byte-over-consumption.html is supposed to
have a sequence of '0x83 0x22' (an invalid sequence in Shift_JIS), but
it's somehow changed to '0xEF 0xBF 0xBD' (UTF-8 representation of
U+FFFD - replacement characters) followed by 0x22.

The whole point of this test is to make sure that only the first byte (0x83)
of a 'two-byte invalid sequence' is consumed and the second byte (0x22) is
interpreted as U+0022. So, having '0xEF 0xBF 0xBD' defeats the purpose of
this test.

Note that this file has to be landed manually because rietveld cannot
handle a non-UTF-8 text file.

BUG= 597517 
TEST=the above layout test.
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1850693005 .

Cr-Commit-Position: refs/heads/master@{#384531}

[modify] https://crrev.com/b03c4cbfe2ae0a323ea5c4c5ce56d1e336f095cf/third_party/WebKit/LayoutTests/fast/encoding/invalid-multi-byte-over-consumption.html

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d325555911b959dfce046cd13e03e4f754059f1a

commit d325555911b959dfce046cd13e03e4f754059f1a
Author: jshin <jshin@chromium.org>
Date: Sat Apr 02 09:20:09 2016

Add meta charset tag to unlabelled utf-8 files

There are 200+ UTF-8 files  without a charset=utf-8 specified.

They're are labelled with meta charset except for the following two
groups.

  * Some are intentionally unlabelled or mislabelled. They're left alone.
    (e.g. fast/encoding/charset-{utf16,unicode}.html )

  *  files in ietestcenter/, css2.1/20110323 and
     imported/web-platform-tests/IndexedDB  unless non-ASCII characters
     show up in actual contents (i.e. other than meta author, comments,
     etc).

In most cases, explicitly specifying charset=utf-8 do not affect the test
results because non-ASCII characters are in the reviewer's name (W3C
upstream) in "<meta reviewer>".

In other cases, tests are reference tests so that adding meta charset=utf-8
to both test and expected html files works without any further update.

For a few tests (non-reference test) whose results are affected,
expected.txt files are updated if it's text-only and platform-independent.

Finally, four tests are marked with 'NeedsRebaseline' because they
need platform-dependent pixel results.

BUG= 597517 
TEST=Layout tests

Review URL: https://codereview.chromium.org/1854503002

Cr-Commit-Position: refs/heads/master@{#384801}

[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/accessibility/element-role-mapping-normal-expected.txt
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/accessibility/element-role-mapping-normal.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/css2.1/20110323/floats-001-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/css2.1/20110323/floats-001.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/css2.1/20110323/floats-149-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/css2.1/20110323/floats-149.htm
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/css2.1/20110323/height-applies-to-010a-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/css2.1/20110323/replaced-intrinsic-003.htm
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/css2.1/20110323/word-spacing-characters-003-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/css2.1/20110323/word-spacing-characters-003.htm
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/editing/selection/extend-byline-withfloat.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/borders/bidi-002.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/borders/bidi-009a.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/css-generated-content/quotes-lang-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/css/abs-pos-child-inside-rel-pos-inline-001.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/css/abs-pos-child-inside-rel-pos-inline-offset-001.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/css/case-sensitive-003.xhtml
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/css/case-sensitive-004.xhtml
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/css/content-property-quote-types.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/css/heightless-list-item.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/events/event-on-culled-inline-with-pseudo.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/frames/sandboxed-iframe-attribute-parsing-03-expected.txt
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/frames/sandboxed-iframe-attribute-parsing-03.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/js/webidl-attribute-getter-setter-lengths.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/fast/parser/smart-quotes-in-tag.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/outline-inline-block-vrl-006-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/outline-inline-block-vrl-006.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/outline-inline-vlr-006-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/outline-inline-vlr-006.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/outline-inline-vrl-006-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/outline-inline-vrl-006.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-001-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-001.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-002-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-002.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-003-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-003.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vlr-004-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-001-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-001.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-002-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-002.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-003-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-003.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/csswg-test/css-writing-modes-3/table-progression-vrl-004-expected.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/web-platform-tests/IndexedDB/idbcursor-direction-index-keyrange.htm
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/web-platform-tests/IndexedDB/idbcursor-direction-objectstore-keyrange.htm
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/web-platform-tests/WebIDL/ecmascript-binding/es-exceptions/exceptions.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/imported/web-platform-tests/dom/nodes/Document-getElementsByTagName-xhtml.xhtml
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/inspector/tracing-model-storage.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/plugins/plugin-remove-subframe-expected.txt
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/plugins/plugin-remove-subframe.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/svg/custom/disallow-non-lengths-in-attrs.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/svg/text/select-text-svgfont.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/svg/text/text-layout-crash-expected.txt
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/svg/text/text-layout-crash.html
[modify] https://crrev.com/d325555911b959dfce046cd13e03e4f754059f1a/third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-supports.html

Status: Fixed (was: Assigned)
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d4cba24d2262f87b7a8e55fb9678c4017224dad

commit 7d4cba24d2262f87b7a8e55fb9678c4017224dad
Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org>
Date: Sat Apr 02 11:34:11 2016

Auto-rebaseline for r384801

https://chromium.googlesource.com/chromium/src/+/d32555591

BUG= 597517 
TBR=jshin@chromium.org

Review URL: https://codereview.chromium.org/1850183004 .

Cr-Commit-Position: refs/heads/master@{#384806}

[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/android/css2.1/20110323/replaced-intrinsic-003-expected.png
[add] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/android/css2.1/20110323/replaced-intrinsic-003-expected.txt
[add] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/android/fast/borders/bidi-009a-expected.png
[add] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/android/fast/borders/bidi-009a-expected.txt
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-003-expected.png
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/linux/css2.1/20110323/replaced-intrinsic-003-expected.txt
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/linux/fast/borders/bidi-002-expected.png
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/linux/fast/borders/bidi-002-expected.txt
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/linux/fast/borders/bidi-009a-expected.png
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/linux/fast/borders/bidi-009a-expected.txt
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/mac/css2.1/20110323/replaced-intrinsic-003-expected.png
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/mac/css2.1/20110323/replaced-intrinsic-003-expected.txt
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/mac/fast/borders/bidi-002-expected.png
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/mac/fast/borders/bidi-002-expected.txt
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/mac/fast/borders/bidi-009a-expected.png
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/mac/fast/borders/bidi-009a-expected.txt
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/win/css2.1/20110323/replaced-intrinsic-003-expected.png
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/win/css2.1/20110323/replaced-intrinsic-003-expected.txt
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/win/fast/borders/bidi-002-expected.png
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/win/fast/borders/bidi-002-expected.txt
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/win/fast/borders/bidi-009a-expected.png
[modify] https://crrev.com/7d4cba24d2262f87b7a8e55fb9678c4017224dad/third_party/WebKit/LayoutTests/platform/win/fast/borders/bidi-009a-expected.txt

Labels: Test-Layout

Sign in to add a comment