New issue
Advanced search Search tips

Issue 597514 link

Starred by 1 user
Status: Fixed
Owner:
xhw...@chromium.org
Closed: Mar 2016
Cc:
ddorwin@chromium.org
jrumm...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Missing return after rejecting the promise in MediaDrmBridge::CreateSessionAndGenerateRequest()

Project Member Reported by xhw...@chromium.org, Mar 24 2016 
In MediaDrmBridge::CreateSessionAndGenerateRequest(), after we reject the promise, we should return [1] . Today the "return" is missing. We end up continue to call Java which could try to resolve or reject the promise again.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/media/base/android/media_drm_bridge.cc&l=392
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/950d2d3ba6e0aee4bbae0c67eb6c77feaae55314

commit 950d2d3ba6e0aee4bbae0c67eb6c77feaae55314
Author: xhwang <xhwang@chromium.org>
Date: Thu Mar 24 18:57:06 2016

media : Return after rejecting promise in MediaDrmBridge

This fixes a bug where we continue to call Java after rejecting a
promise, which could trigger rejecting the same promise again.

BUG= 597514 
TEST=No double promise rejection in manual testing.

Review URL: https://codereview.chromium.org/1823413003

Cr-Commit-Position: refs/heads/master@{#383110}

[modify] https://crrev.com/950d2d3ba6e0aee4bbae0c67eb6c77feaae55314/media/base/android/media_drm_bridge.cc

Comment 2 by xhw...@chromium.org, Mar 24 2016

Labels: Merge-Request-50
Request merge of this one line fix.

Comment 3 by tin...@google.com, Mar 24 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 24 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50b099e47e84590ab95d880658ac6f2fee9b2a44

commit 50b099e47e84590ab95d880658ac6f2fee9b2a44
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Mar 24 20:37:44 2016

media : Return after rejecting promise in MediaDrmBridge

This fixes a bug where we continue to call Java after rejecting a
promise, which could trigger rejecting the same promise again.

BUG= 597514 
TEST=No double promise rejection in manual testing.

Review URL: https://codereview.chromium.org/1823413003

Cr-Commit-Position: refs/heads/master@{#383110}
(cherry picked from commit 950d2d3ba6e0aee4bbae0c67eb6c77feaae55314)

Review URL: https://codereview.chromium.org/1831103003 .

Cr-Commit-Position: refs/branch-heads/2661@{#381}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/50b099e47e84590ab95d880658ac6f2fee9b2a44/media/base/android/media_drm_bridge.cc

Comment 5 by xhw...@chromium.org, Mar 24 2016

Status: Fixed (was: Started)
►

Sign in to add a comment