New issue
Advanced search Search tips

Issue 597496 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

compile, diagnose_goma show summary as step text?

Project Member Reported by ukai@chromium.org, Mar 24 2016

Issue description

might be useful if compile, diagnose_goma step shows summary in step text (if failure?), like
gclient runhooks step in https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/44002
?

code would be
https://code.google.com/p/chromium/codesearch#chromium/build/scripts/slave/recipe_modules/ios/api.py&l=288-293

 
Might be possible to do like this?
https://chromium.googlesource.com/chromium/tools/build.git/+/master/scripts/slave/recipe_modules/ios/api.py#15

i.e.
1. make diagnose_goma to output JSON file that has summary of the step.
2. edit step result with the JSON output. 

What do you expect to be shown there?
I thought something like this:

diagnose_goma diagnose_goma 
goma: 29addd19aec04f3839bfcad8c853f858a3a91ff6
fatal: 1
error: 10
warnings: 200

Comment 3 by ukai@chromium.org, Mar 29 2016

I think we want to see summary about goma revision, version + why diagnose_goma reported failure. i.e. messages.

note that "SLOW Task:x time to start: d" is included in messages now, but it is usually too many. it would be better not to include messages but to show them at the end, but put just
"too many slow tasks to start: num, longest-duration-in-pending" or something in messages.
Labels: -Type-Bug Type-Feature
Messages sounds too much.

I prefer to show number of Fatal, Error, Warning in the second line, show non-repeated version of messages up to 3 lines (if more than 3, show ... in 4th line).

It is like:
goma: 29addd19aec04f3839bfcad8c853f858a3a91ff6
Fatal 1 > 0, error 30 > 10, warning 129 > 100
Too many slow tasks to start: 128, longest: 08.21 sec
Consumed too much memory: 3422429184 > 3221225472
Too much missing files: 1677 > 1024
...

What do you think?

Comment 6 by ukai@chromium.org, Mar 29 2016

ok.
messages is not so much different from this, except slow task lines.
actual fatal, errors, warnings are not in messages. 
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/goma/client/+/95564066b60b565c16b3558a125adbbcb7fdc81e

commit 95564066b60b565c16b3558a125adbbcb7fdc81e
Author: Yoshisato Yanagisawa <yyanagisawa@google.com>
Date: Thu Mar 24 09:47:20 2016

Comment 8 by benhenry@google.com, Apr 27 2016

Components: Infra>Goma
Labels: -Infra-Goma
This issue is blocked by https://codereview.chromium.org/2020603002/.
The implementation is already in https://codereview.chromium.org/1870953002/ but we cannot use this without the former one.

We are suggested to do this in internal buildbot, and obtaining internal bot might take long time.  Let me close both change list and comes back when internal bot get ready, or we changed our mind to implement the other things to do the similar thing we wanted with this issue.
Status: Available (was: Untriaged)

Comment 11 by ukai@chromium.org, Nov 25 2016

Status: WontFix (was: Available)
we run diagnose_goma_log_server to run diagnose goma log, so no need to do this.

Sign in to add a comment