Determine if a layer is inside replica without walking up the layer tree. |
||
Issue descriptionTo determine if a layer is inside replica we walk up the layer tree (jumping from target to target) and see if any of the targets has a replica. Possible solutions : 1) Walk up the effect tree instead. 2) cache inside_replica on effect_tree. 1) has the issue that we will end up doing more work than before (num effect nodes > num targets). This computation happens in LayerTreeImpl::UpdateDrawProperties
,
Mar 24 2016
Another possibility is to add a "is_replica"/"has_replica" on layers, so this relationship is no longer hierarchical.
,
Mar 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af65b7cd9a963e81503ad84d795e0ab89c8427a3 commit af65b7cd9a963e81503ad84d795e0ab89c8427a3 Author: jaydasika <jaydasika@chromium.org> Date: Tue Mar 29 17:05:52 2016 cc : Use effect tree to determine if a layer is inside replica This CL also addes target_id to effect tree. BUG= 597477 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review URL: https://codereview.chromium.org/1832233002 Cr-Commit-Position: refs/heads/master@{#383748} [modify] https://crrev.com/af65b7cd9a963e81503ad84d795e0ab89c8427a3/cc/layers/layer_impl.cc [modify] https://crrev.com/af65b7cd9a963e81503ad84d795e0ab89c8427a3/cc/layers/layer_impl.h [modify] https://crrev.com/af65b7cd9a963e81503ad84d795e0ab89c8427a3/cc/proto/property_tree.proto [modify] https://crrev.com/af65b7cd9a963e81503ad84d795e0ab89c8427a3/cc/trees/layer_tree_impl.cc [modify] https://crrev.com/af65b7cd9a963e81503ad84d795e0ab89c8427a3/cc/trees/property_tree.cc [modify] https://crrev.com/af65b7cd9a963e81503ad84d795e0ab89c8427a3/cc/trees/property_tree.h [modify] https://crrev.com/af65b7cd9a963e81503ad84d795e0ab89c8427a3/cc/trees/property_tree_builder.cc
,
Mar 29 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by jaydasika@chromium.org
, Mar 24 2016Status: Started (was: Available)