New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597467 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 595545
issue 596211
issue 598408
issue 612909
issue 622826
issue 629265



Sign in to add a comment

Re-enable the unified media pipeline for JB

Project Member Reported by w...@chromium.org, Mar 24 2016

Issue description

This is a tracking bug for issues blocking the use of the unified media pipeline on JB

 

Comment 1 by w...@chromium.org, Mar 28 2016

Blockedon: 598408

Comment 2 by w...@chromium.org, Mar 28 2016

Cc: liber...@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc080ed13685df21f03c28c01008d5461cdbcf85

commit fc080ed13685df21f03c28c01008d5461cdbcf85
Author: watk <watk@chromium.org>
Date: Mon Mar 28 23:41:38 2016

media: Disable the unified media pipeline for API levels 16 & 17

AVDA still has bugs on these older platform versions so this CL disables
the unified media pipeline trial on them.

BUG= 597467 

Review URL: https://codereview.chromium.org/1825913003

Cr-Commit-Position: refs/heads/master@{#383608}

[modify] https://crrev.com/fc080ed13685df21f03c28c01008d5461cdbcf85/media/base/media.cc

Comment 4 by w...@chromium.org, Mar 28 2016

Labels: Merge-Request-50
Sorry for making this confusing by linking the CL to this bug. We want to merge the change to disable the trial back to M50.

Comment 5 by gov...@chromium.org, Mar 29 2016

Is this change applicable to All OS or any specific OS?

Comment 6 by w...@chromium.org, Mar 29 2016

Labels: OS-Android
Android only sorry. Jellybean devices.

Comment 7 by tin...@google.com, Mar 29 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Owner: w...@chromium.org
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 29 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f308479b31c992d57cf21d1ef1b6032d53c97f47

commit f308479b31c992d57cf21d1ef1b6032d53c97f47
Author: Chris Watkins <watk@chromium.org>
Date: Tue Mar 29 01:27:34 2016

media: Disable the unified media pipeline for API levels 16 & 17

AVDA still has bugs on these older platform versions so this CL disables
the unified media pipeline trial on them.

BUG= 597467 

Review URL: https://codereview.chromium.org/1825913003

Cr-Commit-Position: refs/heads/master@{#383608}
(cherry picked from commit fc080ed13685df21f03c28c01008d5461cdbcf85)

Review URL: https://codereview.chromium.org/1838033002 .

Cr-Commit-Position: refs/branch-heads/2661@{#414}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/f308479b31c992d57cf21d1ef1b6032d53c97f47/media/base/media.cc

Cc: mlamouri@chromium.org
Most of the blocked issues are fixed or will be soon right? We should be able to enable this for M-52?

Comment 11 by w...@chromium.org, May 16 2016

Yep, I'll sort this out today
Project Member

Comment 12 by bugdroid1@chromium.org, May 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1580687683f0814bfb8a6238b9b9243fff335ef9

commit 1580687683f0814bfb8a6238b9b9243fff335ef9
Author: watk <watk@chromium.org>
Date: Mon May 23 19:25:11 2016

Re-enable the unified media pipeline for JellyBean

The blocking bugs are fixed so we can turn it back on.

BUG= 597467 

Review-Url: https://codereview.chromium.org/1997483002
Cr-Commit-Position: refs/heads/master@{#395385}

[modify] https://crrev.com/1580687683f0814bfb8a6238b9b9243fff335ef9/media/base/media.cc

Comment 13 by w...@chromium.org, May 23 2016

Status: Fixed (was: Available)

Comment 14 by w...@chromium.org, Jul 11 2016

Cc: amineer@chromium.org
Labels: -Hotlist-Merge-Approved -M-51 -merge-merged-2661 Merge-Request-52
I somehow missed that this was after the M52 branch cut. Requesting Merge to 52.


Comment 15 by w...@chromium.org, Jul 11 2016

Status: Started (was: Fixed)

Comment 16 by dimu@google.com, Jul 11 2016

Labels: -Merge-Request-52 Merge-Approved-52 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M52 (branch: 2743)
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 11 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6e72427d55908dc1f44683bfe6c79847854abf40

commit 6e72427d55908dc1f44683bfe6c79847854abf40
Author: Chris Watkins <watk@chromium.org>
Date: Mon Jul 11 21:13:23 2016

Re-enable the unified media pipeline for JellyBean

The blocking bugs are fixed so we can turn it back on.

BUG= 597467 

Review-Url: https://codereview.chromium.org/1997483002
Cr-Commit-Position: refs/heads/master@{#395385}
(cherry picked from commit 1580687683f0814bfb8a6238b9b9243fff335ef9)

Review URL: https://codereview.chromium.org/2138233002 .

Cr-Commit-Position: refs/branch-heads/2743@{#610}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/6e72427d55908dc1f44683bfe6c79847854abf40/media/base/media.cc

Comment 18 by w...@chromium.org, Jul 14 2016

Labels: -Hotlist-Merge-Approved -merge-merged-2743 Merge-Request-52 M-52
Requesting merge to revert 6e72427d55908dc1f44683bfe6c79847854abf40 in #17.

We need to disable JB again for M52 because of  Issue 612909 .

Comment 19 by dimu@google.com, Jul 14 2016

Labels: -Merge-Request-52 Merge-Review-52 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M52, manual review required.
Labels: -Merge-Review-52 Merge-Approved-52
Merge approved for M52 branch 2743.
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 14 2016

Labels: -merge-approved-52 merge-merged-2743
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0068affc7eb3c0e11dcb6a52108bcfe3e0723e99

commit 0068affc7eb3c0e11dcb6a52108bcfe3e0723e99
Author: Chris Watkins <watk@chromium.org>
Date: Thu Jul 14 21:30:33 2016

Revert "Re-enable the unified media pipeline for JellyBean"

This reverts commit 6e72427d55908dc1f44683bfe6c79847854abf40.

Re-disabling unified media pipeline due to crashes.

TBR=liberato
BUG= 597467 , 612909 

Review URL: https://codereview.chromium.org/2144733010 .

Cr-Commit-Position: refs/branch-heads/2743@{#632}
Cr-Branched-From: 2b3ae3b8090361f8af5a611712fc1a5ab2de53cb-refs/heads/master@{#394939}

[modify] https://crrev.com/0068affc7eb3c0e11dcb6a52108bcfe3e0723e99/media/base/media.cc

Comment 22 by w...@chromium.org, Jul 14 2016

Labels: -merge-merged-2743 Merge-Request-53
I'll land the revert on 53 too until we figure out a solution.

Comment 23 by dimu@google.com, Jul 14 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Project Member

Comment 24 by bugdroid1@chromium.org, Jul 14 2016

Labels: -merge-approved-53 merge-merged-2785
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4467b42153c1fbec6e3dcfe30727e6ef2e2e615f

commit 4467b42153c1fbec6e3dcfe30727e6ef2e2e615f
Author: Chris Watkins <watk@chromium.org>
Date: Thu Jul 14 22:05:22 2016

Revert "Re-enable the unified media pipeline for JellyBean"

This reverts commit 1580687683f0814bfb8a6238b9b9243fff335ef9.

Disabling the unified media pipeline on JB until crashes are solved.

TBR=liberato
BUG= 612909 , 597467 

Review URL: https://codereview.chromium.org/2153623002 .

Cr-Commit-Position: refs/branch-heads/2785@{#127}
Cr-Branched-From: 68623971be0cfc492a2cb0427d7f478e7b214c24-refs/heads/master@{#403382}

[modify] https://crrev.com/4467b42153c1fbec6e3dcfe30727e6ef2e2e615f/media/base/media.cc

Project Member

Comment 25 by bugdroid1@chromium.org, Aug 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e6c19220c6cc99725dd3997d9c18c482b95f7de

commit 3e6c19220c6cc99725dd3997d9c18c482b95f7de
Author: watk <watk@chromium.org>
Date: Mon Aug 08 20:15:01 2016

Revert "Re-enable the unified media pipeline for JellyBean"

This reverts commit 1580687683f0814bfb8a6238b9b9243fff335ef9.

We've encountered more JB specific issues, so this CL blacklists
JB again.

BUG= 597467 

Review-Url: https://codereview.chromium.org/2218203002
Cr-Commit-Position: refs/heads/master@{#410421}

[modify] https://crrev.com/3e6c19220c6cc99725dd3997d9c18c482b95f7de/media/base/media.cc

Project Member

Comment 26 by bugdroid1@chromium.org, Sep 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd027dcc981b471f916593b92d615b2c06595d78

commit dd027dcc981b471f916593b92d615b2c06595d78
Author: dalecurtis <dalecurtis@chromium.org>
Date: Wed Sep 21 18:20:13 2016

Remove field trial and enable JellyBean for Spitzer!

All known issues should be fixed.

BUG= 597467 ,  612909 
TEST=jb devices no longer crash while scrolling.

Review-Url: https://codereview.chromium.org/2349763003
Cr-Commit-Position: refs/heads/master@{#420108}

[modify] https://crrev.com/dd027dcc981b471f916593b92d615b2c06595d78/media/base/media.cc

Labels: -M-52 M-55
Status: Fixed (was: Started)

Sign in to add a comment