New issue
Advanced search Search tips

Issue 597458 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Offline page not replacing with online when using forward/back stack

Project Member Reported by petewil@chromium.org, Mar 24 2016

Issue description

When the user has an offline page on the nav stack, but is online, if we navigate the stack backwards (back button), and try to replace the offline version of the page with an online version, it is instead putting the new navigation at the forward end of the stack, which puts the navigation into an infinite loop as the user presses back (the user sees the same pages again and again as they press back, never going back to the rest of the pages.) 

To "fix" this, we turned off the Offline->Online reloading feature if the navigation stack is navigating backwards (actually, any time the nav position is not at the very front of the stack).  However, this isn't the best fix, it would be better to fix the problem so that we can re-enable the feature.

This may mean modifications to how the should_replace_current_entry field works in relation to the back stack.
 
Labels: -Pri-3 Pri-2
Status: Assigned (was: Untriaged)
Owner: jianli@chromium.org
This should be fixed when JianLi checks in the URLRequestInterceptor change.

Comment 3 by jianli@chromium.org, Aug 26 2016

Status: Fixed (was: Assigned)
This has been fixed after we switched to serving offline content directly under online URL as in patch https://codereview.chromium.org/2245733004/.

Sign in to add a comment