The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc

commit b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc
Author: marcinjb <marcinjb@chromium.org>
Date: Thu Mar 24 22:20:27 2016

Initial addition of Blimp engine crash client code.

This introduces a simple crash client for the engine, which includes a client that will always allow and always upload crash reports with the "Chrome_Blimp_Engine" name.  Crash reporting is enabled for all processes.

BUG= 597454 

Review URL: https://codereview.chromium.org/1783053002

Cr-Commit-Position: refs/heads/master@{#383161}

[modify] https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc/blimp/engine/BUILD.gn
[modify] https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc/blimp/engine/DEPS
[modify] https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc/blimp/engine/Dockerfile
[modify] https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc/blimp/engine/app/blimp_content_main_delegate.cc
[add] https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc/blimp/engine/app/blimp_engine_crash_keys.cc
[add] https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc/blimp/engine/app/blimp_engine_crash_keys.h
[add] https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc/blimp/engine/app/blimp_engine_crash_reporter_client.cc
[add] https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc/blimp/engine/app/blimp_engine_crash_reporter_client.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6781323221029e2f5c0ca1b0f055b81bb2d69153

commit 6781323221029e2f5c0ca1b0f055b81bb2d69153
Author: haibinlu <haibinlu@chromium.org>
Date: Thu Mar 24 23:49:42 2016

Revert of Initial addition of blimp crash client code. (patchset #5 id:80001 of https://codereview.chromium.org/1783053002/ )

Reason for revert:
Engine crashes. https://bugs.chromium.org/p/chromium/issues/detail?id=597838

Original issue's description:
> Initial addition of Blimp engine crash client code.
>
> This introduces a simple crash client for the engine, which includes a client that will always allow and always upload crash reports with the "Chrome_Blimp_Engine" name.  Crash reporting is enabled for all processes.
>
> BUG= 597454 
>
> Committed: https://crrev.com/b7efce03ce6c4a2c17db1ca6cbd73637544cb0dc
> Cr-Commit-Position: refs/heads/master@{#383161}

TBR=kmarshall@chromium.org,mark@chromium.org,marcinjb@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 597454 

Review URL: https://codereview.chromium.org/1830393002

Cr-Commit-Position: refs/heads/master@{#383193}

[modify] https://crrev.com/6781323221029e2f5c0ca1b0f055b81bb2d69153/blimp/engine/BUILD.gn
[modify] https://crrev.com/6781323221029e2f5c0ca1b0f055b81bb2d69153/blimp/engine/DEPS
[modify] https://crrev.com/6781323221029e2f5c0ca1b0f055b81bb2d69153/blimp/engine/Dockerfile
[modify] https://crrev.com/6781323221029e2f5c0ca1b0f055b81bb2d69153/blimp/engine/app/blimp_content_main_delegate.cc
[delete] https://crrev.com/4702f9e6ec4a55dd0ada0451395792a9dcd46af0/blimp/engine/app/blimp_engine_crash_keys.cc
[delete] https://crrev.com/4702f9e6ec4a55dd0ada0451395792a9dcd46af0/blimp/engine/app/blimp_engine_crash_keys.h
[delete] https://crrev.com/4702f9e6ec4a55dd0ada0451395792a9dcd46af0/blimp/engine/app/blimp_engine_crash_reporter_client.cc
[delete] https://crrev.com/4702f9e6ec4a55dd0ada0451395792a9dcd46af0/blimp/engine/app/blimp_engine_crash_reporter_client.h

Looks like having unregistered crash keys can cause the browser to crash. I'm going to try to clean up crash key registration chrome-wide ( http://crbug.com/598854 ) and then try the original patchset again.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ffc513054fd32c30c67c4e6d6798c2f198974aec

commit ffc513054fd32c30c67c4e6d6798c2f198974aec
Author: marcinjb <marcinjb@chromium.org>
Date: Wed May 04 18:35:27 2016

Initial addition of Blimp engine crash client code (take 2)

This introduces a simple crash client for the engine, which includes a client
that will always allow and always upload crash reports with the
"Chrome_Blimp_Engine" name. Crash reporting is enabled for all processes.
wget is added to the Docker container as it's necessary for crash uploads.

This is based on http://crrev.com/1783053002, with the addition of
missing //content crash keys (without which you'd check-fail), and a
note to people who modify the list in //chrome/common/crash_keys.cc
to also kindly update our list if they're changing things. This should
get better when  http://crbug.com/598854  is resolved.

BUG= 597454 

Review-Url: https://codereview.chromium.org/1925993004
Cr-Commit-Position: refs/heads/master@{#391577}

[modify] https://crrev.com/ffc513054fd32c30c67c4e6d6798c2f198974aec/blimp/engine/BUILD.gn
[modify] https://crrev.com/ffc513054fd32c30c67c4e6d6798c2f198974aec/blimp/engine/DEPS
[modify] https://crrev.com/ffc513054fd32c30c67c4e6d6798c2f198974aec/blimp/engine/Dockerfile
[modify] https://crrev.com/ffc513054fd32c30c67c4e6d6798c2f198974aec/blimp/engine/app/blimp_content_main_delegate.cc
[add] https://crrev.com/ffc513054fd32c30c67c4e6d6798c2f198974aec/blimp/engine/app/blimp_engine_crash_keys.cc
[add] https://crrev.com/ffc513054fd32c30c67c4e6d6798c2f198974aec/blimp/engine/app/blimp_engine_crash_keys.h
[add] https://crrev.com/ffc513054fd32c30c67c4e6d6798c2f198974aec/blimp/engine/app/blimp_engine_crash_reporter_client.cc
[add] https://crrev.com/ffc513054fd32c30c67c4e6d6798c2f198974aec/blimp/engine/app/blimp_engine_crash_reporter_client.h
[modify] https://crrev.com/ffc513054fd32c30c67c4e6d6798c2f198974aec/chrome/common/crash_keys.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/060ef497fef78501475548ec61dbc8c290f02a9b

commit 060ef497fef78501475548ec61dbc8c290f02a9b
Author: marcinjb <marcinjb@chromium.org>
Date: Tue May 17 19:37:34 2016

Add an action to create a symbol file for the Blimp engine

This is modeled after what is done for the official Chrome linux build.
As it stands right now, the breakpad symbol file is roughly 300MB and
takes a couple of minutes to run, so the action should only be triggered
if this is an official release.

BUG= 597454 

Review-Url: https://codereview.chromium.org/1979773002
Cr-Commit-Position: refs/heads/master@{#394191}

[modify] https://crrev.com/060ef497fef78501475548ec61dbc8c290f02a9b/blimp/BUILD.gn
[modify] https://crrev.com/060ef497fef78501475548ec61dbc8c290f02a9b/blimp/engine/BUILD.gn
[modify] https://crrev.com/060ef497fef78501475548ec61dbc8c290f02a9b/build/args/bots/official.desktop/blimp-engine.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/16c59ef7e109644e671f0e3d782b9df64eaee552

commit 16c59ef7e109644e671f0e3d782b9df64eaee552
Author: marcinjb <marcinjb@chromium.org>
Date: Wed May 18 18:58:35 2016

Add a compile time flag to only upload crash symbols for official builds

BUG= 597454 

Review-Url: https://codereview.chromium.org/1990723002
Cr-Commit-Position: refs/heads/master@{#394486}

[modify] https://crrev.com/16c59ef7e109644e671f0e3d782b9df64eaee552/blimp/engine/app/blimp_engine_crash_reporter_client.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5364fc6bd081393a667b7aef5ff6766b3b115af1

commit 5364fc6bd081393a667b7aef5ff6766b3b115af1
Author: marcinjb <marcinjb@chromium.org>
Date: Wed May 18 22:53:24 2016

Include symupload in official Blimp engine builds

This is needed in official builds as the symupload binary is needed to
upload crash symbol files to the crash server, but is not included on
the buildbots for reasons.

BUG= 597454 

Review-Url: https://codereview.chromium.org/1987393002
Cr-Commit-Position: refs/heads/master@{#394580}

[modify] https://crrev.com/5364fc6bd081393a667b7aef5ff6766b3b115af1/blimp/engine/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e125170b9b18d3e47e59834f257e8cd458ea8c26

commit e125170b9b18d3e47e59834f257e8cd458ea8c26
Author: Alex Mineer <amineer@chromium.org>
Date: Wed May 18 23:06:43 2016

Include symupload in official Blimp engine builds

This is needed in official builds as the symupload binary is needed to
upload crash symbol files to the crash server, but is not included on
the buildbots for reasons.

BUG= 597454 

(cherry picked from commit 5364fc6bd081393a667b7aef5ff6766b3b115af1)

Review-Url: https://codereview.chromium.org/1987393002
Cr-Original-Commit-Position: refs/heads/master@{#394580}
Cr-Commit-Position: refs/branch-heads/2740@{#2}
Cr-Branched-From: 60dd666a273eb84d361f0fd5de11d770881b46bc-refs/heads/master@{#394284}

[modify] https://crrev.com/e125170b9b18d3e47e59834f257e8cd458ea8c26/blimp/engine/BUILD.gn

Calling this done for now.  While some crash key cleanup may still need to be done for the Chromium codebase at large, production builds of the engine will (successfully) upload crash symbols, and we get meaningful data now.