New issue
Advanced search Search tips

Issue 597446 link

Starred by 1 user
Status: Duplicate
Merged: issue 680616
Owner:
briannorris@chromium.org
Closed: Feb 2017
Cc:
vapier@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Upgrade glib to 2.4x

Project Member Reported by briannorris@chromium.org, Mar 23 2016 
OS: Chrome

Some packages rely (implicitly or explicitly) on newer versions of glib. Ours is several years old, so it's probably time to update it.

This is related to work on issue 588234, where we might utilize cups-browsed.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/modemmanager-next/+/73f3de643f78c6644b8577b2690f312d5379a195

commit 73f3de643f78c6644b8577b2690f312d5379a195
Author: Brian Norris <briannorris@chromium.org>
Date: Thu Mar 24 16:27:55 2016

libmm-glib: fix enum conversion warning/error

mm-modem-oma.c:400:51: error: implicit conversion from enumeration type 'MMOmaSessionType' to different enumeration type 'MMOmaFeature'
      [-Werror,-Wenum-conversion]
    g_return_val_if_fail (MM_IS_MODEM_OMA (self), MM_OMA_SESSION_TYPE_UNKNOWN);
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/build/oak/usr/include/glib-2.0/glib/gmessages.h:382:11: note: expanded from macro 'g_return_val_if_fail'
         return (val);                                                  \
         ~~~~~~  ^~~

This should be MMOmaFeature, not MMOmaSessionType. The end result is the same,
as both are 0.

BUG= chromium:597446 
TEST=`emerge-oak modemmanager-next` (with and without upgraded glib)

Change-Id: I9d46bd9d5ee34cfb0b2ccece4d7526179110e9ec
Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/334730
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/73f3de643f78c6644b8577b2690f312d5379a195/libmm-glib/mm-modem-oma.c

Comment 2 by briannorris@chromium.org, Feb 2 2017

Mergedinto: 680616
Status: Duplicate (was: Untriaged)
►

Sign in to add a comment