TPM verify failures are mis-reported
Reported by
jrbarnette@chromium.org,
Mar 23 2016
|
|||
Issue description
A recent repair job failed; logs are here:
https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/hosts/chromeos2-row4-rack6-host3/52705964-repair/
The status.log file is attached. It includes a failure with
this message:
'module' object has no attribute 'AutotestHostVerifyError'
The message comes from lines like these in TPMStatusVerifier:
tpm = status['tpm']
if not tpm['enabled']:
raise hosts.AutotestHostVerifyError(
'TPM is not enabled -- Hardware is not working.')
The name "AutotestHostVerifyError" is now obsolete; it's been renamed
to "AutoservVerifyError".
The result is real TPM errors are all reported with this message; we
need to fix to to be able to see easily what the problem is.
,
Mar 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/ae17f0c610b0657e0819b9c851c2578673f489f7 commit ae17f0c610b0657e0819b9c851c2578673f489f7 Author: xixuan <xixuan@google.com> Date: Thu Mar 24 00:30:14 2016 Autotest: Fix the TPM verifier's error. This CL 1) renames the exceptions to be raised when TPM Verifiers fail due to the 'Verify error renaming' of CL:333661. 2) make it trigger repair 'Powerwash'. BUG= chromium:597444 TEST=Ran verification for a DUT in lab using a local autotest with different settings of tpm json values, and command `stop tcsd`. Make sure it triggers 'Powerwash' when failed. Change-Id: I03c5e3345617a0e3aa2c95d80627f773d9aa1f35 Reviewed-on: https://chromium-review.googlesource.com/334437 Commit-Ready: Xixuan Wu <xixuan@chromium.org> Tested-by: Xixuan Wu <xixuan@chromium.org> Reviewed-by: Richard Barnette <jrbarnette@chromium.org> Reviewed-by: Xixuan Wu <xixuan@chromium.org> [modify] https://crrev.com/ae17f0c610b0657e0819b9c851c2578673f489f7/server/hosts/cros_repair.py
,
Mar 26 2016
Sample success in a repair job:
START ---- repair timestamp=1458947802 localtime=Mar 25 16:16:42
GOOD ---- verify.ssh timestamp=1458947819 localtime=Mar 25 16:16:59
GOOD ---- verify.power timestamp=1458947819 localtime=Mar 25 16:16:59
GOOD ---- verify.cros timestamp=1458947821 localtime=Mar 25 16:17:01
GOOD ---- verify.good_au timestamp=1458947821 localtime=Mar 25 16:17:01
FAIL ---- verify.tpm timestamp=1458947822 localtime=Mar 25 16:17:02 Cannot load the TPM SRC public key
START ---- repair.powerwash timestamp=1458947822 localtime=Mar 25 16:17:02
START ---- reboot timestamp=1458947822 localtime=Mar 25 16:17:02
GOOD ---- reboot.start timestamp=1458947822 localtime=Mar 25 16:17:02
GOOD ---- reboot.verify timestamp=1458947857 localtime=Mar 25 16:17:37
END GOOD ---- reboot kernel=3.14.0 localtime=Mar 25 16:17:37 timestamp=1458947857
START ---- reboot timestamp=1458947867 localtime=Mar 25 16:17:47
GOOD ---- reboot.start timestamp=1458947867 localtime=Mar 25 16:17:47
GOOD ---- reboot.verify timestamp=1458947885 localtime=Mar 25 16:18:05
END GOOD ---- reboot kernel=3.14.0 localtime=Mar 25 16:18:05 timestamp=1458947885
START ---- reboot timestamp=1458948065 localtime=Mar 25 16:21:05
GOOD ---- reboot.start timestamp=1458948065 localtime=Mar 25 16:21:05
GOOD ---- reboot.verify timestamp=1458948099 localtime=Mar 25 16:21:39
END GOOD ---- reboot kernel=3.14.0 localtime=Mar 25 16:21:40 timestamp=1458948100
GOOD ---- verify.ssh timestamp=1458948131 localtime=Mar 25 16:22:11
GOOD ---- verify.tpm timestamp=1458948131 localtime=Mar 25 16:22:11
GOOD ---- verify.good_au timestamp=1458948131 localtime=Mar 25 16:22:11
GOOD ---- verify.cros timestamp=1458948134 localtime=Mar 25 16:22:14
END GOOD ---- repair.powerwash timestamp=1458948134 localtime=Mar 25 16:22:14
GOOD ---- verify.PASS timestamp=1458948134 localtime=Mar 25 16:22:14
START ---- reboot timestamp=1458948134 localtime=Mar 25 16:22:14
GOOD ---- reboot.start timestamp=1458948134 localtime=Mar 25 16:22:14
GOOD ---- reboot.verify timestamp=1458948153 localtime=Mar 25 16:22:33
END GOOD ---- reboot kernel=3.14.0 localtime=Mar 25 16:22:34 timestamp=1458948154
END GOOD ---- repair timestamp=1458948154 localtime=Mar 25 16:22:34 {'host_attributes': {'job_repo_url': 'http://100.107.160.1:8082/static/samus-release/R50-7978.18.0/autotest/packages', 'powerunit_hostname': 'chromeos2-row1-rack5-rpm1', 'hydra_hostname': 'chromeos-197-hydra1.cros', 'powerunit_outlet': '.A9'}, 'hostname': 'chromeos2-row1-rack5-host4'} repaired successfully
,
Apr 27 2016
|
|||
►
Sign in to add a comment |
|||
Comment 1 by jrbarnette@chromium.org
, Mar 24 2016