New issue
Advanced search Search tips

Issue 597432 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Implement Biquad lowpass and highpass filters according to spec.

Project Member Reported by rtoy@chromium.org, Mar 23 2016

Issue description

The current WebAudio spec for lowpass and highpass filters is incorrect.

See WebAudio issue https://github.com/WebAudio/web-audio-api/issues/771

 

Comment 1 by rtoy@chromium.org, Apr 19 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)
Resolved in https://github.com/WebAudio/web-audio-api/pull/795.
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10494397a89162ce998d4ab18761a530d690d67c

commit 10494397a89162ce998d4ab18761a530d690d67c
Author: rtoy <rtoy@chromium.org>
Date: Mon Jun 13 20:11:55 2016

Implement Biquad lowpass and highpass filters according to spec

The WebAudio spec has changed the definition of the lowpass and
highpass filters slightly because some lowpass and highpass filters
could not be represented by the existing filters.  Update
implementation to match spec.

This will cause some very slight difference in sound quality for some
values of Q.  The new filters were careful to preserve the sound as
much as possible.

WebAudio issue https://github.com/WebAudio/web-audio-api/issues/771.
Resolution: https://github.com/WebAudio/web-audio-api/pull/795
Feature: https://www.chromestatus.com/features/5687523284090880

BUG= 597432 
TEST=biquad-*.html, iirfilter-getFrequencyResponse.thml, iirfilter.html

Review-Url: https://codereview.chromium.org/1885723003
Cr-Commit-Position: refs/heads/master@{#399519}

[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-allpass.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-bandpass.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-highpass.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-highshelf.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-lowpass.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-lowshelf.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-notch.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-peaking.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-tail-expected.txt
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-tail.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/iirfilter-expected.txt
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/iirfilter-getFrequencyResponse-expected.txt
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/iirfilter.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/resources/biquad-filters.js
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/resources/biquad-testing.js
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/Source/platform/audio/Biquad.cpp

Project Member

Comment 3 by bugdroid1@chromium.org, Jun 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/10494397a89162ce998d4ab18761a530d690d67c

commit 10494397a89162ce998d4ab18761a530d690d67c
Author: rtoy <rtoy@chromium.org>
Date: Mon Jun 13 20:11:55 2016

Implement Biquad lowpass and highpass filters according to spec

The WebAudio spec has changed the definition of the lowpass and
highpass filters slightly because some lowpass and highpass filters
could not be represented by the existing filters.  Update
implementation to match spec.

This will cause some very slight difference in sound quality for some
values of Q.  The new filters were careful to preserve the sound as
much as possible.

WebAudio issue https://github.com/WebAudio/web-audio-api/issues/771.
Resolution: https://github.com/WebAudio/web-audio-api/pull/795
Feature: https://www.chromestatus.com/features/5687523284090880

BUG= 597432 
TEST=biquad-*.html, iirfilter-getFrequencyResponse.thml, iirfilter.html

Review-Url: https://codereview.chromium.org/1885723003
Cr-Commit-Position: refs/heads/master@{#399519}

[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-allpass.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-bandpass.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-highpass.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-highshelf.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-lowpass.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-lowshelf.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-notch.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-peaking.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-tail-expected.txt
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/biquad-tail.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/iirfilter-expected.txt
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/iirfilter-getFrequencyResponse-expected.txt
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/iirfilter.html
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/resources/biquad-filters.js
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/LayoutTests/webaudio/resources/biquad-testing.js
[modify] https://crrev.com/10494397a89162ce998d4ab18761a530d690d67c/third_party/WebKit/Source/platform/audio/Biquad.cpp

Comment 4 by rtoy@chromium.org, Jun 17 2016

Status: Verified (was: Started)

Sign in to add a comment