New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 597431 link

Starred by 1 user
Status: Fixed
Owner:
█ allada@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[DevTools] SourceFrame should implement WebInspector.Searchable

Project Member Reported by allada@chromium.org, Mar 23 2016 
WebInspector.SourceFrame class should implement WebInspector.Searchable interface. The source code is very close to implementing it however its performSearch() signature is slightly different.

See: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js&q=sourceframe.js&sq=package:chromium&type=cs&l=335
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7c77495ebdbc0f96dd6cd92341e7c1c08a1c5e3

commit b7c77495ebdbc0f96dd6cd92341e7c1c08a1c5e3
Author: allada <allada@chromium.org>
Date: Thu Mar 24 23:22:54 2016

SourceFrame implements Search interface
SourceFrame should now implement Search interface.

BUG= 597431 
R=lushnikov

Review URL: https://codereview.chromium.org/1830003002

Cr-Commit-Position: refs/heads/master@{#383183}

[modify] https://crrev.com/b7c77495ebdbc0f96dd6cd92341e7c1c08a1c5e3/third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js
[modify] https://crrev.com/b7c77495ebdbc0f96dd6cd92341e7c1c08a1c5e3/third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js

Comment 2 by allada@chromium.org, Mar 30 2016

Status: Fixed (was: Started)
►

Sign in to add a comment