New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597414 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
no longer active
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[Media Router WebUI] View components not repositioned after header height changes.

Project Member Reported by apaci...@chromium.org, Mar 23 2016

Issue description

In the sink list, we update the height and positioning of all the components under the header in response to any header height changes.

This needs to happen for the rest of the views too. In particular, the route details ends up clipping the top of the extensionview.
 

Comment 1 by sko...@chromium.org, Mar 23 2016

Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa5f0bcbe659641c6902d69a0ca33e8eb785533d

commit aa5f0bcbe659641c6902d69a0ca33e8eb785533d
Author: apacible <apacible@chromium.org>
Date: Fri Mar 25 01:19:12 2016

[Media Router WebUI] Handle header height changes.

Previously, there were two issues:
- The header height is expanded to 62px when the email is shown, but not reduced back to 52px when the email is later hidden.
- The positioning update is only done for the sink view.

This change includes:
- Removing the height styling from CSS and setting it explicitly in the header element.
- Wrapping everything under the first run flow and header in a div for positioning updating purposes.

BUG= 597414 ,  597411 

Review URL: https://codereview.chromium.org/1834573002

Cr-Commit-Position: refs/heads/master@{#383216}

[modify] https://crrev.com/aa5f0bcbe659641c6902d69a0ca33e8eb785533d/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.css
[modify] https://crrev.com/aa5f0bcbe659641c6902d69a0ca33e8eb785533d/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.html
[modify] https://crrev.com/aa5f0bcbe659641c6902d69a0ca33e8eb785533d/chrome/browser/resources/media_router/elements/media_router_container/media_router_container.js
[modify] https://crrev.com/aa5f0bcbe659641c6902d69a0ca33e8eb785533d/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.css
[modify] https://crrev.com/aa5f0bcbe659641c6902d69a0ca33e8eb785533d/chrome/browser/resources/media_router/elements/media_router_header/media_router_header.js
[modify] https://crrev.com/aa5f0bcbe659641c6902d69a0ca33e8eb785533d/chrome/browser/resources/media_router/media_router_common.css
[modify] https://crrev.com/aa5f0bcbe659641c6902d69a0ca33e8eb785533d/chrome/test/data/webui/media_router/media_router_header_tests.js

Status: Fixed (was: Started)

Sign in to add a comment