Not redirected to offline copy, when connected to a network that doesn't have internet connection. |
||||||
Issue descriptionVersion: 50.0.2661.35 OS: Android I setup a wifi hotspot that didn't have an internet connection, which simulates users in areas with poor quality connections that may not always work. When trying to access a page that I have an offline copy for (google.com/finance in the screenshot) through the hotspot, I get a couple of error pages, ending with telling me I'm offline. But it doesn't load the offline page despite having it available. What steps will reproduce the problem? (1) Start Chrome with offline pages enabled and an offline copy saved. (2) Connect to a wifi network, that isn't connected to the internet (3) Navigating to the page with offline copy from step #1 (4) Observe an error page that DNS probe is having trouble connecting (5) Observe an error page that DNS probe failed and Chrome is offline. What is the expected output? In step 5 we should the offline copy instead of the offline error page. What do you see instead? An offline error page appears Please use labels and text to provide additional information.
,
Mar 29 2016
Richard does the show saved copy button work, when you click it?
,
Mar 29 2016
Jian Li, can you check if there is a simple enough fix for this problem. I don't think we should be merging it, unless: * the button does not work, which we need to fix in that case * from the UX perspective we really want it in M50 (it would be nice to have though) Tal, Rachel?
,
Mar 29 2016
No it doesn't work, it will start to load the offline copy, but then redirects to the online version since there's a network connection, which ends at the error page in the screenshot.
,
Mar 30 2016
This is a merge candidate. Fix is in progress.
,
Mar 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71305613fab6397a9c65f7af7f6154039ebe5df7 commit 71305613fab6397a9c65f7af7f6154039ebe5df7 Author: jianli <jianli@chromium.org> Date: Wed Mar 30 21:02:54 2016 Redirect to offline copy on other possible internet connection failures BUG= 597405 Review URL: https://codereview.chromium.org/1841903002 Cr-Commit-Position: refs/heads/master@{#384090} [modify] https://crrev.com/71305613fab6397a9c65f7af7f6154039ebe5df7/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
,
Mar 31 2016
,
Apr 13 2016
I don't think we want to merge the fix since this is not a common case.
,
Apr 15 2016
Verified fixed in Chrome 52.0.2708.0 |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by fgor...@chromium.org
, Mar 23 2016