New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597404 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

WMPI::OnHidden during a pipeline restart should cancel the restart

Project Member Reported by w...@chromium.org, Mar 23 2016

Issue description

It's possible for WMPI to get an OnHidden callback while in the middle
of a suspend/resume restart. Previously it would continue with the
restart, incorrectly resuming after being hidden. It should cancel
any ongoing restart when receiving OnHidden.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01dc013d3ae6e6e1b5a0e34733652b2febabe488

commit 01dc013d3ae6e6e1b5a0e34733652b2febabe488
Author: watk <watk@chromium.org>
Date: Wed Mar 23 23:10:40 2016

media: Cancel any pending pipeline restart when the player is hidden

It's possible for WMPI to get an OnHidden callback while in the middle
of a suspend/resume restart. Previously it would continue with the
restart, incorrectly resuming after being hidden. Now it will cancel
any ongoing restart when receiving OnHidden.

BUG= 597404 

Review URL: https://codereview.chromium.org/1827873003

Cr-Commit-Position: refs/heads/master@{#382964}

[modify] https://crrev.com/01dc013d3ae6e6e1b5a0e34733652b2febabe488/media/blink/webmediaplayer_impl.cc

Comment 2 by w...@chromium.org, Mar 23 2016

Cc: dalecur...@chromium.org
Components: Internals>Media
Labels: Merge-Request-50 OS-Android

Comment 3 by tin...@google.com, Mar 23 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 24 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a86871643138320e2066ee572bc4acba25c55d1

commit 9a86871643138320e2066ee572bc4acba25c55d1
Author: Chris Watkins <watk@chromium.org>
Date: Thu Mar 24 21:43:52 2016

media: Cancel any pending pipeline restart when the player is hidden

It's possible for WMPI to get an OnHidden callback while in the middle
of a suspend/resume restart. Previously it would continue with the
restart, incorrectly resuming after being hidden. Now it will cancel
any ongoing restart when receiving OnHidden.

BUG= 597404 

Review URL: https://codereview.chromium.org/1827873003

Cr-Commit-Position: refs/heads/master@{#382964}
(cherry picked from commit 01dc013d3ae6e6e1b5a0e34733652b2febabe488)

Review URL: https://codereview.chromium.org/1827283002 .

Cr-Commit-Position: refs/branch-heads/2661@{#383}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/9a86871643138320e2066ee572bc4acba25c55d1/media/blink/webmediaplayer_impl.cc

Comment 5 by w...@chromium.org, Mar 28 2016

Status: Fixed (was: Started)

Sign in to add a comment