New issue
Advanced search Search tips

Issue 597359 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Fix incorrect ASSERT/DCHECK

Project Member Reported by rtoy@chromium.org, Mar 23 2016

Issue description

See the comment in https://codereview.chromium.org/1826733002/diff/1/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp#oldcode514

We should fix the ASSERT/DCHECK to assert if it's called.

 

Comment 1 by rtoy@chromium.org, Apr 1 2016

Owner: rtoy@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd6ff6faa76af34b6478396e8ca6aea0f746029f

commit bd6ff6faa76af34b6478396e8ca6aea0f746029f
Author: rtoy <rtoy@chromium.org>
Date: Fri Apr 01 23:45:29 2016

Fix DCHECK to assert always

Change DCHECK(1) to DCHECK(0) so we always assert because we should
never reach this code.

BUG= 597359 
TEST=none

Review URL: https://codereview.chromium.org/1844293006

Cr-Commit-Position: refs/heads/master@{#384717}

[modify] https://crrev.com/bd6ff6faa76af34b6478396e8ca6aea0f746029f/third_party/WebKit/Source/modules/webaudio/AudioNode.cpp

Comment 3 by rtoy@chromium.org, Apr 4 2016

Status: Fixed (was: Started)

Sign in to add a comment