Finch experiment for controlling H264 HW enc |
||||
Issue descriptionVersion: 51 OS: OSX We want to be able to control the hardware encoder feature with a Finch experiment, so we can turn it off dynamically if needed.
,
Apr 7 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e123143c71aae717dca25f3e2767994b3098ccc9 commit e123143c71aae717dca25f3e2767994b3098ccc9 Author: emircan <emircan@chromium.org> Date: Thu Apr 07 21:19:52 2016 Tie kWebRtcH264WithOpenH264FFmpeg and kEnableWebRtcHWH264Encoding flags on Mac This CL enables using VideoToolbox encoder when kWebRtcH264WithOpenH264FFmpeg flag is on. BUG= 597334 Review URL: https://codereview.chromium.org/1852523002 Cr-Commit-Position: refs/heads/master@{#385860} [modify] https://crrev.com/e123143c71aae717dca25f3e2767994b3098ccc9/chrome/app/generated_resources.grd [modify] https://crrev.com/e123143c71aae717dca25f3e2767994b3098ccc9/content/renderer/media/rtc_video_encoder_factory.cc
,
Apr 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62ed28f34a448143ed210990c59ecd94c53e53ef commit 62ed28f34a448143ed210990c59ecd94c53e53ef Author: phoglund <phoglund@chromium.org> Date: Fri Apr 08 08:36:10 2016 Revert "Tie kWebRtcH264WithOpenH264FFmpeg and kEnableWebRtcHWH264Encoding flags on Mac" Speculative revert: appears to cause timeouts and lots of ERROR:video_sender.cc(313)] Failed to encode frame. Error code: -1 errors on WebRTC Mac bots for the h264 tests. BUG= 597334 TBR=emircan@chromium.org Review URL: https://codereview.chromium.org/1868133002 Cr-Commit-Position: refs/heads/master@{#386018} [modify] https://crrev.com/62ed28f34a448143ed210990c59ecd94c53e53ef/chrome/app/generated_resources.grd [modify] https://crrev.com/62ed28f34a448143ed210990c59ecd94c53e53ef/content/renderer/media/rtc_video_encoder_factory.cc
,
Apr 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e6e8e36cbd14975a4ff345dd153b24db6e4c444 commit 3e6e8e36cbd14975a4ff345dd153b24db6e4c444 Author: emircan <emircan@chromium.org> Date: Thu Apr 21 00:06:53 2016 Reland: Tie kWebRtcH264WithOpenH264FFmpeg and kEnableWebRtcHWH264Encoding flags on Mac Additional to the original, this CL checks for >=OSX10.9 in content/common/gpu/media/vt_video_encode_accelerator_mac.cc since VideoToolbox HW features are introduced there. The original CL got reverted because of a failure on a bot running 10.8.5. https://developer.apple.com/library/mac/releasenotes/General/APIDiffsMacOSX10_9/VideoToolbox.html Original CL description: https://codereview.chromium.org/1852523002/ This CL enables using VideoToolbox encoder when kWebRtcH264WithOpenH264FFmpeg flag is on. BUG= 597334 TBR=mcasas@chromium.org, hbos@chromium.org Review URL: https://codereview.chromium.org/1886363002 Cr-Commit-Position: refs/heads/master@{#388611} [modify] https://crrev.com/3e6e8e36cbd14975a4ff345dd153b24db6e4c444/chrome/app/generated_resources.grd [modify] https://crrev.com/3e6e8e36cbd14975a4ff345dd153b24db6e4c444/content/common/gpu/media/vt_video_encode_accelerator_mac.cc [modify] https://crrev.com/3e6e8e36cbd14975a4ff345dd153b24db6e4c444/content/renderer/media/rtc_video_encoder_factory.cc
,
Apr 21 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105 commit bae3d9c4e63d37ebaaffc6a7c381b40d2d064105 Author: kjellander <kjellander@chromium.org> Date: Thu Apr 21 13:46:47 2016 Revert "Reland: Tie kWebRtcH264WithOpenH264FFmpeg and kEnableWebRtcHWH264Encoding flags on Mac" This reverts commit 3e6e8e36cbd14975a4ff345dd153b24db6e4c444. Reason: Causes timeouts and lots of ERROR:video_sender.cc(313)] Failed to encode frame. Error code: -1 errors on WebRTC Mac bots for the h264 tests. See https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/53766 BUG= 597334 TBR=mcasas@chromium.org, hbos@chromium.org Review URL: https://codereview.chromium.org/1912613002 Cr-Commit-Position: refs/heads/master@{#388759} [modify] https://crrev.com/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105/chrome/app/generated_resources.grd [modify] https://crrev.com/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105/content/common/gpu/media/vt_video_encode_accelerator_mac.cc [modify] https://crrev.com/bae3d9c4e63d37ebaaffc6a7c381b40d2d064105/content/renderer/media/rtc_video_encoder_factory.cc
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8ec6afcc3998e96bcaf0a7a7ac24c979b40a83f commit f8ec6afcc3998e96bcaf0a7a7ac24c979b40a83f Author: emircan <emircan@chromium.org> Date: Mon May 09 22:48:11 2016 Reland: Tie kWebRtcH264WithOpenH264FFmpeg and kEnableWebRtcHWH264Encoding flags on Mac This CL tries adding this feature again after the fix landed on https://codereview.chromium.org/1928873002/ that solves HW encoder issues. Original CL description: Additional to the original, this CL checks for >=OSX10.9 in content/common/gpu/media/vt_video_encode_accelerator_mac.cc since VideoToolbox HW features are introduced there. The original CL got reverted because of a failure on a bot running 10.8.5. https://developer.apple.com/library/mac/releasenotes/General/APIDiffsMacOSX10_9/VideoToolbox.html https://codereview.chromium.org/1852523002/ This CL enables using VideoToolbox encoder when kWebRtcH264WithOpenH264FFmpeg flag is on. BUG= 597334 TBR=mcasas@chromium.org, hbos@chromium.org, sandersd@chromium.org Review-Url: https://codereview.chromium.org/1950563006 Cr-Commit-Position: refs/heads/master@{#392454} [modify] https://crrev.com/f8ec6afcc3998e96bcaf0a7a7ac24c979b40a83f/chrome/app/generated_resources.grd [modify] https://crrev.com/f8ec6afcc3998e96bcaf0a7a7ac24c979b40a83f/content/renderer/media/rtc_video_encoder_factory.cc [modify] https://crrev.com/f8ec6afcc3998e96bcaf0a7a7ac24c979b40a83f/media/gpu/vt_video_encode_accelerator_mac.cc
,
Jun 13 2016
,
Jun 14 2016
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 13 2016
What's left here and will it make it to M53?
,
Jul 13 2016
This is done and will make it to 53. |
||||
►
Sign in to add a comment |
||||
Comment 1 by emir...@chromium.org
, Apr 7 2016