New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597328 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

v8.infinite_scroll failure on Linux and Mac Perf bots

Project Member Reported by zh...@chromium.org, Mar 23 2016

Issue description

Comment 2 by zh...@chromium.org, Mar 23 2016

The problem should be fixed by https://codereview.chromium.org/1822353002. Mac 10.11 Perf (5) has cycled green. Will wait a bit to see if other bots will go green.

Comment 3 by zh...@chromium.org, Mar 23 2016

Status: Fixed (was: Untriaged)
Project Member

Comment 4 by 42576172...@developer.gserviceaccount.com, Mar 23 2016

Cc: bsep@chromium.org
Owner: bsep@chromium.org

=== Auto-CCing suspected CL author bsep@chromium.org ===

Hi bsep@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : wtf/CheckedArithmetic.h delegates to base/numerics/safe_math.h.
Author  : bsep
Commit description:
  
CheckedArithmetic was essentially the same functionality as safe_math
but had some edge cases it did not cover (e.g. size_t). Deleted the
CheckedArithmetic implementation and had it forward to safe_math, and
updated its callsites to use the latter's API.

Review URL: https://codereview.chromium.org/1814563002

Cr-Commit-Position: refs/heads/master@{#382773}
Commit  : 1465f844b54478a027711e86011a19214d8de24d
Date    : Wed Mar 23 02:28:27 2016


===== TESTED REVISIONS =====
Revision                Exit Code   Std. Dev.   Num Values  Good?
chromium@382757         0           N/A         5           good
chromium@382767         0           N/A         5           good
chromium@382772         0           N/A         5           good
chromium@382773         1           N/A         5           bad
chromium@382774         1           N/A         5           bad
chromium@382775         1           N/A         5           bad
chromium@382777         1           N/A         5           bad

Bisect job ran on: linux_perf_bisect
Bug ID: 597328

Test Command: src/tools/perf/run_benchmark -v --browser=release --output-format=chartjson --also-run-disabled-tests v8.infinite_scroll
Test Metric: Scrolling-first_gesture_scroll_update_latency/tumblr
Relative Change: Zero to non-zero
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/linux_perf_bisect/builds/6339
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9017376063831286096


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with label Cr-Tests-AutoBisect.  Thank you!

Comment 5 by bsep@chromium.org, Mar 23 2016

Cc: zh...@chromium.org
I changed and relanded the patch. I don't really know what I'm looking at here. Is this still happening with my updated patch?

Comment 6 by zh...@chromium.org, Mar 24 2016

Sorry for the confusion. I actually marked this as fixed in comment#3 because I saw the revert. This was due to bisect auto assignment. Please ignore.

Sign in to add a comment