New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597324 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

flex row height is wrong when containing a scaled-down image

Reported by cyril.au...@gmail.com, Mar 23 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36

Steps to reproduce the problem:
1. demo: https://jsbin.com/nuleve/2/edit?html,css
2. 
3. 

What is the expected behavior?
http://i.stack.imgur.com/OFZae.png

What went wrong?
http://i.stack.imgur.com/Oqr4t.png

Did this work before? N/A 

Chrome version: 49.0.2623.87  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 21.0 r0
 

Comment 1 Deleted

*ing in title, sorry :), demo: https://output.jsbin.com/nuleve
Cc: kavvaru@chromium.org
Components: Blink>CSS
Labels: M-51 hasbisect OS-Linux OS-Mac
Owner: le...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.3 using chrome version 49.0.2623.87 and canary 51.0.2688.0.This is regression issue broken in M36.Please find the bisect information as below.
Narrow Bisect::
Good: 36.0.1948.0  -- (official build 264758)
Bad::36.0.1950.0   --  (official build 264960)


CHANGELOG URL:  https://chromium.googlesource.com/chromium/src/+log/d9d942358cb7031681fa8a10924d69e308243e65..f0e87a679aa6d8643079250b90c9865c2b585aa6

Blink CL :: 
https://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=%2Ftrunk&range=171870%3A171922&mode=html

the above tool Blink CL is giving blank page.Hence providing omahaproxy Blink CL
Omahaproxy Blink CL:
https://chromium.googlesource.com/chromium/blink/+log/d659a2d8aa5ecbb8f535d2b9bdc346257f9e5cd2..181ff5dcbf6852fac235233f63c936a2ff7be9ff?pretty=fuller&n=10000

Possible suspect from the above Omahaproxy Blink CL
https://codereview.chromium.org/237823002

leviw@ could you please look into this issue if it is related to your change,else please help us in finding the appropriate owner for this issue.

Thanks,

Comment 4 by meade@chromium.org, May 4 2016

Cc: le...@chromium.org
Components: -Blink>CSS Blink>Layout
Labels: Hotlist-Interop
Owner: ----
Status: Untriaged (was: Assigned)
Moving to layout since object-fit and incorrect positioning are usually layout things.

Comment 5 by e...@chromium.org, May 4 2016

Cc: cbiesin...@chromium.org
Components: -Blink>Layout Blink>Layout>Flexbox
Status: Available (was: Untriaged)
Labels: -Pri-2 Pri-3
The flexbox spec is fairly specific about sizing, and does not mention object-fit. But I'll email the w3c...
Labels: -Pri-3 Pri-2
Wait, that's not right, object-fit is not related to this at all.

This is some kind of aspect-ratio issue, which is weird since I thought we handled those correctly...
Summary: flex row height is wrong when containing a scaled-down image (was: object-fit:scale-down isn't work properly [CSS])
Sooo, here's the issue. We use this for the height, basically:

    LayoutUnit childIntrinsicContentLogicalHeight = child.intrinsicContentLogicalHeight();

for a replaced element, that is:
    virtual LayoutUnit intrinsicContentLogicalHeight() const { return intrinsicLogicalHeight(); }


which is:
    LayoutUnit intrinsicLogicalHeight() const { return style()->isHorizontalWritingMode() ? intrinsicSize().height() : intrinsicSize().width(); }

Which takes no aspect ratio into account :(
Project Member

Comment 9 by sheriffbot@chromium.org, Jul 17 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 10 by e...@chromium.org, Jul 17 2017

Cc: -le...@chromium.org -cbiesin...@chromium.org
Owner: cbiesin...@chromium.org
Status: Assigned (was: Untriaged)

Sign in to add a comment