This bug tracks the process of updating protobuf library to version 3.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/231c6b3c1a21805754320fe9d72eaf8900abc6eb commit 231c6b3c1a21805754320fe9d72eaf8900abc6eb Author: xyzzyz <xyzzyz@chromium.org> Date: Wed Mar 23 19:44:04 2016 Add <algorithm> header to audio_directive_list.cc The code is using std::{make,push}_heap, but doesn't include the <algorithm> header. It works, because it is pulled as a dependency by something else. I am currently doing an update to third_party library that's currently pulling that header, but will no longer do after the update, breaking this code. BUG= 597321 Review URL: https://codereview.chromium.org/1832463002 Cr-Commit-Position: refs/heads/master@{#382902} [modify] https://crrev.com/231c6b3c1a21805754320fe9d72eaf8900abc6eb/components/copresence/handlers/audio/audio_directive_list.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc8af01635be94103d4ef5da8846ad95bc907291 commit fc8af01635be94103d4ef5da8846ad95bc907291 Author: xyzzyz <xyzzyz@chromium.org> Date: Wed Mar 23 19:44:25 2016 Add <algorithm> header to remote_device_loader.cc The code is using std::find_if, but doesn't include the <algorithm> header. It works, because it is pulled as a dependency by something else. I am currently doing an update to third_party library that's currently pulling that header, but will no longer do after the update, breaking this code. BUG= 597321 Review URL: https://codereview.chromium.org/1825423002 Cr-Commit-Position: refs/heads/master@{#382903} [modify] https://crrev.com/fc8af01635be94103d4ef5da8846ad95bc907291/components/proximity_auth/remote_device_loader.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f4a91b9728184d060805126d604cb7c8733624ee commit f4a91b9728184d060805126d604cb7c8733624ee Author: xyzzyz <xyzzyz@chromium.org> Date: Thu Mar 24 00:32:07 2016 Remove dependency of Blimp on X11/Xlib.h header to avoid namespace polution by #define-s Xlib.h has #define Status int which conflicts with Status class in protobuf BUG= 597321 Review URL: https://codereview.chromium.org/1826073002 Cr-Commit-Position: refs/heads/master@{#382989} [modify] https://crrev.com/f4a91b9728184d060805126d604cb7c8733624ee/blimp/client/app/linux/blimp_main.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a79b8edf66ed993190047d4867a3c8fb221ceaa commit 2a79b8edf66ed993190047d4867a3c8fb221ceaa Author: xyzzyz <xyzzyz@chromium.org> Date: Tue Apr 19 19:28:38 2016 Add license to checklicenses.py for protobuf 'third_party/protobuf/conformance/third_party/jsoncpp/jsoncpp.cpp' has non-whitelisted license 'MIT/X11 (BSD like) Public domain MIT/X11 (BSD like)' The file is released public domain, or MIT/X11 wherever this is not legally possible. BUG= 597321 Review URL: https://codereview.chromium.org/1893333005 Cr-Commit-Position: refs/heads/master@{#388276} [modify] https://crrev.com/2a79b8edf66ed993190047d4867a3c8fb221ceaa/tools/checklicenses/checklicenses.py
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7cf8148f570a1072928fa9ede6e0760edc137cbd commit 7cf8148f570a1072928fa9ede6e0760edc137cbd Author: xyzzyz <xyzzyz@chromium.org> Date: Wed Apr 20 23:50:23 2016 Update //third_party/protobuf to version 3. For context, see https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/zJZPkxEFVxY For the things to look out for while reviewing this, see the doc https://docs.google.com/document/d/1qjSBV2ioi0mykAT1eSXuMaNqO0BIS-j1PeYfxT-TbW4/edit?usp=sharing BUG= 597321 Review URL: https://codereview.chromium.org/1842653006 Cr-Commit-Position: refs/heads/master@{#388596} [modify] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/build/common.gypi [modify] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/sync/internal_api/DEPS [modify] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/sync/internal_api/sync_manager_impl_unittest.cc [modify] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/sync/internal_api/write_node.cc [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/.gitignore [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/.travis.yml [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/BUILD [modify] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/BUILD.gn [modify] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/CHANGES.txt [modify] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/CONTRIBUTORS.txt [delete] https://crrev.com/2481caa65c549888d263fa0990b3951aae411e39/third_party/protobuf/COPYING.txt [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/DEPS [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/LICENSE [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/Makefile.am [modify] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/OWNERS [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/Protobuf.podspec [modify] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/README.chromium [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/README.md [delete] https://crrev.com/2481caa65c549888d263fa0990b3951aae411e39/third_party/protobuf/README.txt [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/WORKSPACE [modify] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/__init__.py [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/appveyor.bat [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/appveyor.yml [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/autogen.sh [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/benchmarks/ProtoBench.java [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/benchmarks/google_message1.dat [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/benchmarks/google_message2.dat [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/benchmarks/google_size.proto [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/benchmarks/google_speed.proto [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/benchmarks/readme.txt [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/cmake/CMakeLists.txt [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/cmake/README.md [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/cmake/extract_includes.bat.in [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/cmake/install.cmake [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/cmake/libprotobuf-lite.cmake [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/cmake/libprotobuf.cmake [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/cmake/libprotoc.cmake [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/cmake/protobuf-config-version.cmake.in [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/cmake/protobuf-config.cmake.in [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/cmake/protobuf-module.cmake.in [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/cmake/protoc.cmake [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/cmake/tests.cmake [delete] https://crrev.com/2481caa65c549888d263fa0990b3951aae411e39/third_party/protobuf/config.h [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/configure.ac [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/ConformanceJava.java [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/Makefile.am [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/README.md [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/conformance.proto [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/conformance_cpp.cc [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/conformance_objc.m [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/conformance_python.py [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/conformance_ruby.rb [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/conformance_test.cc [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/conformance_test.h [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/conformance_test_runner.cc [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/failure_list_cpp.txt [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/failure_list_csharp.txt [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/failure_list_java.txt [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/failure_list_objc.txt [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/failure_list_python.txt [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/failure_list_python_cpp.txt [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/failure_list_ruby.txt [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/third_party/jsoncpp/json.h [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/conformance/third_party/jsoncpp/jsoncpp.cpp [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/.gitignore [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/CHANGES.txt [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/README.md [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/build_packages.bat [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/buildall.sh [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/generate_protos.sh [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/keys/Google.Protobuf.public.snk [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/keys/README.md [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/protos/unittest_issues.proto [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/AddressBook/AddPerson.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/AddressBook/AddressBook.csproj [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/AddressBook/Addressbook.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/AddressBook/ListPeople.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/AddressBook/Program.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/AddressBook/Properties/AssemblyInfo.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/AddressBook/SampleUsage.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/AddressBook/app.config [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Conformance/App.config [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Conformance/Conformance.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Conformance/Google.Protobuf.Conformance.csproj [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Conformance/Program.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Conformance/Properties/AssemblyInfo.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.JsonDump/Google.Protobuf.JsonDump.csproj [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.JsonDump/Program.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.JsonDump/Properties/AssemblyInfo.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.JsonDump/app.config [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/ByteStringTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/CodedInputStreamExtensions.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/CodedInputStreamTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/CodedOutputStreamTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/Collections/MapFieldTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/Collections/RepeatedFieldTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/Compatibility/PropertyInfoExtensionsTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/Compatibility/TypeExtensionsTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/DeprecatedMemberTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/EqualityTester.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/FieldCodecTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/GeneratedMessageTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/Google.Protobuf.Test.csproj [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/IssuesTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/JsonFormatterTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/JsonParserTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/JsonTokenizerTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/Properties/AppManifest.xml [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/Properties/AssemblyInfo.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/Reflection/DescriptorsTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/Reflection/FieldAccessTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/Reflection/TypeRegistryTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/SampleEnum.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/SampleMessages.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestCornerCases.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/MapUnittestProto3.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestImportProto3.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestImportPublicProto3.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestIssues.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestProto3.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/TestProtos/UnittestWellKnownTypes.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/WellKnownTypes/AnyTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/WellKnownTypes/DurationTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/WellKnownTypes/TimestampTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/WellKnownTypes/WrappersTest.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf.Test/packages.config [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/ByteArray.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/ByteString.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/CodedInputStream.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/CodedOutputStream.ComputeSize.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/CodedOutputStream.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Collections/MapField.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Collections/ReadOnlyDictionary.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Collections/RepeatedField.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Compatibility/PropertyInfoExtensions.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Compatibility/TypeExtensions.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/FieldCodec.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/FrameworkPortability.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Google.Protobuf.csproj [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Google.Protobuf.nuspec [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/IDeepCloneable.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/IMessage.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/InvalidJsonException.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/InvalidProtocolBufferException.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/JsonFormatter.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/JsonParser.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/JsonToken.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/JsonTokenizer.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/LimitedInputStream.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/MessageExtensions.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/MessageParser.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Preconditions.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Properties/AssemblyInfo.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/Descriptor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/DescriptorBase.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/DescriptorPool.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/DescriptorUtil.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/DescriptorValidationException.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/EnumDescriptor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/EnumValueDescriptor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/FieldAccessorBase.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/FieldDescriptor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/FieldType.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/FileDescriptor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/GeneratedCodeInfo.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/IDescriptor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/IFieldAccessor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/MapFieldAccessor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/MessageDescriptor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/MethodDescriptor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/OneofAccessor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/OneofDescriptor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/PackageDescriptor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/PartialClasses.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/ReflectionUtil.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/RepeatedFieldAccessor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/ServiceDescriptor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/SingleFieldAccessor.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/Reflection/TypeRegistry.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/Any.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/AnyPartial.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/Api.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/Duration.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/DurationPartial.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/Empty.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protobuf/csharp/src/Google.Protobuf/WellKnownTypes/FieldMask.cs [add] https://crrev.com/7cf8148f570a1072928fa9ede6e0760edc137cbd/third_party/protob
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/132bbd301e93c7f92feed8f29a79539ea8a24c27 commit 132bbd301e93c7f92feed8f29a79539ea8a24c27 Author: xyzzyz <xyzzyz@chromium.org> Date: Thu Apr 28 20:57:26 2016 Split protoc into library and executable. Similarly to the upstream BUILD file, we split the protoc compiler into a library and executable. The purpose is to allow protoc compiler plugins (see plugin.h). BUG= 597321 Review-Url: https://codereview.chromium.org/1923733002 Cr-Commit-Position: refs/heads/master@{#390476} [modify] https://crrev.com/132bbd301e93c7f92feed8f29a79539ea8a24c27/third_party/protobuf/BUILD.gn [modify] https://crrev.com/132bbd301e93c7f92feed8f29a79539ea8a24c27/third_party/protobuf/protobuf.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4d56705f4c988bf48ec2c4856f2b07a9a23ad1f commit a4d56705f4c988bf48ec2c4856f2b07a9a23ad1f Author: jdonnelly <jdonnelly@chromium.org> Date: Thu Apr 28 21:32:44 2016 Revert of Split protoc into library and executable. (patchset #4 id:60001 of https://codereview.chromium.org/1923733002/ ) Reason for revert: Broke compile on WebKit Linux MSAN (and others?) Original issue's description: > Split protoc into library and executable. > > Similarly to the upstream BUILD file, we split the protoc compiler into > a library and executable. The purpose is to allow protoc compiler > plugins (see plugin.h). > > BUG= 597321 TBR=pkasting@chromium.org,xyzzyz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 597321 Review-Url: https://codereview.chromium.org/1929963004 Cr-Commit-Position: refs/heads/master@{#390486} [modify] https://crrev.com/a4d56705f4c988bf48ec2c4856f2b07a9a23ad1f/third_party/protobuf/BUILD.gn [modify] https://crrev.com/a4d56705f4c988bf48ec2c4856f2b07a9a23ad1f/third_party/protobuf/protobuf.gyp
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce0e58ddfd41c1382eea24cb92ee4caf84c7765e commit ce0e58ddfd41c1382eea24cb92ee4caf84c7765e Author: xyzzyz <xyzzyz@chromium.org> Date: Fri Apr 29 00:43:38 2016 Reland: Split protoc into library and executable. Similarly to the upstream BUILD file, we split the protoc compiler into a library and executable. The purpose is to allow protoc compiler plugins (see plugin.h). This was initially submitted as https://codereview.chromium.org/1923733002. In this reland I add the sanitizer deps I removed I thought were unnecessary. They weren't. BUG= 597321 Review-Url: https://codereview.chromium.org/1930173003 Cr-Commit-Position: refs/heads/master@{#390546} [modify] https://crrev.com/ce0e58ddfd41c1382eea24cb92ee4caf84c7765e/third_party/protobuf/BUILD.gn [modify] https://crrev.com/ce0e58ddfd41c1382eea24cb92ee4caf84c7765e/third_party/protobuf/protobuf.gyp
Comment 1 by bugdroid1@chromium.org
, Mar 23 2016