MR extension break Shaka by setting global variables |
||||||||||
Issue descriptionVersion: 51.0.2687.0 OS: all all videos are not loaded in shaka player http://shaka-player-demo.appspot.com/ What steps will reproduce the problem? (1) navigate to http://shaka-player-demo.appspot.com/ (2) load any video, e.g "Car" (YT DASH Test) -- MP4 (3) click Load Stream button What is the expected output? video plays normally What do you see instead? no video is played. console error is as attached. base.js:413 goog.require could not find: shaka.player.DashVideoSource Please use labels and text to provide additional information.
,
Mar 23 2016
,
Mar 23 2016
,
Mar 23 2016
Adam, please close when the fix from Vadim has been cherry-picked to 50. Thanks!
,
Mar 29 2016
I just confirmed that this also breaks Shaka as far back as Chrome 47 on Android. Any update on pushing a fix? From what I can tell, it seems that this shouldn't require an actual update to Chrome. See https://github.com/google/shaka-player/issues/311#issuecomment-203088835
,
Mar 29 2016
The MR extension started experiments in Chrome 50. Prior to that, it was only possible to get MR enabled by turning on the appropriate flag and therefore not a concern that needs to be fixed in any version prior to Chrome 50. The fix will not require a Chrome push, but our component extension releases are tied to Chrome releases and we don't plan on updating anything older than the version for Chrome 50. We are waiting for one other change to land in Chrome and will then update our extension for Chrome 50 after that.
,
Mar 29 2016
I don't have any flags enabled on Android as far as I know. Why do I have this issue on Chrome 47 on Android? What flag should I check for?
,
Mar 29 2016
Sorry, I didn't realize this was an Android issue. I had assumed it was desktop Chrome only. Is it both, or only Android? There is a different deployment mechanism for Android (and yes Media Router has been enabled on Android for much longer than on desktop). Vadim, how is this handled on the Android side?
,
Mar 29 2016
We probably can't fix Clank < Chrome 50 at this point, but for Chrome 50+ we will need to update http://www.gstatic.com/eureka/clank50/cast_sender.js
,
Mar 29 2016
It is both Chrome desktop & Clank. I just discovered that Clank was affected today.
,
Apr 20 2016
Vadim, ping; what's the status here?
,
Apr 26 2016
It should be fixed in clank now, please check.
,
Apr 26 2016
,
Apr 26 2016
,
Apr 26 2016
it's verified fixed in both desktop chrome and clank on build 51.0.2704.7 |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by joeyparrish@chromium.org
, Mar 23 2016Summary: MR extension break Shaka by setting global variables (was: all videos are not loaded in shaka player )