New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597310 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Unify GcTracer, GC histograms, and GC trace events.

Project Member Reported by u...@chromium.org, Mar 23 2016

Issue description

Unify GcTracer, GC histograms, and GC trace events.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2016

Comment 2 by hpayer@chromium.org, Mar 29 2016

Cc: hpayer@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6

commit bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6
Author: ulan <ulan@chromium.org>
Date: Tue Mar 29 17:33:16 2016

Represent speed in GCTracer functions as double instead of int.

This avoids redundant casts, loss of precision, and potential overflows.

BUG= chromium:597310 
LOG=NO

Review URL: https://codereview.chromium.org/1841043002

Cr-Commit-Position: refs/heads/master@{#35113}

[modify] https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6/src/heap/gc-idle-time-handler.cc
[modify] https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6/src/heap/gc-idle-time-handler.h
[modify] https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6/src/heap/gc-tracer.cc
[modify] https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6/src/heap/gc-tracer.h
[modify] https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6/src/heap/heap.cc
[modify] https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6/src/heap/incremental-marking.cc
[modify] https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6/src/heap/mark-compact.cc
[modify] https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6/src/heap/scavenge-job.cc
[modify] https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6/src/heap/scavenge-job.h
[modify] https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6/test/cctest/heap/test-heap.cc
[modify] https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6/test/unittests/heap/gc-idle-time-handler-unittest.cc
[modify] https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6/test/unittests/heap/gc-tracer-unittest.cc
[modify] https://crrev.com/bc272e9f7ca0d17cf74e1ee458fca9750ff0aec6/test/unittests/heap/scavenge-job-unittest.cc

Comment 6 by u...@chromium.org, May 12 2016

Status: Fixed (was: Assigned)

Sign in to add a comment