One of the idea is not to check that submission was successful on Change password form, as it was mentioned on  issue 547494 .

 Issue 547494  has been merged into this issue.

 Issue 603192  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1292fd1de885beaaa353f8d200b62199a625754f

commit 1292fd1de885beaaa353f8d200b62199a625754f
Author: dvadym <dvadym@chromium.org>
Date: Thu Feb 23 16:03:35 2017

[Password Manager] New criteria for a submission detection.

In order to understand that form submission was successful, Password Manager uses very simple criteria: the submission is considered to be successful iff the form is disappeared from the DOM. It fails especially often on change password form, since it's ok for change password form to be in DOM after successful change password, since the user can change password again. This CL implements additional criteria for change password forms: submissions is successful iff the form is disappeared or its fields are cleared.

BUG= 597309 , 683950

Review-Url: https://codereview.chromium.org/2708923006
Cr-Commit-Position: refs/heads/master@{#452505}

[modify] https://crrev.com/1292fd1de885beaaa353f8d200b62199a625754f/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/1292fd1de885beaaa353f8d200b62199a625754f/components/password_manager/core/browser/password_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb43f526b0c14050ce834025dc1021e552e6039a

commit eb43f526b0c14050ce834025dc1021e552e6039a
Author: Christos Froussios <cfroussios@chromium.org>
Date: Fri Aug 18 07:46:08 2017

Return the best match when matching forms to a PasswordFormManager

If a PasswordForm cannot be matched perfectly to PasswordFormManager
(i.e. because it has been modified since it was first observed), it
will be matched to the most similar form. The criteria for matching are
form signature, form name, form action.

Matching the origin is still required for any successful match.

Bug:  597309 
Change-Id: I538f65602a78bdb6ea5b3b666f715f3585c6dc25
Reviewed-on: https://chromium-review.googlesource.com/608971
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495498}
[modify] https://crrev.com/eb43f526b0c14050ce834025dc1021e552e6039a/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/eb43f526b0c14050ce834025dc1021e552e6039a/components/password_manager/core/browser/password_form_manager.h
[modify] https://crrev.com/eb43f526b0c14050ce834025dc1021e552e6039a/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/eb43f526b0c14050ce834025dc1021e552e6039a/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/eb43f526b0c14050ce834025dc1021e552e6039a/components/password_manager/core/browser/password_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d6d26591585e8736fd439d8c518edc4e6a6d15e

commit 0d6d26591585e8736fd439d8c518edc4e6a6d15e
Author: Christos Froussios <cfroussios@chromium.org>
Date: Tue Aug 22 09:51:27 2017

[Password Manager] Ignore empty form names and actions when matching

When matching forms to their PasswordFormManager, we won't use empty
names and empty actions as evidence that two forms are the same.

Bug:  597309 
Change-Id: Id568ada643a89c6ec3faa9edacf7d40bcb5bbd16
Reviewed-on: https://chromium-review.googlesource.com/620768
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#496263}
[modify] https://crrev.com/0d6d26591585e8736fd439d8c518edc4e6a6d15e/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/0d6d26591585e8736fd439d8c518edc4e6a6d15e/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/0d6d26591585e8736fd439d8c518edc4e6a6d15e/components/password_manager/core/browser/password_manager_unittest.cc

It is a kind of a meta bug. Let's merge it with Issue 712010. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb3209a2a966a499243dd844490879f4fb4a6ff8

commit fb3209a2a966a499243dd844490879f4fb4a6ff8
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Tue Mar 06 18:05:28 2018

Improve password form matching.

Current code is written in a way that a form without action or name doesn't match itself. It's a performance problem because PasswordManager::CreatePendingLoginManagers continuously creates a PasswordFormManager for the same form leading to poor performance.
The code was firstly introduced in https://chromium-review.googlesource.com/c/chromium/src/+/620768. However, motivation for it is unclear after discussing together.

Bug:  801702 , 597309 
Change-Id: Ie2458d8d5340852530675b9f5d7f627132e1f3c6
Reviewed-on: https://chromium-review.googlesource.com/946490
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541145}
[modify] https://crrev.com/fb3209a2a966a499243dd844490879f4fb4a6ff8/chrome/browser/password_manager/password_manager_browsertest.cc
[modify] https://crrev.com/fb3209a2a966a499243dd844490879f4fb4a6ff8/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/fb3209a2a966a499243dd844490879f4fb4a6ff8/chrome/browser/password_manager/password_manager_test_base.h
[add] https://crrev.com/fb3209a2a966a499243dd844490879f4fb4a6ff8/chrome/test/data/password/recurring_dynamic_form.html
[modify] https://crrev.com/fb3209a2a966a499243dd844490879f4fb4a6ff8/components/password_manager/core/browser/password_form_manager.cc
[modify] https://crrev.com/fb3209a2a966a499243dd844490879f4fb4a6ff8/components/password_manager/core/browser/password_form_manager_unittest.cc
[modify] https://crrev.com/fb3209a2a966a499243dd844490879f4fb4a6ff8/components/password_manager/core/browser/password_manager_unittest.cc