The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20e808ba94aa4a1ff5d3c16155f86bf93747de42

commit 20e808ba94aa4a1ff5d3c16155f86bf93747de42
Author: dvadym <dvadym@chromium.org>
Date: Fri Apr 08 17:20:36 2016

Better filling on suggestion of password fields in Password Manager.

There are a lot of reasons why PasswordManager could miss a password field for autofilling, for example when there is an invisible dummy password field and it's autofilled instead of correct one. This patch makes that as soon as the user clicks on password field Password Manager will show suggestion dropdown with credentials that are already fetched from store in PasswordFormManager (if this is not enough, we'll need to add fetching credentials, but now it looks as adding non-necessary complexity). So as consequence of this patch Password Manager will show more suggestions on password fields, probably sometimes in cases where it shouldn't.

Precise logic of showing suggestion on password field is the following: A suggestion dropdown is shown on any password field until the user chooses one of the suggestion on some password field, then a suggestion is shown only on this field.

The latter part is made for decreasing number of false positives. For example if there is a change password form with <old password field> and <new password field>, initially suggestions will be shown on clicking on both of them, but as soon as the user accepts it for <old passoword field> it will be not shown for <new password field>.

BUG= 597304 ,  591058 

Review URL: https://codereview.chromium.org/1814193002

Cr-Commit-Position: refs/heads/master@{#386109}

[modify] https://crrev.com/20e808ba94aa4a1ff5d3c16155f86bf93747de42/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/20e808ba94aa4a1ff5d3c16155f86bf93747de42/components/autofill/content/renderer/password_autofill_agent.cc
[modify] https://crrev.com/20e808ba94aa4a1ff5d3c16155f86bf93747de42/components/autofill/content/renderer/password_autofill_agent.h

 Issue 393482  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6ea9dfa43640a82f3c7d07da387d67d485db1c8

commit a6ea9dfa43640a82f3c7d07da387d67d485db1c8
Author: dvadym <dvadym@chromium.org>
Date: Mon Feb 27 11:47:59 2017

More robust fill password fields on click.

Originally, Chrome would only offer suggestions for password fields, when no username were found. Since https://codereview.chromium.org/1814193002, it also offers suggestions
when the user clicks on any password field.
However, if JavaScript changes field names immediately after load, before password fill data reach the renderer, Chrome still fails to display suggestions.

This CL changes PasswordAutofillAgent to use password field data even if fields names were changed. That allows Chrome to show suggestions even in the above mentioned problematic case.

BUG= 597304 

Review-Url: https://codereview.chromium.org/2716873002
Cr-Commit-Position: refs/heads/master@{#453193}

[modify] https://crrev.com/a6ea9dfa43640a82f3c7d07da387d67d485db1c8/chrome/renderer/autofill/password_autofill_agent_browsertest.cc
[modify] https://crrev.com/a6ea9dfa43640a82f3c7d07da387d67d485db1c8/components/autofill/content/renderer/password_autofill_agent.cc