New issue
Advanced search Search tips

Issue 597276 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Suppression for upcoming Skia DEPS roll

Project Member Reported by robertphillips@chromium.org, Mar 23 2016

Issue description

The Skia CL https://codereview.chromium.org/1784863003/ (Switch SkDropShaderImageFilter over to new onFilterImage interface) imperceptibly changed the following layout tests: 

svg/filters/feDropShadow.svg [ Failure ]

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/20984cd5302d53bc545c377a8581b77d2466e80a

commit 20984cd5302d53bc545c377a8581b77d2466e80a
Author: robertphillips <robertphillips@google.com>
Date: Wed Mar 23 17:31:54 2016

Add layout test suppression for upcoming Skia DEPS roll

The Skia CL https://codereview.chromium.org/1784863003/ (Switch SkDropShaderImageFilter over to new onFilterImage interface) imperceptibly changed the following layout tests:

svg/filters/feDropShadow.svg [ Failure ]

BUG= 597276 

Review URL: https://codereview.chromium.org/1831463002

Cr-Commit-Position: refs/heads/master@{#382872}

[modify] https://crrev.com/20984cd5302d53bc545c377a8581b77d2466e80a/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed9670f405fec16b8126708ed1f17ee5c2fb47cb

commit ed9670f405fec16b8126708ed1f17ee5c2fb47cb
Author: robertphillips <robertphillips@google.com>
Date: Wed Mar 23 20:29:13 2016

Auto rebaseline feDropShadow layout test after Skia DEPS roll

The necessary Skia DEPS roll landed in https://codereview.chromium.org/1828543004 at #382889

BUG= 597276 

Review URL: https://codereview.chromium.org/1833473002

Cr-Commit-Position: refs/heads/master@{#382914}

[modify] https://crrev.com/ed9670f405fec16b8126708ed1f17ee5c2fb47cb/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Assigned)

Sign in to add a comment