Instead of originating from the center of the button, the material design ripple effect on bookmarks bar buttons should originate from the location of the click/tap.
Depending on the complexity of the solution here we may want to consider merging back into M-51.
Issue 604986 has been merged into this issue.
Moving this nonessential bug to the next milestone. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Review: https://codereview.chromium.org/2042073002/
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/854a6b15453fce54325ecfe2611a4c854ad7573c commit 854a6b15453fce54325ecfe2611a4c854ad7573c Author: bruthig <bruthig@chromium.org> Date: Mon Jun 20 13:15:40 2016 Centered flood fill style ink drop ripples on LocatedEvents. BUG= 597273 TEST=InkDropHostViewTest.* TEST=FloodFillInkDropRipple.MaxDistanceToCorners Review-Url: https://codereview.chromium.org/2042073002 Cr-Commit-Position: refs/heads/master@{#400666} [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ash/shelf/shelf_button.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ash/shelf/shelf_button.h [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ash/shelf/shelf_view.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/chrome/browser/ui/views/download/download_item_view_md.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/chrome/browser/ui/views/location_bar/bubble_icon_view.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/chrome/browser/ui/views/location_bar/content_setting_image_view.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/chrome/browser/ui/views/location_bar/content_setting_image_view.h [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/chrome/browser/ui/views/location_bar/location_icon_view.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/chrome/browser/ui/views/location_bar/location_icon_view.h [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/chrome/browser/ui/views/toolbar/toolbar_action_view.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/chrome/browser/ui/views/toolbar/toolbar_button.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/events/event.h [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/animation/flood_fill_ink_drop_ripple.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/animation/flood_fill_ink_drop_ripple.h [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/animation/flood_fill_ink_drop_ripple_unittest.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/animation/ink_drop.h [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/animation/ink_drop_host_view.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/animation/ink_drop_host_view.h [add] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/animation/ink_drop_host_view_unittest.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/animation/test/flood_fill_ink_drop_ripple_test_api.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/animation/test/flood_fill_ink_drop_ripple_test_api.h [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/animation/test/ink_drop_host_view_test_api.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/animation/test/ink_drop_host_view_test_api.h [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/controls/button/custom_button.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/controls/button/label_button.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/controls/button/label_button.h [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/controls/button/menu_button.cc [modify] https://crrev.com/854a6b15453fce54325ecfe2611a4c854ad7573c/ui/views/views.gyp
Comment 1 by tdander...@chromium.org
, Mar 23 2016Owner: bruthig@chromium.org
Status: Assigned (was: Available)