New issue
Advanced search Search tips

Issue 597263 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Chromium should use error location info from v8::Message

Reported by caitpott...@gmail.com, Mar 23 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/602.1.25+ (KHTML, like Gecko) Version/9.1 Safari/601.5.17

Steps to reproduce the problem:
N/A

What is the expected behavior?
V8 provides a start position and end position for all messages, corresponding to v8::Scanner::Location, which is used in D8 and Node.js to more nicely display error messages, and provide context which aids in debugging them.

It should be possible to render a marker at the error location in the devtools CodeMirror views, to indicate specifically where the problem in the source text is.

What went wrong?
None of this happens, and it's a less than ideal experience when debugging JavaScript errors.

Did this work before? No 

Chrome version: 51.0.2687.0  Channel: canary
OS Version: OS X 10.11.4
Flash Version:
 
Components: Platform>DevTools>Editing
Owner: lushnikov@chromium.org
Status: Assigned (was: Unconfirmed)
@caitp 
Screen Shot 2016-03-28 at 5.29.44 PM.png
61.7 KB View Download
Is this request for surfacing error column in the editor or in the console? It is there for the editor afaik.
It's a mix ---

For example, in the case of non-Parser-generated errors, we still produce better Location info (in EG v8's RenderCallSite() helpers) --- Error locations from these sorts of errors aren't represented in the editor.

However, the 1-line summary complete with accompanying error location marker in the console would be a nice touch, as well.
Owner: l...@chromium.org

Comment 6 by l...@chromium.org, Jun 1 2016

Since the editor already puts a red, squiggly line in some cases, do you have examples/screenshots of other non-Parser-generated errors that we might be currently missing?
redline.png
16.0 KB View Download

Comment 7 by l...@chromium.org, Jun 23 2016

Labels: Needs-Feedback
Gentle ping: caitpotter88@, do you have a specific example of what you'd like to see in the editor that isn't covered by the screenshot in comment #6?

Thanks!
I can't think of any examples that still apply, this is fixed.

Comment 9 by l...@chromium.org, Jun 23 2016

Status: Fixed (was: Assigned)
Thank you.  Please let us know if you've got more ideas in the future!
Components: Platform>DevTools>Authoring

Sign in to add a comment