New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 597259 link

Starred by 1 user
Status: WontFix
Owner:
█ dgn@chromium.org
Not on Chrome anymore
Closed: Apr 2016
Cc:
tedc...@chromium.org
maybelle@chromium.org
█ bauerb@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 584303



Sign in to add a comment

Add a dependency on the cardview support library

Project Member Reported by dgn@chromium.org, Mar 23 2016 
The Morning Reads UI ( issue 584303 ) is going to be the first UI in Chrome using cards. Because adding libraries has not been possible in the past (dex method count limit), we had to have our own implementation of cards.

Now that dex limits are not an issue anymore, we would like to drop it and start using the support library's CardView.

As for binary size increase, here is a Chrome.apk size comparison, by simply adding the library:

68415759	with cardview
68402115	without cardview
= +13644 bytes

tedchoc@: is that an acceptable tradeoff?

Comment 1 by tedc...@chromium.org, Mar 23 2016 

What does the CardView library give us that our existing one doesn't?  Isn't it just something w/ a 9 patch shadow?

I'd be hesitant to say that any growth is worth it unless we actually need something from the library.

Comment 2 by dgn@chromium.org, Apr 5 2016

Status: WontFix (was: Started)
You're right, we wouldn't get much new out of it. We are moving away from 9 patches for our cards anyway, and recyclerview has most of what we need.

Adding the CL I prepared for that before (https://codereview.chromium.org/1822273002/), in case someone is looking for it later, and closing this.

Thanks!
►

Sign in to add a comment