New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597243 link

Starred by 4 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

thumbnail generation prevents video playback

Project Member Reported by dstockwell@chromium.org, Mar 23 2016

Issue description

Chrome Version       : 49.0.2623.95
OS Version: 7834.60.0

What steps will reproduce the problem?
1. Insert SD card, browse to directory with multiple large videos. eg. 15 ~280 mb MOV files.
2. Double click on a video.

What is the expected result?
Video plays immediately.

What happens instead of that?
Black video player opens.
Nothing happens for several minutes. Thumbnails of videos in the folder start to appear very slowly.


Please provide any additional information below. Attach a screenshot if
possible.

UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 7834.60.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.95 Safari/537.36



 
Screenshot 2016-03-23 at 22.28.56.png
1.2 MB View Download
Cc: ryoh@chromium.org
Owner: hirono@chromium.org
Status: Assigned (was: Unconfirmed)
#CBC-RS/TC-watchlist

Comment 3 by lib...@gmail.com, Mar 30 2016



Confirmed, with the additional information that it isn't even necessary to open a video; as soon as the storage device is mounted, the Files app starts chewing up memory to render thumbnails. Issue reported @ ~0940 EDT on March 30, 2016.

Further details, screenshots: https://productforums.google.com/d/msg/chromebook-central/IfU4Si8rd6g/j4Juj8keCQAJ

2012 Pixel with 4 Gb of RAM, running 
Version 49.0.2623.95 (64-bit)
Platform 7834.60.0 (Official Build) stable-channel link
Firmware Google_Link.2695.1.169

Comment 4 by hirono@chromium.org, Mar 31 2016

Status: Started (was: Assigned)

Comment 5 by hirono@chromium.org, Mar 31 2016

It looks toDataURL blocks file opening.

Comment 6 by mu...@chromium.org, Mar 31 2016

Cc: rohi...@chromium.org ka...@chromium.org hsiangc@chromium.org avkodipelli@chromium.org
 Issue 598673  has been merged into this issue.
It found chrome generated 5GB GIF files under /tmp. 
5GB gif was another problem. created the fix for this issue. crrev.com/1842313005



Project Member

Comment 9 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d9ebe5481791288b7dd28bc51aa608de3e101a9

commit 5d9ebe5481791288b7dd28bc51aa608de3e101a9
Author: hirono <hirono@chromium.org>
Date: Fri Apr 01 08:02:31 2016

Don't load all bytes of video when generating thumbnails.

Previously ImageLoader loaded all bytes of video by using XHR before
generating thumbnails. The CL fixes it so that ImageLoader assign entry
URL to video tag directly, which avoids from loading all bytes to
memory.

BUG= 597243 
TEST=manually

Review URL: https://codereview.chromium.org/1842313005

Cr-Commit-Position: refs/heads/master@{#384515}

[modify] https://crrev.com/5d9ebe5481791288b7dd28bc51aa608de3e101a9/ui/file_manager/image_loader/request.js

Labels: Merge-Request-50 M-50
Status: Fixed (was: Started)
Labels: -M-50 M-51

Comment 12 by tin...@google.com, Apr 2 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 4 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72d9e1dfd3164a33424de724465449924dc6dbf3

commit 72d9e1dfd3164a33424de724465449924dc6dbf3
Author: Daichi Hirono <hirono@chromium.org>
Date: Mon Apr 04 03:54:29 2016

Don't load all bytes of video when generating thumbnails.

Previously ImageLoader loaded all bytes of video by using XHR before
generating thumbnails. The CL fixes it so that ImageLoader assign entry
URL to video tag directly, which avoids from loading all bytes to
memory.

BUG= 597243 
TEST=manually

Review URL: https://codereview.chromium.org/1842313005

Cr-Commit-Position: refs/heads/master@{#384515}
(cherry picked from commit 5d9ebe5481791288b7dd28bc51aa608de3e101a9)

Review URL: https://codereview.chromium.org/1855143002 .

Cr-Commit-Position: refs/branch-heads/2661@{#469}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/72d9e1dfd3164a33424de724465449924dc6dbf3/ui/file_manager/image_loader/request.js

Cc: abodenha@chromium.org fukino@chromium.org yawano@chromium.org berry....@gmail.com posciak@chromium.org
 Issue 600414  has been merged into this issue.
Labels: VerifyIn-54

Comment 16 by ka...@chromium.org, Aug 31 2016

Labels: Bulk-Verified
Status: Verified (was: Fixed)

Sign in to add a comment