New ES6 instanceof in V8 requires rebaselining of layout tests |
||||
Issue descriptionThis is a tracking issue for rebaselining layout tests due to changes ES6 instanceof. Once the feature has shipped in V8 and is sticking, the following tests should be rebaselined: - imported/web-platform-tests/html/semantics/text-level-semantics/the-time-element/001.html - fast/dom/Window/window-postmessage-clone-deep-array.html
,
Mar 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/660ee3c9fc851b47bc17c086ae5222d1e6212e60 commit 660ee3c9fc851b47bc17c086ae5222d1e6212e60 Author: mstarzinger <mstarzinger@chromium.org> Date: Wed Mar 23 15:02:04 2016 [v8] Mark layout tests for rebase on ES6 instanceof. This marks two layout tests for manual rebase after new ES6 instanceof semantics have shipped in V8 and stabilized. One test just produces a different error message, the other runs out of stack earlier. Both changes are expected and don't indicate a bug in ES6 instanceof. R=hablich@chromium.org BUG= chromium:597221 , v8:4447 Review URL: https://codereview.chromium.org/1828663002 Cr-Commit-Position: refs/heads/master@{#382847} [modify] https://crrev.com/660ee3c9fc851b47bc17c086ae5222d1e6212e60/third_party/WebKit/LayoutTests/TestExpectations
,
Apr 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecaad3bb0a8d80e232990dd9ff4583420034b734 commit ecaad3bb0a8d80e232990dd9ff4583420034b734 Author: mstarzinger <mstarzinger@chromium.org> Date: Mon Apr 04 13:16:07 2016 [v8] Mark layout test for rebase on ES6 instanceof. The new ES6 instanceof semantics have by now shipped in V8 and layout tests can be rebaselined. This one test in question can be handled automatically. R=hablich@chromium.org BUG= chromium:597221 , v8:4447 Review URL: https://codereview.chromium.org/1860483002 Cr-Commit-Position: refs/heads/master@{#384892} [modify] https://crrev.com/ecaad3bb0a8d80e232990dd9ff4583420034b734/third_party/WebKit/LayoutTests/TestExpectations
,
Apr 4 2016
We still need to fix fast/dom/Window/window-postmessage-clone-deep-array.html which causes a stack overflow in the "equal" method now. Michael Stanton graciously agreed to take care of that.
,
Apr 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e21e681eaf3dbe65306a29dcb7162e14f1dc2674 commit e21e681eaf3dbe65306a29dcb7162e14f1dc2674 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Mon Apr 04 17:09:09 2016 Auto-rebaseline for r384892 https://chromium.googlesource.com/chromium/src/+/ecaad3bb0 BUG= 597221 TBR=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1859613002 . Cr-Commit-Position: refs/heads/master@{#384934} [modify] https://crrev.com/e21e681eaf3dbe65306a29dcb7162e14f1dc2674/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/e21e681eaf3dbe65306a29dcb7162e14f1dc2674/third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/text-level-semantics/the-time-element/001-expected.txt [add] https://crrev.com/e21e681eaf3dbe65306a29dcb7162e14f1dc2674/third_party/WebKit/LayoutTests/platform/android/imported/web-platform-tests/html/semantics/text-level-semantics/the-time-element/001-expected.txt
,
Apr 4 2016
Mythri: Just FYI. IIRC you ran into a similar issue with fast/dom/Window/window-postmessage-clone-deep-array.html when it is being compiled with Ignition.
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d1997c29e5846c79df3efd9f383ce340f03f8efb commit d1997c29e5846c79df3efd9f383ce340f03f8efb Author: wangxianzhu <wangxianzhu@chromium.org> Date: Fri Jun 17 20:36:34 2016 Change remaining NeedsManualRebaseline to Failure or Pass Failure Some tests have been marked NeedsManualRebaseline for a long time without being rebaselined. Some tests can't be rebaselined because of flakiness. BUG=487344, 620126 , 592409 , 603997 , 597221 , 569139 Review-Url: https://codereview.chromium.org/2075993002 Cr-Commit-Position: refs/heads/master@{#400492} [modify] https://crrev.com/d1997c29e5846c79df3efd9f383ce340f03f8efb/third_party/WebKit/LayoutTests/TestExpectations
,
Apr 7 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mstarzinger@chromium.org
, Mar 23 2016