New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597194 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Use other robhogan account instead.
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Compat



Sign in to add a comment

Image not rescaled when padding is updated

Reported by bnguyen...@gmail.com, Mar 23 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.87 Safari/537.36

Example URL:
http://bready.xyz

Steps to reproduce the problem:
1. Go to page
2. Scroll down to pictures in circle
3. Hover over the pictures

What is the expected behavior?
padding is supposed to change to 0 and the border-radius is supposed to maintain its radius

What went wrong?
The border radius does not apply after hover

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? Yes A few weeks ago

Does this work in other browsers? Yes 

Chrome version: 49.0.2623.87  Channel: stable
OS Version: OS X 10.9.4
Flash Version: Shockwave Flash 21.0 r0
 

Comment 1 by rsesek@chromium.org, Mar 23 2016

Components: Blink>CSS
Can you create a reduced test case on jsbin/jsfiddle that would demonstrate this more easily?

Comment 2 by davve@opera.com, Mar 23 2016

Components: Blink>Animation
Labels: -OS-Mac OS-All
Status: Available (was: Unconfirmed)
Summary: Image not rescaled when padding is updated (was: Border-raduis issue when padding is updated)
I believe http://jsbin.com/fejisawixa/edit?html,output shows the same issue. The image isn't rescaled correctly when, given that box-sizing is specified to border-box, the width constraint forces the image content width to increase when padding is decreased.

Comment 3 by davve@opera.com, Mar 23 2016

Cc: robhogan@chromium.org
Bisect points to https://chromium.googlesource.com/chromium/src/+/5eb722fa5e9e3ac311f46923d0c6f84af5cf316a

My guess is that the change happened to uncover a latent bug. Looking at the code, it seems likely that the act of rounding in LayoutReplaced triggered change invalidation "by chance"; removing the rounding (as done by the patch) causes the box to not notice the width + padding change (because they now add up to the same sum) and to do no change invalidation.

Comment 4 by davve@opera.com, Mar 23 2016

Components: Blink>Layout
Cc: -robhogan@chromium.org
Owner: robhogan@chromium.org
Status: Assigned (was: Available)
https://jsfiddle.net/6m5m943y/2/

Specific problem display

Image is supposed to resize in response to padding, but doesn't
Components: -Blink>Animation
Recreated issue without animations: http://jsbin.com/fiwovabago/1/edit?html,output

Comment 8 by robho...@gmail.com, Mar 29 2016

Status: Started (was: Assigned)

Comment 9 by robho...@gmail.com, Mar 29 2016

Components: -Blink>CSS Blink>Paint>Invalidation
Status: Fixed (was: Started)
Fixed by https://codereview.chromium.org/1837033002

Sign in to add a comment