New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597163 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

PictureImageLayer uses cached SkPicture causing a crash.

Project Member Reported by khushals...@chromium.org, Mar 23 2016

Issue description

Load cnbc.com on the Blimp client.

It crashes since Blimp depends on the display item list retaining the display items, while PictureImageLayer caches the SkPictures, in which case the display items are cleared.
 
Cc: khushals...@chromium.org
 Issue 598041  has been merged into this issue.
Cc: haibinlu@chromium.org
 Issue 598003  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e17a5b61e3e9a14939ebc10a152e108c2a0ba07

commit 8e17a5b61e3e9a14939ebc10a152e108c2a0ba07
Author: khushalsagar <khushalsagar@chromium.org>
Date: Thu Mar 31 18:49:37 2016

cc: Add LayerTreeSetting to disable cached picture raster.

PictureImageLayer currently uses cached picture by default since it was
used by GatherPixelRefs. This is no longer necessary since we now use
GenerateDiscardableImagesMetadata in DisplayItemList to build the image
map, which supports both modes.

BUG= 597163 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1835523002

Cr-Commit-Position: refs/heads/master@{#384346}

[modify] https://crrev.com/8e17a5b61e3e9a14939ebc10a152e108c2a0ba07/cc/layers/picture_image_layer.cc
[modify] https://crrev.com/8e17a5b61e3e9a14939ebc10a152e108c2a0ba07/cc/layers/picture_image_layer_unittest.cc
[modify] https://crrev.com/8e17a5b61e3e9a14939ebc10a152e108c2a0ba07/cc/proto/layer_tree_settings.proto
[modify] https://crrev.com/8e17a5b61e3e9a14939ebc10a152e108c2a0ba07/cc/trees/layer_tree_settings.cc
[modify] https://crrev.com/8e17a5b61e3e9a14939ebc10a152e108c2a0ba07/cc/trees/layer_tree_settings.h
[modify] https://crrev.com/8e17a5b61e3e9a14939ebc10a152e108c2a0ba07/content/renderer/gpu/render_widget_compositor.cc

Status: Fixed (was: Assigned)
Labels: Archive-Blimp

Sign in to add a comment