New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597112 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug

Blocking:
issue 354261



Sign in to add a comment

implement win_analyze=1 for GN

Project Member Reported by dpranke@chromium.org, Mar 22 2016

Issue description

We haven't ported this over from GYP yet, apparently.
 
Status: Fixed (was: Assigned)
never mind, apparently it is "use_vs_code_analysis" and was added in https://codereview.chromium.org/1658903002/ .
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/de9261d3072db949f60ffcaf09df404cfd7b807f

commit de9261d3072db949f60ffcaf09df404cfd7b807f
Author: dpranke <dpranke@chromium.org>
Date: Wed Mar 23 21:43:21 2016

Add MB support for the windows analyze bot.

This adds the MB config for the 'Chromium Windows Analyze' bot
on the chromium.fyi waterfall, and adds the needed flag maps
to disable precompiled headers (incl. adding a disable_precompiled_headers
flag to GN) and adding 'win_analyze' mixin (we need to actually
implement the win_analyze GN flag still, though).

R=brettw@chromium.org, brucedawson@chromium.org
BUG= 597112 

Review URL: https://codereview.chromium.org/1827683002

Cr-Commit-Position: refs/heads/master@{#382931}

[modify] https://crrev.com/de9261d3072db949f60ffcaf09df404cfd7b807f/build/config/BUILD.gn
[modify] https://crrev.com/de9261d3072db949f60ffcaf09df404cfd7b807f/tools/mb/mb_config.pyl

The MB bot is behaving correctly and producing good results - three clean builds produced so far.

Sign in to add a comment