SitePerProcessBrowserTest.PagePopupMenuTest flaky on Linux_Chromeos_Test bot |
|||||
Issue descriptionThe recently added browser test SitePerProcessBrowserTest.PagePopupMenuTest is flaky on Linux_Chromeos_Test bot. It has failed twice on: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/18072 https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/18083 On the same line: ../../content/browser/site_per_process_browsertest.cc:5224: Failure Value of: 354 Expected: popup_rect.x() - rwhv_root->GetViewBounds().x() Which is: 204 The test case is added by kenrb@ in the following cl: https://codereview.chromium.org/1814863002 kenrb@, would you please take a look to see why the pop up menu is not shown up at the same location sometimes?
,
Mar 22 2016
Flaky tests are bad. We should fix or disable this. Thanks!
,
Mar 23 2016
I think I have figured this out. Fix will land today.
,
Mar 23 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/634475dac7690a19874d410536beeb6272d6ce8f commit 634475dac7690a19874d410536beeb6272d6ce8f Author: kenrb <kenrb@chromium.org> Date: Wed Mar 23 19:25:12 2016 Fix flakiness in PopupMenu tests SitePerProcessBrowserTest.PopupMenuTest has some observed flakiness, apparently due to raciness in element repositioning from the change of layout size caused by calling RenderWidgetHostView::SetBounds. The call isn't necessary for the test, so this CL removes it. BUG= 597111 Review URL: https://codereview.chromium.org/1823283003 Cr-Commit-Position: refs/heads/master@{#382897} [modify] https://crrev.com/634475dac7690a19874d410536beeb6272d6ce8f/content/browser/site_per_process_browsertest.cc
,
Mar 23 2016
,
Aug 29 2016
,
Aug 31 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by jen...@chromium.org
, Mar 22 2016