New issue
Advanced search Search tips

Issue 597105 link

Starred by 1 user
Status: Fixed
Owner:
robliao@chromium.org
Closed: Mar 2016
Cc:
osh...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome
Pri: 2
Type: Feature

Blocking:
issue 595498
issue 597761



Sign in to add a comment

Refactor ScreenWin from ui/gfx to ui/display

Project Member Reported by robliao@chromium.org, Mar 22 2016 
1) Move ScreenWin and helper objects to ui/display
2) Make the display binary available to non-ChromeOS builds
3) Ensure that the new binary gets linked into the Chrome main build (it currently isn't generated by default on GN for Windows).
4) Refactor the namespace from gfx to display

Comment 1 by robliao@chromium.org, Mar 24 2016

Blocking: 597761
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8bc8fd634f70395451f8f559fa129ca049c991c

commit b8bc8fd634f70395451f8f559fa129ca049c991c
Author: robliao <robliao@chromium.org>
Date: Mon Mar 28 15:59:37 2016

Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics.
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

BUG= 597105 

Review URL: https://codereview.chromium.org/1825723002

Cr-Commit-Position: refs/heads/master@{#383500}

[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/content/DEPS
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/content/browser/BUILD.gn
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/content/content_browser.gypi
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/testing/buildbot/chromium.win.json
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/testing/buildbot/chromium_trybot.json
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/display/BUILD.gn
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/display/DEPS
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/display/display.gyp
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/display/display_unittests.isolate
[rename] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/display/win/display_info.cc
[rename] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/display/win/display_info.h
[rename] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/display/win/screen_win.cc
[rename] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/display/win/screen_win.h
[rename] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/display/win/screen_win_display.cc
[rename] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/display/win/screen_win_display.h
[rename] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/display/win/screen_win_unittest.cc
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/gfx/BUILD.gn
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/gfx/gfx.gyp
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/gfx/gfx_tests.gyp
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/views/BUILD.gn
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/views/views.gyp
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/views/widget/desktop_aura/desktop_screen_win.cc
[modify] https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c/ui/views/widget/desktop_aura/desktop_screen_win.h

Comment 3 by robliao@chromium.org, Mar 28 2016

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8360d41fdefee4442b861503350b70962d68ffa

commit a8360d41fdefee4442b861503350b70962d68ffa
Author: thakis <thakis@chromium.org>
Date: Mon Mar 28 20:28:24 2016

Revert of Move ScreenWin to ui/display (patchset #2 id:160001 of https://codereview.chromium.org/1825723002/ )

Reason for revert:
Doesn't build in gn/win component builds:

LINK : warning LNK4001: no object files specified; libraries used

LINK : error LNK2001: unresolved external symbol _DllMainCRTStartup

./display_test_util.dll : fatal error LNK1120: 1 unresolved externals

Original issue's description:
> Move ScreenWin to ui/display
>
> ScreenWin along with other Screen related objects is not really about graphics.
> As a result, this goes to a new home called ui/display to hold things related to
> the screen and display.
>
> BUG= 597105 
>
> Committed: https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c
> Cr-Commit-Position: refs/heads/master@{#383500}

TBR=oshima@chromium.org,piman@chromium.org,sky@chromium.org,robliao@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 597105 

Review URL: https://codereview.chromium.org/1834243003

Cr-Commit-Position: refs/heads/master@{#383552}

[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/content/DEPS
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/content/browser/BUILD.gn
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/content/content_browser.gypi
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/testing/buildbot/chromium.win.json
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/testing/buildbot/chromium_trybot.json
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/display/BUILD.gn
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/display/DEPS
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/display/display.gyp
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/display/display_unittests.isolate
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/gfx/BUILD.gn
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/gfx/gfx.gyp
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/gfx/gfx_tests.gyp
[rename] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/gfx/screen_win.cc
[rename] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/gfx/screen_win.h
[rename] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/gfx/screen_win_unittest.cc
[rename] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/gfx/win/display_info.cc
[rename] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/gfx/win/display_info.h
[rename] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/gfx/win/screen_win_display.cc
[rename] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/gfx/win/screen_win_display.h
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/views/BUILD.gn
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/views/views.gyp
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/views/widget/desktop_aura/desktop_screen_win.cc
[modify] https://crrev.com/a8360d41fdefee4442b861503350b70962d68ffa/ui/views/widget/desktop_aura/desktop_screen_win.h
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d63729c779d6b529efb6d6a4c5985470c68f76b

commit 8d63729c779d6b529efb6d6a4c5985470c68f76b
Author: robliao <robliao@chromium.org>
Date: Tue Mar 29 17:49:47 2016

Move ScreenWin to ui/display

ScreenWin along with other Screen related objects is not really about graphics.
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

BUG= 597105 

Committed: https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c
Cr-Commit-Position: refs/heads/master@{#383500}

Review URL: https://codereview.chromium.org/1825723002

Cr-Commit-Position: refs/heads/master@{#383761}

[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/content/DEPS
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/content/browser/BUILD.gn
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/content/browser/renderer_host/render_widget_host_view_aura.cc
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/content/content_browser.gypi
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/testing/buildbot/chromium.mac.json
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/testing/buildbot/chromium.win.json
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/testing/buildbot/chromium_trybot.json
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/display/BUILD.gn
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/display/DEPS
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/display/display.gyp
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/display/display_unittests.isolate
[rename] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/display/win/display_info.cc
[rename] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/display/win/display_info.h
[rename] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/display/win/screen_win.cc
[rename] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/display/win/screen_win.h
[rename] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/display/win/screen_win_display.cc
[rename] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/display/win/screen_win_display.h
[rename] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/display/win/screen_win_unittest.cc
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/gfx/BUILD.gn
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/gfx/gfx.gyp
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/gfx/gfx_tests.gyp
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/views/BUILD.gn
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/views/views.gyp
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/views/widget/desktop_aura/desktop_screen_win.cc
[modify] https://crrev.com/8d63729c779d6b529efb6d6a4c5985470c68f76b/ui/views/widget/desktop_aura/desktop_screen_win.h
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/717d7b8a4d869e687e762036f83f1924c39d0893

commit 717d7b8a4d869e687e762036f83f1924c39d0893
Author: Nico Weber <thakis@chromium.org>
Date: Wed Mar 30 12:32:43 2016

Don't list display_unittests twice for ClangToTLinuxUBSanVptr tester

Unbreaks that bot after https://codereview.chromium.org/1825723002/ added the
same test a second time, causing:

AssertionError: Triggered same task twice: display_unittests/Ubuntu-12.04/546a7a6818/ClangToTLinuxUBSanVptr tester/363

BUG= 597105 
TBR=robliao

Review URL: https://codereview.chromium.org/1840233003 .

Cr-Commit-Position: refs/heads/master@{#383955}

[modify] https://crrev.com/717d7b8a4d869e687e762036f83f1924c39d0893/testing/buildbot/chromium.fyi.json
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/717d7b8a4d869e687e762036f83f1924c39d0893

commit 717d7b8a4d869e687e762036f83f1924c39d0893
Author: Nico Weber <thakis@chromium.org>
Date: Wed Mar 30 12:32:43 2016

Don't list display_unittests twice for ClangToTLinuxUBSanVptr tester

Unbreaks that bot after https://codereview.chromium.org/1825723002/ added the
same test a second time, causing:

AssertionError: Triggered same task twice: display_unittests/Ubuntu-12.04/546a7a6818/ClangToTLinuxUBSanVptr tester/363

BUG= 597105 
TBR=robliao

Review URL: https://codereview.chromium.org/1840233003 .

Cr-Commit-Position: refs/heads/master@{#383955}

[modify] https://crrev.com/717d7b8a4d869e687e762036f83f1924c39d0893/testing/buildbot/chromium.fyi.json
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f9318e2cf3a367967014a354e0d280bdf66247c

commit 9f9318e2cf3a367967014a354e0d280bdf66247c
Author: thakis <thakis@chromium.org>
Date: Wed Mar 30 13:18:32 2016

Fix isolate_tests after https://codereview.chromium.org/1825723002

That change added display_unittests on swarming to several testing/buildbot
json files, but didn't update gn_migration.gypi to make sure
display_unittests_run runs on all platforms (so when the test was prepared
for swarming, the corresponding .isolated file might not yet have been
created).

Should fix e.g. the red isolate_tests step on
https://build.chromium.org/p/chromium.fyi/builders/ClangToTMacASan/builds/5203

BUG= 597105 
TBR=robliao

Review URL: https://codereview.chromium.org/1836353007

Cr-Commit-Position: refs/heads/master@{#383963}

[modify] https://crrev.com/9f9318e2cf3a367967014a354e0d280bdf66247c/build/gn_migration.gypi
Project Member

Comment 9 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9f9318e2cf3a367967014a354e0d280bdf66247c

commit 9f9318e2cf3a367967014a354e0d280bdf66247c
Author: thakis <thakis@chromium.org>
Date: Wed Mar 30 13:18:32 2016

Fix isolate_tests after https://codereview.chromium.org/1825723002

That change added display_unittests on swarming to several testing/buildbot
json files, but didn't update gn_migration.gypi to make sure
display_unittests_run runs on all platforms (so when the test was prepared
for swarming, the corresponding .isolated file might not yet have been
created).

Should fix e.g. the red isolate_tests step on
https://build.chromium.org/p/chromium.fyi/builders/ClangToTMacASan/builds/5203

BUG= 597105 
TBR=robliao

Review URL: https://codereview.chromium.org/1836353007

Cr-Commit-Position: refs/heads/master@{#383963}

[modify] https://crrev.com/9f9318e2cf3a367967014a354e0d280bdf66247c/build/gn_migration.gypi
►

Sign in to add a comment