New issue
Advanced search Search tips

Issue 597099 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Apr 2016
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

recent changes in telemetry_runner.py (autotest) have broken telemetry_Crosperf.py

Project Member Reported by cmt...@chromium.org, Mar 22 2016

Issue description

telemetry_runner.py no longer has a TelemetryResult.parse_benchmark_results function or a TelemetryResult.perf_data.

This breaks telemetry_Crosperf.  telemetry_Crosperf.py (the server site_test) needs to be updated to work properly with the new version of telemetry_runner.py

 
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/toolchain-utils/+/72725f0149c91eda72e6734717f5c857f4659d65

commit 72725f0149c91eda72e6734717f5c857f4659d65
Author: Caroline Tice <cmtice@google.com>
Date: Wed Mar 30 18:10:55 2016

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/4876fb68355faa7c435ef8f5dc4619f040f63988

commit 4876fb68355faa7c435ef8f5dc4619f040f63988
Author: Caroline Tice <cmtice@google.com>
Date: Wed Mar 30 20:48:55 2016

[Autotest] Fix telemetry_Crosperf tests.

Autotest/telemetry has recently changed the format of results
returned from telemetry tests, and removed some functionality
from telemetry_runner.py.  telemetry_Crosperf was depending on
this removed functionality, so it's been broken for the last
few weeks.  This CL puts the removed functionality directly into
telemetry_Crosperf, so it is working again.  Longer term we should
revisit updating Crosperf to not depend on this stuff.

BUG= chromium:597099 
TEST=Tested in nightly tests and in my own chroot and beta tested with
sque@.

Change-Id: I870e94eb21245eb80e44b9b3c412368f0b0402d6
Reviewed-on: https://chromium-review.googlesource.com/336274
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>

[modify] https://crrev.com/4876fb68355faa7c435ef8f5dc4619f040f63988/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py

Status: Fixed (was: Untriaged)
Labels: VerifyIn-51
Status: Verified (was: Fixed)
Bulk verified

Sign in to add a comment