http/tests/linkHeader/link-preload-in-iframe.html layout test is flaky |
||||||
Issue descriptionhttps://codereview.chromium.org/1738133002 introduced a new layout test - http/tests/linkHeader/link-preload-in-iframe.html. This test fails when run with --site-per-process (i.e. makes linux_site_isolation fyi bot red). Regressions: Unexpected text-only failures (1) http/tests/linkHeader/link-preload-in-iframe.html [ Failure ] Test output: This is a testharness.js-based test. FAIL Makes sure that Link headers are loaded from an iframe assert_equals: FAIL: image resource was not loaded expected "squareloaded" but got "notloaded" Harness: the test ran to completion.
,
Mar 22 2016
Thanks lukasza@! Yep, this is failing on other bots as well: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/1234 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/62333 Found via Flakiness dashboard: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2FlinkHeader%2Flink-preload-in-iframe.html Yoav, should this get reverted until the flakiness is resolved?
,
Mar 23 2016
,
Mar 23 2016
I have a speculative attempt to unflake that test at https://codereview.chromium.org/1827773002/ If that fails, I prefer to mark it as a flake in expectations rather than revert the CL, as the CL changes are not the cause of flakiness.
,
Mar 23 2016
I've added japhet@ to that review, since it doesn't look to me like it will help. In the meantime, can you mark the test flaky? It's failing frequently now.
,
Mar 24 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/69e8ba23ef353ca5a06d2d9acd9da50ace03da28 commit 69e8ba23ef353ca5a06d2d9acd9da50ace03da28 Author: yoav <yoav@yoav.ws> Date: Thu Mar 24 16:43:08 2016 Speculative attempt to unflake preload iframe test https://codereview.chromium.org/1738133002 landed an iframe test for preload, which seems to be slightly flaky. This is an attempt to unflake the test by increasing its timeout. BUG= 597097 Review URL: https://codereview.chromium.org/1827773002 Cr-Commit-Position: refs/heads/master@{#383077} [modify] https://crrev.com/69e8ba23ef353ca5a06d2d9acd9da50ace03da28/third_party/WebKit/LayoutTests/http/tests/linkHeader/resources/iframe-link-headers.php
,
Mar 28 2016
Haven't seen any failures since. Thanks!
,
May 18 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by lukasza@chromium.org
, Mar 22 2016