New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 597097 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 477150



Sign in to add a comment

http/tests/linkHeader/link-preload-in-iframe.html layout test is flaky

Project Member Reported by lukasza@chromium.org, Mar 22 2016

Issue description

https://codereview.chromium.org/1738133002 introduced 
a new layout test - http/tests/linkHeader/link-preload-in-iframe.html.  This test fails when run with --site-per-process (i.e. makes linux_site_isolation fyi bot red).

Regressions: Unexpected text-only failures (1)
  http/tests/linkHeader/link-preload-in-iframe.html [ Failure ]

Test output:

This is a testharness.js-based test.
FAIL Makes sure that Link headers are loaded from an iframe assert_equals: FAIL: image resource was not loaded expected "squareloaded" but got "notloaded"
Harness: the test ran to completion.
 
Components: Tests>Flaky
It seems that this is a flaky test:

- It usually passes locally with a Release build.  OTOH, I've seen it fail in Release build both with --site-per-process and without this flag.

- It seems to fail more often in Debug build.

- It seems that the very next linux_site_isolation build is green: https://build.chromium.org/p/chromium.fyi/builders/Site%20Isolation%20Linux/builds/8494
Summary: http/tests/linkHeader/link-preload-in-iframe.html layout test is flaky (was: http/tests/linkHeader/link-preload-in-iframe.html layout test fails with --site-per-process)

Comment 4 by y...@yoav.ws, Mar 23 2016

Status: Assigned (was: Untriaged)
I have a speculative attempt to unflake that test at https://codereview.chromium.org/1827773002/

If that fails, I prefer to mark it as a flake in expectations rather than revert the CL, as the CL changes are not the cause of flakiness.

Comment 5 by creis@chromium.org, Mar 23 2016

I've added japhet@ to that review, since it doesn't look to me like it will help.

In the meantime, can you mark the test flaky?  It's failing frequently now.
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/69e8ba23ef353ca5a06d2d9acd9da50ace03da28

commit 69e8ba23ef353ca5a06d2d9acd9da50ace03da28
Author: yoav <yoav@yoav.ws>
Date: Thu Mar 24 16:43:08 2016

Speculative attempt to unflake preload iframe test

https://codereview.chromium.org/1738133002 landed an iframe test for preload,
which seems to be slightly flaky. This is an attempt to unflake the test
by increasing its timeout.

BUG= 597097 

Review URL: https://codereview.chromium.org/1827773002

Cr-Commit-Position: refs/heads/master@{#383077}

[modify] https://crrev.com/69e8ba23ef353ca5a06d2d9acd9da50ace03da28/third_party/WebKit/LayoutTests/http/tests/linkHeader/resources/iframe-link-headers.php

Comment 7 by creis@chromium.org, Mar 28 2016

Status: Fixed (was: Assigned)
Haven't seen any failures since.  Thanks!

Comment 8 by sshru...@google.com, May 18 2016

Labels: Test-Layout

Sign in to add a comment