We currently re-walk all characters to add up widths/heights which is unnecessary. Additionally, fixing this will let us change the requirement that individual text metrics widths add up to the total width.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f75cb329068c3768b2d4e6b0c0243795c81d1ae6 commit f75cb329068c3768b2d4e6b0c0243795c81d1ae6 Author: pdr <pdr@chromium.org> Date: Wed Mar 23 20:06:56 2016 Remove extra per-character walk in SVGTextLayoutEngine This patch removes a per-character walk in SVGTextLayoutEngine which was unnecessary because the glyph computation has the data available already. BUG= 597076 Review URL: https://codereview.chromium.org/1824193002 Cr-Commit-Position: refs/heads/master@{#382908} [modify] https://crrev.com/f75cb329068c3768b2d4e6b0c0243795c81d1ae6/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/f75cb329068c3768b2d4e6b0c0243795c81d1ae6/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp [modify] https://crrev.com/f75cb329068c3768b2d4e6b0c0243795c81d1ae6/third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4 commit 2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4 Author: Rebaseline Bot <blink-rebaseline-bot@chromium.org> Date: Wed Mar 23 22:23:52 2016 Auto-rebaseline for r382908 https://chromium.googlesource.com/chromium/src/+/f75cb3290 BUG= 597076 TBR=pdr@chromium.org Review URL: https://codereview.chromium.org/1830783002 . Cr-Commit-Position: refs/heads/master@{#382945} [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/08441660b5ba7c44f233e34379ef1dda562d046a/third_party/WebKit/LayoutTests/platform/android/svg/W3C-SVG-1.1/text-text-01-b-expected.png [delete] https://crrev.com/08441660b5ba7c44f233e34379ef1dda562d046a/third_party/WebKit/LayoutTests/platform/android/svg/carto.net/textbox-expected.txt [add] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/android/svg/text/combining-character-queries-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-path-01-b-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-text-01-b-expected.png [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/W3C-SVG-1.1/text-text-07-t-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/longTextOnPath-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/smallFonts-expected.png [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textLayout-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textLayout2-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textOnPath3-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/batik/text/textOnPathSpaces-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/custom/glyph-transformation-with-hkern-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/custom/text-match-highlight-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/text/bidi-reorder-value-lists-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/text/combining-character-queries-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/text/non-bmp-positioning-lists-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/text/select-textLength-spacing-squeeze-1-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/text/select-textLength-spacing-squeeze-2-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/text/select-textLength-spacing-squeeze-3-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/text/select-textLength-spacing-squeeze-4-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/text/select-textLength-spacing-stretch-1-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/text/select-textLength-spacing-stretch-2-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/text/select-textLength-spacing-stretch-3-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/text/select-textLength-spacing-stretch-4-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-path-01-b-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/linux/svg/text/text-selection-text-07-t-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac-mac10.10/svg/text/combining-character-queries-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/text/combining-character-queries-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/text/ligature-queries-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-07-t-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/longTextOnPath-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textLayout-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textLayout2-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textOnPath3-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/textOnPathSpaces-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/verticalText-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/batik/text/verticalTextOnPath-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/custom/glyph-transformation-with-hkern-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/text/bidi-reorder-value-lists-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/text/combining-character-queries-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/text/ligature-queries-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/text/non-bmp-positioning-lists-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/text/text-selection-path-01-b-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/text/text-selection-text-06-t-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/mac/svg/text/text-selection-text-07-t-expected.txt [delete] https://crrev.com/08441660b5ba7c44f233e34379ef1dda562d046a/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/text-path-01-b-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/W3C-SVG-1.1/text-text-07-t-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/longTextOnPath-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/smallFonts-expected.png [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textLayout-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textLayout2-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textOnPath3-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/batik/text/textOnPathSpaces-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/carto.net/textbox-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/custom/glyph-transformation-with-hkern-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/custom/stroke-width-large-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/custom/text-match-highlight-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/text/bidi-reorder-value-lists-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/text/combining-character-queries-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/text/non-bmp-positioning-lists-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/text/text-selection-path-01-b-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/platform/win/svg/text/text-selection-text-07-t-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/svg/text/select-textLength-spacing-squeeze-1-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/svg/text/select-textLength-spacing-squeeze-2-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/svg/text/select-textLength-spacing-squeeze-3-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/svg/text/select-textLength-spacing-squeeze-4-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/svg/text/select-textLength-spacing-stretch-1-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/svg/text/select-textLength-spacing-stretch-2-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/svg/text/select-textLength-spacing-stretch-3-expected.txt [modify] https://crrev.com/2b42dcd3cdcdc63eb695a0e94a79e3cc0f0580e4/third_party/WebKit/LayoutTests/svg/text/select-textLength-spacing-stretch-4-expected.txt
Comment 1 by bugdroid1@chromium.org
, Mar 23 2016