Issue 597069 link

Starred by 2 users

Issue metadata

Status:	Verified
Owner:	est...@chromium.org
Closed:	Apr 2016
Cc:	varkha@chromium.org kylixrd@chromium.org pkasting@chromium.org malaykeshav@chromium.org
Components:	UI>Browser>Infobars UI>HighDPI
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Chrome
Pri:	2
Type:	Feature
Proj-MaterialDesign-NativeUI M-51

[MD] infobar arrow border and inter-bar separators are too thick in 2x DSF

Project Member Reported by est...@chromium.org, Mar 22 2016

Issue description

the infobar border is always 1px, but the arrow's border is 1dp. It should be 1px.

Comment 1 by est...@chromium.org, Mar 22 2016

current and with https://codereview.chromium.org/1826653002/

	infobararrow.png 18.1 KB View Download

	infobararrow2.png 8.7 KB View Download

Comment 2 Deleted

Comment 3 by est...@chromium.org, Mar 22 2016

with patch, top to bottom:
non-md, 1x
non-md, 2x
md, 1x
md, 2x

	infobararrow2.png 211 KB View Download

Comment 4 by est...@chromium.org, Mar 22 2016

Summary: [MD] infobar arrow border and inter-bar separators are too thick in 2x DSF (was: [MD] infobar arrow border is too thick in 2x DSF)

Comment 5 by tdander...@chromium.org, Mar 29 2016

Cc: varkha@chromium.org
Components: UI>HighDPI UI>Browser>Infobars
Labels: -Type-Bug -Pri-3 M-51 Proj-MaterialDesign-NativeUI OS-Chrome OS-Linux OS-Windows Pri-2 Type-Feature

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d9418afc9ddb2254d7c9316ea3043e3e6ff1ffd

commit 1d9418afc9ddb2254d7c9316ea3043e3e6ff1ffd
Author: estade <estade@chromium.org>
Date: Mon Apr 04 18:04:23 2016

Draw infobar arrow border with width of 1px on any scale factor.

BUG= 597069 

Review URL: https://codereview.chromium.org/1826653002

Cr-Commit-Position: refs/heads/master@{#384953}

[modify] https://crrev.com/1d9418afc9ddb2254d7c9316ea3043e3e6ff1ffd/chrome/browser/ui/infobar_container_delegate.cc
[modify] https://crrev.com/1d9418afc9ddb2254d7c9316ea3043e3e6ff1ffd/chrome/browser/ui/infobar_container_delegate.h
[modify] https://crrev.com/1d9418afc9ddb2254d7c9316ea3043e3e6ff1ffd/chrome/browser/ui/views/infobars/infobar_background.cc
[modify] https://crrev.com/1d9418afc9ddb2254d7c9316ea3043e3e6ff1ffd/chrome/browser/ui/views/infobars/infobar_background.h
[modify] https://crrev.com/1d9418afc9ddb2254d7c9316ea3043e3e6ff1ffd/chrome/browser/ui/views/infobars/infobar_view.cc
[modify] https://crrev.com/1d9418afc9ddb2254d7c9316ea3043e3e6ff1ffd/chrome/browser/ui/views/infobars/infobar_view.h

Comment 7 by est...@chromium.org, Apr 8 2016

Status: Fixed (was: Started)

Comment 8 by dhadd...@chromium.org, Oct 18 2016

Status: Verified (was: Fixed)

►

Issue 597069 link

Issue metadata

[MD] infobar arrow border and inter-bar separators are too thick in 2x DSF

Issue description

Comment 1 by est...@chromium.org, Mar 22 2016

Comment 1 Deleted

Comment 2 Deleted

Comment 3 by est...@chromium.org, Mar 22 2016

Comment 3 Deleted

Comment 4 by est...@chromium.org, Mar 22 2016

Comment 4 Deleted

Comment 5 by tdander...@chromium.org, Mar 29 2016

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Apr 4 2016

Comment 6 Deleted

Comment 7 by est...@chromium.org, Apr 8 2016

Comment 7 Deleted

Comment 8 by dhadd...@chromium.org, Oct 18 2016

Comment 8 Deleted

Sign in to add a comment