New issue
Advanced search Search tips

Issue 597053 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature


Sign in to add a comment

bluetooth: Onion Soup Web Bluetooth

Project Member Reported by ortuno@chromium.org, Mar 22 2016

Issue description

Once we move to mojo, we should get rid of the renderer layer.

 

Comment 1 by ortuno@chromium.org, Mar 22 2016

Blockedon: 508771

Comment 2 by scheib@chromium.org, Jul 11 2016

Blocking: -436283 510287
Blocks refactoring issue 510287, not shipping  issue 436283 .

Comment 3 by ortuno@chromium.org, Nov 24 2016

Owner: juncai@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ef7dd4b548d9ccd5e573bf053043ab79070ae08

commit 1ef7dd4b548d9ccd5e573bf053043ab79070ae08
Author: juncai <juncai@chromium.org>
Date: Tue Nov 29 04:28:21 2016

Use new wrapper types for web_bluetooth.mojom

This CL modified code to use new wrapper types for web_bluetooth.mojom.
Also changed all instances of mojo::Array, mojo::String to std::vector,
std::string since mojo::Array, mojo::String have been deprecated.

BUG= 597053 

Review-Url: https://codereview.chromium.org/2506813003
Cr-Commit-Position: refs/heads/master@{#434892}

[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/chrome/android/BUILD.gn
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/browser/bluetooth/bluetooth_allowed_devices_map.cc
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/browser/bluetooth/bluetooth_allowed_devices_map_unittest.cc
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/browser/bluetooth/bluetooth_blocklist.cc
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/browser/bluetooth/bluetooth_blocklist.h
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/browser/bluetooth/bluetooth_blocklist_unittest.cc
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/browser/bluetooth/bluetooth_metrics.cc
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/browser/bluetooth/web_bluetooth_service_impl.h
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/common/BUILD.gn
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/public/android/BUILD.gn
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/renderer/bluetooth/OWNERS
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/renderer/bluetooth/bluetooth_type_converters.cc
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/renderer/bluetooth/bluetooth_type_converters.h
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/renderer/bluetooth/web_bluetooth_impl.cc
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/renderer/bluetooth/web_bluetooth_impl.h
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/content/renderer/presentation/presentation_dispatcher.cc
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/device/bluetooth/public/interfaces/uuid.typemap
[modify] https://crrev.com/1ef7dd4b548d9ccd5e573bf053043ab79070ae08/third_party/WebKit/public/BUILD.gn

Comment 5 by juncai@chromium.org, Nov 29 2016

Status: Started (was: Assigned)
Labels: Merge-Request-56

Comment 7 by dimu@chromium.org, Dec 7 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 7 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ef1e2800423d76e532411af475d57649b76593f

commit 1ef1e2800423d76e532411af475d57649b76593f
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Wed Dec 07 04:57:40 2016

Use new wrapper types for web_bluetooth.mojom

This CL modified code to use new wrapper types for web_bluetooth.mojom.
Also changed all instances of mojo::Array, mojo::String to std::vector,
std::string since mojo::Array, mojo::String have been deprecated.

BUG= 597053 

Review URL: https://codereview.chromium.org/2557013002 .

Review-Url: https://codereview.chromium.org/2506813003
Cr-Original-Commit-Position: refs/heads/master@{#434892}
Cr-Commit-Position: refs/branch-heads/2924@{#373}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/chrome/android/BUILD.gn
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/browser/bluetooth/bluetooth_allowed_devices_map.cc
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/browser/bluetooth/bluetooth_allowed_devices_map_unittest.cc
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/browser/bluetooth/bluetooth_blocklist.cc
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/browser/bluetooth/bluetooth_blocklist.h
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/browser/bluetooth/bluetooth_blocklist_unittest.cc
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/browser/bluetooth/bluetooth_metrics.cc
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/browser/bluetooth/web_bluetooth_service_impl.h
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/common/BUILD.gn
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/public/android/BUILD.gn
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/renderer/bluetooth/OWNERS
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/renderer/bluetooth/bluetooth_type_converters.cc
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/renderer/bluetooth/bluetooth_type_converters.h
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/renderer/bluetooth/web_bluetooth_impl.cc
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/renderer/bluetooth/web_bluetooth_impl.h
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/content/renderer/presentation/presentation_dispatcher.cc
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/device/bluetooth/public/interfaces/uuid.typemap
[modify] https://crrev.com/1ef1e2800423d76e532411af475d57649b76593f/third_party/WebKit/public/BUILD.gn

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/525375f86906a8d27e4afe31d99c47bb2d42552e

commit 525375f86906a8d27e4afe31d99c47bb2d42552e
Author: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Date: Wed Dec 07 06:13:44 2016

Fixes BUILD rules from previous cherrypick

Undos BUILD changes from cherrypick http://crrev.com/2557013002

BUG= 597053 

Review URL: https://codereview.chromium.org/2555093002 .

Cr-Commit-Position: refs/branch-heads/2924@{#375}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/525375f86906a8d27e4afe31d99c47bb2d42552e/chrome/android/BUILD.gn
[modify] https://crrev.com/525375f86906a8d27e4afe31d99c47bb2d42552e/content/public/android/BUILD.gn
[modify] https://crrev.com/525375f86906a8d27e4afe31d99c47bb2d42552e/third_party/WebKit/public/BUILD.gn

Blocking: 593607
Blockedon: 676703
Blockedon: 676702
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb

commit c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb
Author: juncai <juncai@chromium.org>
Date: Tue Jan 03 20:03:59 2017

[Onion Soup] Move WebBluetoothImpl from //content/renderer/bluetooth to Blink's bluetooth module

The Mojo WebBluetoothService can be used directly from Blink. This CL
moves the WebBluetoothImpl from //content/renderer/bluetooth to
//third_party/WebKit/Source/modules/bluetooth.

BUG= 597053 , 561879
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2565913002
Cr-Commit-Position: refs/heads/master@{#441194}

[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/content/renderer/BUILD.gn
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/content/renderer/bluetooth/DEPS
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/content/renderer/bluetooth/OWNERS
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/content/renderer/bluetooth/PRESUBMIT.py
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/content/renderer/bluetooth/bluetooth_type_converters.cc
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/content/renderer/bluetooth/bluetooth_type_converters.h
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/content/renderer/bluetooth/web_bluetooth_impl.cc
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/content/renderer/bluetooth/web_bluetooth_impl.h
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/content/renderer/render_frame_impl.h
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/add-multiple-event-listeners.html
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/LayoutTests/bluetooth/characteristic/notifications/event-after-starting.html
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/add-multiple-event-listeners.html
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/LayoutTests/bluetooth/characteristic/readValue/event-is-fired.html
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/LayoutTests/resources/bluetooth/bluetooth-helpers.js
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/BUILD.gn
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/Bluetooth.h
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.h
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/BluetoothError.h
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.h
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.cpp
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/third_party/WebKit/Source/modules/bluetooth/BluetoothSupplement.h
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/modules/bluetooth/DEPS
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/platform/BUILD.gn
[add] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/platform/mojo/Bluetooth.typemap
[add] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/platform/mojo/BluetoothStructTraits.cpp
[add] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/platform/mojo/BluetoothStructTraits.h
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/platform/mojo/blink_typemaps.gni
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/public/BUILD.gn
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothDevice.h
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothDeviceInit.h
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothRemoteGATTCharacteristic.h
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothRemoteGATTCharacteristicInit.h
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothRemoteGATTService.h
[delete] https://crrev.com/bf96f8354f45b92870f2d80a194b59d97e102fe2/third_party/WebKit/public/platform/modules/bluetooth/WebRequestDeviceOptions.h
[modify] https://crrev.com/c7a55bd0ff1e9816eccb7dc2d4c02ff825c4a7eb/third_party/WebKit/public/web/WebFrameClient.h

Project Member

Comment 14 by bugdroid1@chromium.org, Jan 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/599c47bd57be5be9b13126ca4c7678fa3f067481

commit 599c47bd57be5be9b13126ca4c7678fa3f067481
Author: juncai <juncai@chromium.org>
Date: Tue Jan 03 22:41:37 2017

Shorten some method names in //third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h

This is a follow-up CL for:
https://codereview.chromium.org/2565913002/

Since the device is already a BluetoothDevice, the following methods
at BluetoothDevice class can be renamed:
getOrCreateBluetoothRemoteGATTService -> getOrCreateRemoteGATTService
getOrCreateBluetoothRemoteGATTCharacteristic -> getOrCreateRemoteGATTCharacteristic

BUG= 676703 ,  597053 

Review-Url: https://codereview.chromium.org/2614523002
Cr-Commit-Position: refs/heads/master@{#441227}

[modify] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp
[modify] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.h
[modify] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp
[modify] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h
[modify] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
[modify] https://crrev.com/599c47bd57be5be9b13126ca4c7678fa3f067481/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp

Project Member

Comment 15 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8819858e6747aae06f155f04909b458ee782538c

commit 8819858e6747aae06f155f04909b458ee782538c
Author: juncai <juncai@chromium.org>
Date: Mon Jan 09 23:16:54 2017

Typemap WebBluetoothDeviceId to WTF::String

This is a follow-up CL for:
https://codereview.chromium.org/2565913002/

This CL does the following:
1. Typemap WebBluetoothDeviceId to WTF::String.
2. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the
parameter.
3. Use mojom::blink::WebBluetoothDevicePtr directly in the parameter.
4. Use mojom::blink::WebBluetoothRemoteGATTServicePtr directly in the
parameter.

BUG= 676702 ,  597053 

Review-Url: https://codereview.chromium.org/2615093002
Cr-Commit-Position: refs/heads/master@{#442397}

[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/Bluetooth.h
[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp
[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.h
[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp
[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h
[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.h
[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/platform/mojo/BluetoothStructTraits.cpp
[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/platform/mojo/BluetoothStructTraits.h
[modify] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/Source/platform/mojo/blink_typemaps.gni
[rename] https://crrev.com/8819858e6747aae06f155f04909b458ee782538c/third_party/WebKit/public/platform/modules/bluetooth/Bluetooth.typemap

Status: Fixed (was: Started)
Status: Started (was: Fixed)
Let's keep this open until we fix the nearterm items in  issue 508771  (migrate off IPC) and then move the long term items we aren't fixing now out of blocking that issue and then close that issue.
Blockedon: 681172
Blockedon: 682050
Blockedon: 684263
Blockedon: 697698
Status: Available (was: Started)
juncai@, what's the status here? I'm tentatively you making the owner of this task in this doc: https://docs.google.com/spreadsheets/d/1VIINt17Dg2cJjPpoJ_HY3HI0uLpidql-1u8pBJtpbGk/edit#gid=1603373208
The major goal of onion souping WebBluetooth was to remove //content/renderer/bluetooth/, and that was completed. The remaining is polish work and the only remaining blocked issue is 681172.

I am fine to continue to be the owner of this bug, but currently I am not actively working on this. So if someone would like to work on this, feel free to pick it up.
Thanks! It's not clear to me what the relationship between 681172 and BOS is? It's a little confusing to have this bug still be open if the move into Blink is complete.
I think it's ok to move issue 681172 out of blocking this issue and then close this issue, based on Comment 17 above.

Does anyone have concerns if we close this issue?
Blockedon: -681172
Status: Fixed (was: Available)

Sign in to add a comment